patch "iio:ad7266: Fix broken regulator error handling" added to staging-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iio:ad7266: Fix broken regulator error handling
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
6b7f4e25f3309f106a5c7ff42c8231494cf285d3Mon Sep 17 00:00:00 2001
From: Mark Brown <[email protected]>
Date: Mon, 20 Jun 2016 13:53:32 +0100
Subject: iio:ad7266: Fix broken regulator error handling
All regulator_get() variants return either a pointer to a regulator or an ERR_PTR() so testing for NULL makes no sense and may lead to bugs if we use NULL as a valid regulator. Fix this by using IS_ERR() as expected.
--- drivers/iio/adc/ad7266.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7266.c +1 -1
@@ -397,7 +397,7 @@ static int ad7266_probe(struct spi_device *spi) st =iio_priv (indio_dev); st->reg =devm_regulator_get (&spi->dev,"vref" ); -if (!IS_ERR_OR_NULL (st->reg)) { +if (!IS_ERR (st->reg)) { ret =regulator_enable (st->reg);if (ret)return ret;
Signature · 1 line
2.9.0