Skip to contentSkip to conversation

openconnect: PACKAGECONFIG certain dependencies

PATCH Superseded Joe Slater 3 participants 4 messages Jun 30, 2016 – Jul 1, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Joe Slater

author
#0 lore raw

PATCH 1/1 openconnect: PACKAGECONFIG certain dependencies

Some items now in DEPENDS are configuration options, so we create PACKAGECONFIG[] entries for them.

We do not select pcsc-lite by default because it is GPLv3.

---
 .../openconnect/openconnect_git.bb                 |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +11 -2
index 6d3c252..e81165c 100644
@@ -2,8 +2,17 @@ SUMMARY = "Open client for Cisco AnyConnect VPN"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING.LGPL;md5=243b725d71bb5df4a1e5920b344b86ad"
 
-DEPENDS = "vpnc libxml2 gnutls lz4 krb5 libproxy pcsc-lite"
-RDEPENDS_${PN} = "vpnc"
+DEPENDS = "vpnc libxml2 krb5"
+
+PACKAGECONFIG ??= "gnutls lz4 libproxy"
+
+# config defaults
+PACKAGECONFIG[gnutls] = ",--without-gnutls,gnutls,"
+PACKAGECONFIG[lz4] = ",--without-lz4,lz4,"
+PACKAGECONFIG[libproxy] = ",--without-libproxy,libproxy,"
+
+# not config defaults
+PACKAGECONFIG[pcsc-lite] = ",--without-libpcsclite,pcsc-lite,"
 
 PV = "7.06"
 
Signature · 1 line
1.7.9.5
#1 lore raw

meta-networking/recipes-connectivity/openconnect/openconnect_git.bb SUMMARY = "Open client for Cisco AnyConnect VPN" · line 15

Quoted 10 lines · Joe Slater
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +9 -0
+PACKAGECONFIG ??= "gnutls lz4 libproxy"
+
+# config defaults
+PACKAGECONFIG[gnutls] = ",--without-gnutls,gnutls,"
+PACKAGECONFIG[lz4] = ",--without-lz4,lz4,"
+PACKAGECONFIG[libproxy] = ",--without-libproxy,libproxy,"
+
+# not config defaults
+PACKAGECONFIG[pcsc-lite] = ",--without-libpcsclite,pcsc-lite,"

Why are the options not being passed for the enabled case, here? We prefer to be explicit, rather than relying on defaults.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 12 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Christopher Larson
Sent: Thursday, June 30, 2016 10:13 PM
To: Openembedded Discussion
Subject: Re: [oe] [meta-networking][PATCH 1/1] openconnect: PACKAGECONFIG certain dependencies

On Thu, Jun 30, 2016 at 12:46 PM, Joe Slater <[email protected]> wrote:

Quoted 13 lines

meta-networking/recipes-connectivity/openconnect/openconnect_git.bb SUMMARY = "Open client for Cisco AnyConnect VPN" · line 15

Quoted 10 lines
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +9 -0
+PACKAGECONFIG ??= "gnutls lz4 libproxy"
+
+# config defaults
+PACKAGECONFIG[gnutls] = ",--without-gnutls,gnutls,"
+PACKAGECONFIG[lz4] = ",--without-lz4,lz4,"
+PACKAGECONFIG[libproxy] = ",--without-libproxy,libproxy,"
+
+# not config defaults
+PACKAGECONFIG[pcsc-lite] = ",--without-libpcsclite,pcsc-lite,"

Why are the options not being passed for the enabled case, here? We prefer to be explicit, rather than relying on defaults.

I can easily add them. I left them out because configure help only mentions the --without options to override the defaults.

Joe

Quoted 11 lines

--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 25 lines · Joseph
Quoted 2 lines

-----Original Message-----
From: [email protected] [mailto:

openembedded-devel-

Quoted 4 lines

[email protected]] On Behalf Of Christopher Larson
Sent: Thursday, June 30, 2016 10:13 PM
To: Openembedded Discussion
Subject: Re: [oe] [meta-networking][PATCH 1/1] openconnect:

PACKAGECONFIG certain

Quoted 3 lines

dependencies

On Thu, Jun 30, 2016 at 12:46 PM, Joe Slater <[email protected]>

Quoted 13 lines · wrote:

meta-networking/recipes-connectivity/openconnect/openconnect_git.bb SUMMARY = "Open client for Cisco AnyConnect VPN" · line 15

Quoted 11 lines
meta-networking/recipes-connectivity/openconnect/openconnect_git.bb +9 -0
+PACKAGECONFIG ??= "gnutls lz4 libproxy"
+
+# config defaults
+PACKAGECONFIG[gnutls] = ",--without-gnutls,gnutls,"
+PACKAGECONFIG[lz4] = ",--without-lz4,lz4,"
+PACKAGECONFIG[libproxy] = ",--without-libproxy,libproxy,"
+
+# not config defaults
+PACKAGECONFIG[pcsc-lite] = ",--without-libpcsclite,pcsc-lite,"

Why are the options not being passed for the enabled case, here? We

Quoted 6 lines

prefer

Quoted 1 line

to be explicit, rather than relying on defaults.

I can easily add them. I left them out because configure help only mentions the --without
options to override the defaults.

It'd be best to add them, then we're explicitly specifying what we want, and potentially avoid issues if the upstream default behavior changes during an upgrade in the future.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics