acpica: new package

PATCH New Erico Nunes 5 participants 10 messages Jul 3, 2016 – Jul 5, 2016

Share & tools

Erico Nunes

author

2016-07-03 10:45 UTC #0 lore raw

PATCH v2 1/1 acpica: new package

The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).

It contains tools such as acpidump, iasl, acpixtract, etc.

Signed-off-by Erico Nunes <[email protected]>

Cc Romain Naour <[email protected]>

Cc Peter Korsgaard <[email protected]>

---

Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I hope to have solved in this v2, but I decided to not add it here from the start as this v2 contains some other small fixes and includes a version bump.
If you think that it is still appliable, please add it before applying this patch. Thanks

Changes v1 -> v2:
- Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2 (pointed out by Romain Naour)
- Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by Romain Naour). CC still has to be set as a make argument, otherwise it gets set back again by the Makefile.
- TARGET_ARCH was wrong, should have been BR2_ARCH.
- Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a make argument variable.
- Fixed installing in architectures different than host, by removing the -s argument from 'install' to avoid running 'strip' from host.
- Bumped up to 20160527 which has been released since patch v1 submission.

---
 package/Config.in          |  1 +
 package/acpica/Config.in   |  9 +++++++++
 package/acpica/acpica.hash |  2 ++
 package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/acpica/Config.in
 create mode 100644 package/acpica/acpica.hash
 create mode 100644 package/acpica/acpica.mk

package/Config.in +1 -0

index 3fddf8e..3c8910d 100644
@@ -352,6 +352,7 @@ menu "Firmware"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
+	source "package/acpica/Config.in"
 	source "package/acpid/Config.in"
 	source "package/acpitool/Config.in"
 	source "package/aer-inject/Config.in"

package/acpica/Config.in new file +9 -0

new file mode 100644
index 0000000..8c33d0f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+	bool "acpica"
+	help
+	  The ACPI Component Architecture (ACPICA) project provides an
+	  operating system (OS)-independent reference implementation of
+	  the Advanced Configuration and Power Interface Specification
+	  (ACPI).
+
+	  https://www.acpica.org

package/acpica/acpica.hash new file +2 -0

new file mode 100644
index 0000000..8d5257f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz

package/acpica/acpica.mk new file +26 -0

new file mode 100644
index 0000000..9b32099
@@ -0,0 +1,26 @@
+################################################################################
+#
+# acpica
+#
+################################################################################
+
+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
+		all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))

Signature · 1 line

2.9.0

Romain Naour

2016-07-03 13:45 UTC #1 lore raw

PATCH v2 1/1 acpica: new package

Hi Erico,

Le 03/07/2016 ? 12:45, Erico Nunes a ?crit :

Quoted 9 lines

The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Signed-off-by Erico Nunes <[email protected]>
Cc Romain Naour <[email protected]>
Cc Peter Korsgaard <[email protected]>

Quoted 8 lines

---
Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I hope to have solved in this v2, but I decided to not add it here from the start as this v2 contains some other small fixes and includes a version bump.
If you think that it is still appliable, please add it before applying this patch. Thanks

Thanks, I'll review this new version :)

Quoted 71 lines

Changes v1 -> v2:
- Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2 (pointed out by Romain Naour)
- Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by Romain Naour). CC still has to be set as a make argument, otherwise it gets set back again by the Makefile.
- TARGET_ARCH was wrong, should have been BR2_ARCH.
- Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a make argument variable.
- Fixed installing in architectures different than host, by removing the -s argument from 'install' to avoid running 'strip' from host.
- Bumped up to 20160527 which has been released since patch v1 submission.
---
 package/Config.in          |  1 +
 package/acpica/Config.in   |  9 +++++++++
 package/acpica/acpica.hash |  2 ++
 package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/acpica/Config.in
 create mode 100644 package/acpica/acpica.hash
 create mode 100644 package/acpica/acpica.mk
package/Config.in +1 -0
index 3fddf8e..3c8910d 100644
@@ -352,6 +352,7 @@ menu "Firmware"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
+	source "package/acpica/Config.in"
 	source "package/acpid/Config.in"
 	source "package/acpitool/Config.in"
 	source "package/aer-inject/Config.in"
package/acpica/Config.in new file +9 -0
new file mode 100644
index 0000000..8c33d0f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+	bool "acpica"
+	help
+	  The ACPI Component Architecture (ACPICA) project provides an
+	  operating system (OS)-independent reference implementation of
+	  the Advanced Configuration and Power Interface Specification
+	  (ACPI).
+
+	  https://www.acpica.org
package/acpica/acpica.hash new file +2 -0
new file mode 100644
index 0000000..8d5257f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
package/acpica/acpica.mk new file +6 -0
new file mode 100644
index 0000000..9b32099
@@ -0,0 +1,26 @@
+################################################################################
+#
+# acpica
+#
+################################################################################
+

package/acpica/acpica.mk line 16

Quoted 10 lines

package/acpica/acpica.mk new file +10 -0

+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \

Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed... But indeed if we do that it will use host compiler.

To fix that we need to patch generate/unix/Makefile.config
-CC = gcc
+CC ?= gcc

Can you try with that ?

Thanks,

Best regards,
Romain

Quoted 11 lines

package/acpica/acpica.mk new file +10 -0

+		all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))

Arnout Vandecappelle

2016-07-04 07:33 UTC #2 lore raw

PATCH v2 1/1 acpica: new package

Quoted 112 lines · Romain Naour

Hi Erico,
Le 03/07/2016 ? 12:45, Erico Nunes a ?crit :
Quoted 9 lines
The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Signed-off-by Erico Nunes <[email protected]>
Cc Romain Naour <[email protected]>
Cc Peter Korsgaard <[email protected]>
Quoted 8 lines
---
Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I hope to have solved in this v2, but I decided to not add it here from the start as this v2 contains some other small fixes and includes a version bump.
If you think that it is still appliable, please add it before applying this patch. Thanks
Thanks, I'll review this new version :)
Quoted 71 lines
Changes v1 -> v2:
- Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2 (pointed out by Romain Naour)
- Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by Romain Naour). CC still has to be set as a make argument, otherwise it gets set back again by the Makefile.
- TARGET_ARCH was wrong, should have been BR2_ARCH.
- Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a make argument variable.
- Fixed installing in architectures different than host, by removing the -s argument from 'install' to avoid running 'strip' from host.
- Bumped up to 20160527 which has been released since patch v1 submission.
---
 package/Config.in          |  1 +
 package/acpica/Config.in   |  9 +++++++++
 package/acpica/acpica.hash |  2 ++
 package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/acpica/Config.in
 create mode 100644 package/acpica/acpica.hash
 create mode 100644 package/acpica/acpica.mk
package/Config.in +1 -0
index 3fddf8e..3c8910d 100644
@@ -352,6 +352,7 @@ menu "Firmware"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
+	source "package/acpica/Config.in"
 	source "package/acpid/Config.in"
 	source "package/acpitool/Config.in"
 	source "package/aer-inject/Config.in"
package/acpica/Config.in new file +9 -0
new file mode 100644
index 0000000..8c33d0f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+	bool "acpica"
+	help
+	  The ACPI Component Architecture (ACPICA) project provides an
+	  operating system (OS)-independent reference implementation of
+	  the Advanced Configuration and Power Interface Specification
+	  (ACPI).
+
+	  https://www.acpica.org
package/acpica/acpica.hash new file +2 -0
new file mode 100644
index 0000000..8d5257f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
package/acpica/acpica.mk new file +6 -0
new file mode 100644
index 0000000..9b32099
@@ -0,0 +1,26 @@
+################################################################################
+#
+# acpica
+#
+################################################################################
+
package/acpica/acpica.mk line 16
Quoted 10 lines
package/acpica/acpica.mk new file +10 -0
+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed... But indeed if we do that it will use host compiler.
To fix that we need to patch generate/unix/Makefile.config
(quoted diff) +1 -1
-CC =    gcc
+CC ?=    gcc

Quoted 1 line

Can you try with that ?

Personally, I prefer what is there now: explicitly override CC on the command
line rather than patching the package. I hate patching the package :-)

Regards,
Arnout

Quoted 23 lines

Thanks,
Best regards,
Romain
package/acpica/acpica.mk line 26
Quoted 11 lines
package/acpica/acpica.mk new file +10 -0
+		all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Erico Nunes

author

2016-07-04 13:45 UTC #3 lore raw

PATCH v2 1/1 acpica: new package

In reply to Romain Naour

Hello,

Review

Quoted 6 lines · Romain Naour

Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed... But indeed if we do that it will use host compiler.
To fix that we need to patch generate/unix/Makefile.config
(quoted diff) +1 -1
-CC =    gcc
+CC ?=    gcc

Thanks for re-reviewing!
Yes indeed as the package resets CC in the Makefile, setting it in the environment via TARGET_CONFIGURE_OPTS won't be enough (I tried to explain that in the changelog after the commit message).
In my opinion (agreeing with Arnout), in this case it is less bloaty to just pass it again in the arguments, rather than patching the package.

Quoted 10 lines · Andy Shevchenko

Quoted 5 lines · Erico Nunes
The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into next version of the patch?

Hi Andy.

Thank you for the feedback!
I think, though, that we would need to have some other target Buildroot target package depending on a host version of this one, in order to have it accepted with a host version. Otherwise it is an orphan host package. Or do we have a strong reason to have it enabled as a host package of its own (maybe adding a Config.in.host in this case)?

Erico

Romain Naour

2016-07-04 13:52 UTC #4 lore raw

PATCH v2 1/1 acpica: new package

Hi Erico,

Le 04/07/2016 ? 15:45, Erico Nunes a ?crit :

Quoted 6 lines

Hello,
Quoted 3 lines · Romain Naour
Thanks to TARGET_CONFIGURE_OPTS, CC="$(TARGET_CC) should be removed... But indeed if we do that it will use host compiler.

Quoted 11 lines

Review
Quoted 3 lines
To fix that we need to patch generate/unix/Makefile.config
(quoted diff) +1 -1
-CC =    gcc
+CC ?=    gcc
Thanks for re-reviewing!
Yes indeed as the package resets CC in the Makefile, setting it in the environment via TARGET_CONFIGURE_OPTS won't be enough (I tried to explain that in the changelog after the commit message).
In my opinion (agreeing with Arnout), in this case it is less bloaty to just pass it again in the arguments, rather than patching the package.

Ok, I haven't a strong opinion on this, you can keep it as is :)

Reviewed-by Romain Naour <[email protected]>

Best regards,
Romain

Quoted 26 lines

Quoted 10 lines · Andy Shevchenko
Quoted 5 lines · Erico Nunes
The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into next version of the patch?
Hi Andy.
Thank you for the feedback!
I think, though, that we would need to have some other target Buildroot target package depending on a host version of this one, in order to have it accepted with a host version. Otherwise it is an orphan host package. Or do we have a strong reason to have it enabled as a host package of its own (maybe adding a Config.in.host in this case)?
Erico

Andy Shevchenko

2016-07-04 14:04 UTC #5 lore raw

PATCH v2 1/1 acpica: new package

In reply to Erico Nunes

Quoted 11 lines · Erico Nunes

Hello,
?
It contains tools such as acpidump, iasl, acpixtract, etc.
Quoted 5 lines
Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into
next version of the patch?
Hi Andy.

Quoted 8 lines

Thank you for the feedback!
I think, though, that we would need to have some other target Buildroot target package depending on a host version of this one, in order to have it accepted with a host version. Otherwise it is an orphan host package. Or do we have a strong reason to have it enabled as a host package of its own (maybe adding a Config.in.host in this case)?
?

We would like to add our ASL excerpts to initrd image which requires at least iasl to be present on host side. We are developing the way how to provide ASL excerpts for open connected boards such as Intel Galileo or Minnowboard MAX.

Signature · 2 lines

Andy Shevchenko <[email protected]>
Intel Finland Oy

Andy Shevchenko

2016-07-04 13:33 UTC #6 lore raw

PATCH v2 1/1 acpica: new package

In reply to Erico Nunes

Quoted 5 lines · Erico Nunes

The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.

Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into next version of the patch?

Quoted 113 lines

Signed-off-by Erico Nunes <[email protected]>
Cc Romain Naour <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I
hope to have solved in this v2, but I decided to not add it here from the start as this v2 contains some other small fixes and includes a version bump.
If you think that it is still appliable, please add it before applying this patch. Thanks
Changes v1 -> v2:
? - Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2 ? (pointed out by Romain Naour)
? - Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by ? Romain Naour). CC still has to be set as a make argument, otherwise it
? gets set back again by the Makefile.
? - TARGET_ARCH was wrong, should have been BR2_ARCH.
? - Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a ? make argument variable.
? - Fixed installing in architectures different than host, by removing ? the -s argument from 'install' to avoid running 'strip' from host. ? - Bumped up to 20160527 which has been released since patch v1 ? submission.
---
?package/Config.in??????????|??1 +
?package/acpica/Config.in???|??9 +++++++++
?package/acpica/acpica.hash |??2 ++
?package/acpica/acpica.mk???| 26 ++++++++++++++++++++++++++
?4 files changed, 38 insertions(+)
?create mode 100644 package/acpica/Config.in
?create mode 100644 package/acpica/acpica.hash
?create mode 100644 package/acpica/acpica.mk
package/Config.in +0 -0
index 3fddf8e..3c8910d 100644
@@ -352,6 +352,7 @@ menu "Firmware"
? source "package/zd1211-firmware/Config.in"
?endmenu
? source "package/a10disp/Config.in"
package/Config.in +1 -0
+	source "package/acpica/Config.in"
? source "package/acpid/Config.in"
? source "package/acpitool/Config.in"
? source "package/aer-inject/Config.in"
package/acpica/Config.in new file +4 -0
new file mode 100644
index 0000000..8c33d0f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+	bool "acpica"
+	help
+	??The ACPI Component Architecture (ACPICA) project provides
an
package/acpica/Config.in new file +1 -0
+	??operating system (OS)-independent reference implementation
of
package/acpica/Config.in new file +1 -0
+	??the Advanced Configuration and Power Interface
Specification
package/acpica/Config.in new file +3 -0
+	??(ACPI).
+
+	??https://www.acpica.org
package/acpica/acpica.hash new file +2 -0
new file mode 100644
index 0000000..8d5257f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256
4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
package/acpica/acpica.mk new file +1 -0
new file mode 100644
index 0000000..9b32099
@@ -0,0 +1,26 @@
+#####################################################################
###########
package/acpica/acpica.mk new file +4 -0
+#
+# acpica
+#
+#####################################################################
###########
package/acpica/acpica.mk new file +11 -0
+
+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX
CC="$(TARGET_CC)" \
package/acpica/acpica.mk new file +10 -0
+		all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))

Signature · 2 lines

Andy Shevchenko <[email protected]>
Intel Finland Oy

Erico Nunes

author

2016-07-04 13:41 UTC #7 lore raw

PATCH v2 1/1 acpica: new package

Quoted 129 lines · Andy Shevchenko

Quoted 5 lines · Erico Nunes
The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Thank you for doing this!
Though in our case we need this as a host tool. Can you add support into next version of the patch?
Quoted 103 lines
Signed-off-by Erico Nunes <[email protected]>
Cc Romain Naour <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
Romain had added a (conditional) Reviewed-by and Tested-by to v1 which I
hope to have solved in this v2, but I decided to not add it here from the start as this v2 contains some other small fixes and includes a version bump.
If you think that it is still appliable, please add it before applying this patch. Thanks
Changes v1 -> v2:
- Fixed license which is not only GPLv2 but dual BSD-3c or GPLv2 (pointed out by Romain Naour)
- Changed TARGET_MAKE_ENV to TARGET_CONFIGURE_OPTS (pointed out by Romain Naour). CC still has to be set as a make argument, otherwise
it
gets set back again by the Makefile.
- TARGET_ARCH was wrong, should have been BR2_ARCH.
- Got rid of the sed hack for 'uname' by passing HARDWARE_NAME as a make argument variable.
- Fixed installing in architectures different than host, by removing the -s argument from 'install' to avoid running 'strip' from host.
- Bumped up to 20160527 which has been released since patch v1 submission.
---
 package/Config.in          |  1 +
 package/acpica/Config.in   |  9 +++++++++
 package/acpica/acpica.hash |  2 ++
 package/acpica/acpica.mk   | 26 ++++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/acpica/Config.in
 create mode 100644 package/acpica/acpica.hash
 create mode 100644 package/acpica/acpica.mk
package/Config.in +1 -0
index 3fddf8e..3c8910d 100644
@@ -352,6 +352,7 @@ menu "Firmware"
      source "package/zd1211-firmware/Config.in"
 endmenu
      source "package/a10disp/Config.in"
+     source "package/acpica/Config.in"
      source "package/acpid/Config.in"
      source "package/acpitool/Config.in"
      source "package/aer-inject/Config.in"
package/acpica/Config.in new file +4 -0
new file mode 100644
index 0000000..8c33d0f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+     bool "acpica"
+     help
+       The ACPI Component Architecture (ACPICA) project provides
an
+ operating system (OS)-independent reference implementation
of
+ the Advanced Configuration and Power Interface
Specification
package/acpica/Config.in new file +3 -0
+       (ACPI).
+
+       https://www.acpica.org
package/acpica/acpica.hash new file +2 -0
new file mode 100644
index 0000000..8d5257f
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256
4ac73a5887b643dcca483f0241cbb808a53326846928edad9a2f86cffcde5850 acpica-unix2-20160527.tar.gz
package/acpica/acpica.mk new file +1 -0
new file mode 100644
index 0000000..9b32099
@@ -0,0 +1,26 @@
+#####################################################################
###########
package/acpica/acpica.mk new file +4 -0
+#
+# acpica
+#
+#####################################################################
###########
package/acpica/acpica.mk new file +11 -0
+
+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+     $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+             HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX
CC="$(TARGET_CC)" \
package/acpica/acpica.mk line 26
Quoted 10 lines
package/acpica/acpica.mk new file +10 -0
+             all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+     $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+             HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+             INSTALLFLAGS=-m555 install
+endef
+
+$(eval $(generic-package))
--
Andy Shevchenko <[email protected]> Intel Finland Oy

Thomas Petazzoni

2016-07-05 08:16 UTC #8 lore raw

PATCH v2 1/1 acpica: new package

In reply to Erico Nunes

Hello,

package/acpica/acpica.mk line 16

Quoted 10 lines · Erico Nunes

package/acpica/acpica.mk new file +10 -0

+ACPICA_VERSION = 20160527
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = BSD-3c or GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \

The HARDWARE_NAME variable is pretty useless, it's only used to echo some messages. But I've kept it since it's used, and sent a patch upstream to get rid of it (https://github.com/acpica/acpica/pull/152).

package/acpica/acpica.mk line 23

Quoted 4 lines

package/acpica/acpica.mk new file +4 -0

+define ACPICA_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		HARDWARE_NAME=$(BR2_ARCH) DESTDIR="$(TARGET_DIR)" \
+		INSTALLFLAGS=-m555 install

555 is a bit unusual for binaries, we prefer to use 755. I've changed it and applied your patch.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2016-07-05 17:15 UTC #9 lore raw

PATCH v2 1/1 acpica: new package

In reply to Erico Nunes

Hello,

Quoted 10 lines · Erico Nunes

The ACPI Component Architecture (ACPICA) project provides an operating system (OS)-independent reference implementation of the Advanced Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
Signed-off-by Erico Nunes <[email protected]>
Cc Romain Naour <[email protected]>
Cc Peter Korsgaard <[email protected]>
---

This package fails to build on MIPS64:

http://autobuild.buildroot.net/results/d7a/d7adbd07c5e74f0305ac03fab615290dfa20e9b5/build-end.log

Could you have a look ?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com