Skip to contentSkip to conversation

drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

PATCH Applied Matthew Auld 5 participants 5 messages Jul 5, 2016 – Jul 14, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

This should already be handled by drm_gem_object_release, which is called later on.

---
 drivers/gpu/drm/i915/i915_gem.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +0 -1
index 20123c0..9dc274c 100644
@@ -4908,7 +4908,6 @@ void i915_gem_free_object(struct drm_gem_object *gem_obj)
 	if (discard_backing_storage(obj))
 		obj->madv = I915_MADV_DONTNEED;
 	i915_gem_object_put_pages(obj);
-	i915_gem_object_free_mmap_offset(obj);
 
 	BUG_ON(obj->pages);
 
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Matthew Auld

This should already be handled by drm_gem_object_release, which is called later on.

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
URL : https://patchwork.freedesktop.org/series/9516/
State : failure

== Summary ==

Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox

Test gem_exec_flush:

        Subgroup basic-batch-kernel-default-cmd:
                pass       -> FAIL       (ro-byt-n2820)
        Subgroup basic-batch-kernel-default-wb:
                pass       -> DMESG-FAIL (ro-bdw-i7-5557U)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> SKIP       (fi-skl-i5-6260u)
fi-kbl-qkkr      total:234  pass:162  dwarn:28  dfail:1   fail:2   skip:41 
fi-skl-i5-6260u  total:234  pass:204  dwarn:0   dfail:1   fail:2   skip:27 
fi-skl-i7-6700k  total:234  pass:191  dwarn:0   dfail:1   fail:2   skip:40 
fi-snb-i7-2600   total:234  pass:178  dwarn:0   dfail:0   fail:2   skip:54 
ro-bdw-i5-5250u  total:229  pass:204  dwarn:1   dfail:1   fail:0   skip:23 
ro-bdw-i7-5557U  total:229  pass:203  dwarn:2   dfail:2   fail:0   skip:22 
ro-bdw-i7-5600u  total:229  pass:190  dwarn:0   dfail:1   fail:0   skip:38 
ro-byt-n2820     total:229  pass:180  dwarn:0   dfail:1   fail:3   skip:45 
ro-hsw-i3-4010u  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-hsw-i7-4770r  total:229  pass:197  dwarn:0   dfail:1   fail:0   skip:31 
ro-ilk-i7-620lm  total:229  pass:157  dwarn:0   dfail:1   fail:1   skip:70 
ro-ilk1-i5-650   total:224  pass:157  dwarn:0   dfail:1   fail:1   skip:65 
ro-ivb-i7-3770   total:229  pass:188  dwarn:0   dfail:1   fail:0   skip:40 
ro-skl3-i5-6260u total:229  pass:208  dwarn:1   dfail:1   fail:0   skip:19 
ro-snb-i7-2620M  total:229  pass:179  dwarn:0   dfail:1   fail:1   skip:48 

ro-bsw-n3050 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1418/

2a6e307 drm-intel-nightly: 2016y-07m-05d-11h-50m-09s UTC integration manifest 61651dc drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

Quoted 6 lines · Patchwork

== Series Details ==

Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
URL : https://patchwork.freedesktop.org/series/9516/
State : failure

Quoted 8 lines

== Summary ==

Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox

Test gem_exec_flush:

        Subgroup basic-batch-kernel-default-cmd:
                pass       -> FAIL       (ro-byt-n2820)

https://bugs.freedesktop.org/show_bug.cgi?id=95372

Quoted 2 lines
        Subgroup basic-batch-kernel-default-wb:
                pass       -> DMESG-FAIL (ro-bdw-i7-5557U)

Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96927

Quoted 3 lines

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-a:
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)

Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96913
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Applied
#4 lore raw

Re: ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

Merged, thanks for the patch and review.

Regards, Joonas

Quoted 28 lines · Matthew Auld
Quoted 7 lines · Patchwork

== Series Details ==

Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call URL   : https://patchwork.freedesktop.org/series/9516/
State : failure

Quoted 8 lines

== Summary ==

Series 9516v1 drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
http://patchwork.freedesktop.org/api/1.0/series/9516/revisions/1/mbox

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-cmd:
                pass       -> FAIL       (ro-byt-n2820)

https://bugs.freedesktop.org/show_bug.cgi?id=95372

Quoted 3 lines

        Subgroup basic-batch-kernel-default-wb:
                pass       -> DMESG-FAIL (ro-bdw-i7-5557U)

Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96927

Quoted 4 lines

Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)

Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=96913

Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx