Patch "net: Don't forget pr_fmt on net_dbg_ratelimited for CONFIG_DYNAMIC_DEBUG" has been added to the 4.6-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
net: Don't forget pr_fmt on net_dbg_ratelimited for CONFIG_DYNAMIC_DEBUG
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-don-t-forget-pr_fmt-on-net_dbg_ratelimited-for-config_dynamic_debug.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Jul 6 16:50:56 PDT 2016
From: "Jason A. Donenfeld" <[email protected]>
Date: Wed, 15 Jun 2016 11:14:53 +0200
Subject: net: Don't forget pr_fmt on net_dbg_ratelimited for CONFIG_DYNAMIC_DEBUG
From: "Jason A. Donenfeld" <[email protected]>
[ Upstream commit daddef76c3deaaa7922f9d7b18edbf0a061215c3 ]
The implementation of net_dbg_ratelimited in the CONFIG_DYNAMIC_DEBUG case was added with 2c94b5373 ("net: Implement net_dbg_ratelimited() for CONFIG_DYNAMIC_DEBUG case"). The implementation strategy was to take the usual definition of the dynamic_pr_debug macro, but alter it by adding a call to "net_ratelimit()" in the if statement. This is, in fact, the correct approach.
However, while doing this, the author of the commit forgot to surround fmt by pr_fmt, resulting in unprefixed log messages appearing in the console. So, this commit adds back the pr_fmt(fmt) invocation, making net_dbg_ratelimited properly consistent across DEBUG, no DEBUG, and DYNAMIC_DEBUG cases, and bringing parity with the behavior of dynamic_pr_debug as well.
--- include/linux/net.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/net.h +2 -1
@@ -252,7 +252,8 @@ do { \DEFINE_DYNAMIC_DEBUG_METADATA (descriptor, fmt); \if (unlikely (descriptor.flags & _DPRINTK_FLAGS_PRINT) && \net_ratelimit ()) \ - __dynamic_pr_debug(&descriptor, fmt, ##__VA_ARGS__); \ +__dynamic_pr_debug (&descriptor,pr_fmt (fmt), \ + ##__VA_ARGS__); \ } while (0)#elif defined(DEBUG )#define net_dbg_ratelimited (fmt, ...) \
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/net-don-t-forget-pr_fmt-on-net_dbg_ratelimited-for-config_dynamic_debug.patch