ASoC: Intel: cht: fix uninit variable warning
Subsystems (3)
PATCH 1/2 ASoC: Intel: cht: fix uninit variable warning
Kbuild bot reports that we might use dai_index uninitialized.
sound/soc/intel/boards/cht_bsw_rt5645.c:391:37: warning: 'dai_index' may be used uninitialized in this function [-Wmaybe-uninitialized]
Since it is theoretically possible, set it while initializing.
--- sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/cht_bsw_rt5645.c +1 -1
@@ -357,7 +357,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev)char codec_name[16 ];struct sst_acpi_mach *mach;const char *i2c_name =NULL ; -int dai_index; +int dai_index =0 ; drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_ATOMIC );if (!drv)
Signature · 1 line
1.9.1
PATCH 2/2 ASoC: Intel: atom: statify cht_quirk
Sparse rightly warns:sound/soc/intel/atom/sst/sst_acpi.c:353:22: warning: symbol 'cht_quirk' was not declared. Should it be static?
So statify this
--- sound/soc/intel/atom/sst/sst_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/atom/sst/sst_acpi.c +1 -1
@@ -350,7 +350,7 @@ static struct sst_acpi_mach cht_surface_mach = {"10EC5640" ,"cht-bsw-rt5645" ,"intel/fw_sst_22a8.bin" ,"cht-bsw" ,NULL , &chv_platform_data }; -struct sst_acpi_mach *cht_quirk (void *arg) +static struct sst_acpi_mach *cht_quirk (void *arg) {struct sst_acpi_mach *mach = arg;
Signature · 1 line
1.9.1
Mark Brown
maintainerApplied "ASoC: Intel: atom: statify cht_quirk" to the asoc tree
The patch
ASoC: Intel: atom: statify cht_quirk
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
24dad509ed5528bbbe31ff17f9fb39c0473ec8f4Mon Sep 17 00:00:00 2001
From: Vinod Koul <[email protected]>
Date: Fri, 8 Jul 2016 18:30:18 +0530
Subject: [PATCH] ASoC: Intel: atom: statify cht_quirk
Sparse rightly warns:sound/soc/intel/atom/sst/sst_acpi.c:353:22: warning: symbol 'cht_quirk' was not declared. Should it be static?
So statify this
--- sound/soc/intel/atom/sst/sst_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/atom/sst/sst_acpi.c +1 -1
@@ -350,7 +350,7 @@ static struct sst_acpi_mach cht_surface_mach = {"10EC5640" ,"cht-bsw-rt5645" ,"intel/fw_sst_22a8.bin" ,"cht-bsw" ,NULL , &chv_platform_data }; -struct sst_acpi_mach *cht_quirk (void *arg) +static struct sst_acpi_mach *cht_quirk (void *arg) {struct sst_acpi_mach *mach = arg;
Signature · 1 line
2.8.1
Mark Brown
maintainerApplied "ASoC: Intel: cht: fix uninit variable warning" to the asoc tree
In reply to Vinod KoulThe patch
ASoC: Intel: cht: fix uninit variable warning
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
5d554ea4f287665b839975ecb11bd29d49a5c9b5Mon Sep 17 00:00:00 2001
From: Vinod Koul <[email protected]>
Date: Fri, 8 Jul 2016 18:30:17 +0530
Subject: [PATCH] ASoC: Intel: cht: fix uninit variable warning
Kbuild bot reports that we might use dai_index uninitialized.
sound/soc/intel/boards/cht_bsw_rt5645.c:391:37: warning: 'dai_index' may be used uninitialized in this function [-Wmaybe-uninitialized]
Since it is theoretically possible, set it while initializing.
--- sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/cht_bsw_rt5645.c +1 -1
@@ -357,7 +357,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev)char codec_name[16 ];struct sst_acpi_mach *mach;const char *i2c_name =NULL ; -int dai_index; +int dai_index =0 ; drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_ATOMIC );if (!drv)
Signature · 1 line
2.8.1