enable lpm, acl and other missing libraries in ppc64le
v2 cover enable lpm, acl and other missing libraries in ppc64le
From: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (ip_pipeline and l3fwd).
Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.
v2 changes:
- enabling libs in config included as part of lib changes itself.
gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm on ppc_64
acl: add altivec intrinsics for dpdk acl on ppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache align rte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support for em_hash_key
app/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100644 lib/librte_acl/acl_run_altivec.c create mode 100644 lib/librte_acl/acl_run_altivec.h create mode 100644 lib/librte_eal/common/include/arch/ppc_64/rte_vect.h create mode 100644 lib/librte_lpm/rte_lpm_altivec.h
Signature · 1 line
1.9.1
PATCH v2 1/6 lpm: add altivec intrinsics for dpdk lpm on ppc_64
From: gowrishankar <[email protected]>
This patch adds ppc64le port for LPM library in DPDK.
--- app/test/test_xmmt_ops.h | 16 +++ config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - .../common/include/arch/ppc_64/rte_vect.h | 60 ++++++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 +++++++++++++++++++++ 6 files changed, 234 insertions(+), 1 deletion(-) create mode 100644 lib/librte_eal/common/include/arch/ppc_64/rte_vect.h create mode 100644 lib/librte_lpm/rte_lpm_altivec.h
app/test/test_xmmt_ops.h +16 -0
@@ -62,6 +62,22 @@ vect_set_epi32(int i3, int i2, int i1, int i0)/* sets the 4 signed 32-bit integer values and returns the xmm_t variable */ #define vect_set_epi32 (i3, i2, i1, i0) _mm_set_epi32(i3, i2, i1, i0) +#elif defined(RTE_ARCH_PPC_64 ) + +/* vect_* abstraction implementation using ALTIVEC */ + +/* loads the xmm_t value from address p(does not need to be 16-byte aligned)*/ +#define vect_loadu_sil128 (p) vec_ld(0, p) + +/* sets the 4 signed 32-bit integer values and returns the xmm_t variable */ +static inline xmm_t __attribute__((always_inline)) +vect_set_epi32 (int i3,int i2,int i1,int i0) +{ +xmm_t data = (xmm_t ){i0, i1, i2, i3}; + +return data; +} +#endif #endif /* _TEST_XMMT_OPS_H_ */
config/defconfig_ppc_64-power8-linuxapp-gcc +0 -1
@@ -57,7 +57,6 @@ CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries are not available on Power. So they're turned off. -CONFIG_RTE_LIBRTE_LPM=n CONFIG_RTE_LIBRTE_ACL=n CONFIG_RTE_LIBRTE_SCHED=n CONFIG_RTE_LIBRTE_PORT=n
lib/librte_eal/common/include/arch/ppc_64/rte_vect.h new file +60 -0
60 lines not on this page · raw message
lib/librte_lpm/Makefile +2 -0
@@ -51,6 +51,8 @@ ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h else ifeq ($(CONFIG_RTE_ARCH_X86),y) SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h +else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_altivec.h endif # this lib needs eal
lib/librte_lpm/rte_lpm.h +2 -0
@@ -480,6 +480,8 @@ rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],#if defined(RTE_ARCH_ARM ) || defined(RTE_ARCH_ARM64 )#include "rte_lpm_neon.h" +#elif defined(RTE_ARCH_PPC_64 ) +#include "rte_lpm_altivec.h" #else #include "rte_lpm_sse.h" #endif
lib/librte_lpm/rte_lpm_altivec.h new file +154 -0
154 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH v2 2/6 acl: add altivec intrinsics for dpdk acl on ppc_64
In reply to GowrishankarFrom: gowrishankar <[email protected]>
This patch adds port for ACL library in ppc64le.
--- app/test-acl/main.c | 4 + config/defconfig_ppc_64-power8-linuxapp-gcc | 1 - lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 ++++ lib/librte_acl/acl_run_altivec.h | 328 ++++++++++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 ++ lib/librte_acl/rte_acl.h | 1 + 9 files changed, 401 insertions(+), 1 deletion(-) create mode 100644 lib/librte_acl/acl_run_altivec.c create mode 100644 lib/librte_acl/acl_run_altivec.h
app/test-acl/main.c +4 -0
@@ -105,6 +105,10 @@ static const struct acl_alg acl_alg[] = { .name = "neon", .alg = RTE_ACL_CLASSIFY_NEON, }, + { + .name = "altivec", + .alg = RTE_ACL_CLASSIFY_ALTIVEC, + }, }; static struct {
config/defconfig_ppc_64-power8-linuxapp-gcc +0 -1
@@ -57,7 +57,6 @@ CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries are not available on Power. So they're turned off. -CONFIG_RTE_LIBRTE_ACL=n CONFIG_RTE_LIBRTE_SCHED=n CONFIG_RTE_LIBRTE_PORT=n CONFIG_RTE_LIBRTE_TABLE=n
lib/librte_acl/Makefile +2 -0
@@ -52,6 +52,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_scalar.c ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_neon.c CFLAGS_acl_run_neon.o += -flax-vector-conversions -Wno-maybe-uninitialized +else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) +SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_altivec.c else SRCS-$(CONFIG_RTE_LIBRTE_ACL) += acl_run_sse.c #check if flag for SSE4.1 is already on, if not set it up manually
lib/librte_acl/acl.h +4 -0
@@ -234,6 +234,10 @@ int rte_acl_classify_neon(const struct rte_acl_ctx *ctx, const uint8_t **data, uint32_t *results, uint32_t num, uint32_t categories); +int +rte_acl_classify_altivec (const struct rte_acl_ctx *ctx,const uint8_t **data, +uint32_t *results,uint32_t num,uint32_t categories); + #ifdef __cplusplus }#endif /* __cplusplus */
lib/librte_acl/acl_run.h +2 -0
@@ -39,7 +39,9 @@#define MAX_SEARCHES_AVX16 16#define MAX_SEARCHES_SSE8 8 +#define MAX_SEARCHES_ALTIVEC8 8#define MAX_SEARCHES_SSE4 4 +#define MAX_SEARCHES_ALTIVEC4 4#define MAX_SEARCHES_SCALAR 2#define GET_NEXT_4BYTES (prm, idx) \
lib/librte_acl/acl_run_altivec.c new file +47 -0
47 lines not on this page · raw message
lib/librte_acl/acl_run_altivec.h new file +328 -0
328 lines not on this page · raw message
lib/librte_acl/rte_acl.c +13 -0
@@ -75,12 +75,23 @@ rte_acl_classify_neon(__rte_unused const struct rte_acl_ctx *ctx,return -ENOTSUP ; } +int __attribute__ ((weak)) +rte_acl_classify_altivec(__rte_unused const struct rte_acl_ctx *ctx, + __rte_unused const uint8_t **data, + __rte_unused uint32_t *results, + __rte_unused uint32_t num, + __rte_unused uint32_t categories) +{ +return -ENOTSUP ; +} +static const rte_acl_classify_t classify_fns[] = { [RTE_ACL_CLASSIFY_DEFAULT ] = rte_acl_classify_scalar, [RTE_ACL_CLASSIFY_SCALAR ] = rte_acl_classify_scalar, [RTE_ACL_CLASSIFY_SSE ] = rte_acl_classify_sse, [RTE_ACL_CLASSIFY_AVX2 ] = rte_acl_classify_avx2, [RTE_ACL_CLASSIFY_NEON ] = rte_acl_classify_neon, + [RTE_ACL_CLASSIFY_ALTIVEC ] = rte_acl_classify_altivec, };/* by default, use always available scalar code path. */
@@ -119,6 +130,8 @@ rte_acl_init(void)#elif defined(RTE_ARCH_ARM )if (rte_cpu_get_flag_enabled (RTE_CPUFLAG_NEON )) alg =RTE_ACL_CLASSIFY_NEON ; +#elif defined(RTE_ARCH_PPC_64 ) + alg =RTE_ACL_CLASSIFY_ALTIVEC ;#else #ifdef CC_AVX2_SUPPORT if (rte_cpu_get_flag_enabled (RTE_CPUFLAG_AVX2 ))
lib/librte_acl/rte_acl.h +1 -0
@@ -271,6 +271,7 @@ enum rte_acl_classify_alg {RTE_ACL_CLASSIFY_SSE =2 ,/**< requires SSE4.1 support. */ RTE_ACL_CLASSIFY_AVX2 =3 ,/**< requires AVX2 support. */ RTE_ACL_CLASSIFY_NEON =4 ,/**< requires NEON support. */ +RTE_ACL_CLASSIFY_ALTIVEC =5 ,/**< requires ALTIVEC support. */ RTE_ACL_CLASSIFY_NUM /* should always be the last one. */ };
Signature · 1 line
1.9.1
PATCH v2 3/6 ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
In reply to GowrishankarFrom: gowrishankar <[email protected]>
offline lcore would still refer to original core id and this has to be considered while creating cpu core mask.
--- config/defconfig_ppc_64-power8-linuxapp-gcc | 3 --- examples/ip_pipeline/cpu_core_map.c | 12 +----------- examples/ip_pipeline/init.c | 4 ++++ 3 files changed, 5 insertions(+), 14 deletions(-)
config/defconfig_ppc_64-power8-linuxapp-gcc +0 -3
@@ -58,6 +58,3 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n # This following libraries are not available on Power. So they're turned off. CONFIG_RTE_LIBRTE_SCHED=n -CONFIG_RTE_LIBRTE_PORT=n -CONFIG_RTE_LIBRTE_TABLE=n -CONFIG_RTE_LIBRTE_PIPELINE=n
examples/ip_pipeline/cpu_core_map.c +1 -11
@@ -351,9 +351,6 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)int lcore_socket_id =cpu_core_map_get_socket_id_linux (lcore_id); -if (lcore_socket_id <0 ) -return -1 ; -if (((uint32_t ) lcore_socket_id) == socket_id) n_detected++; }
@@ -368,18 +365,11 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)cpu_core_map_get_socket_id_linux ( lcore_id); -if (lcore_socket_id <0 ) -return -1 ; -int lcore_core_id =cpu_core_map_get_core_id_linux ( lcore_id); -if (lcore_core_id <0 ) -return -1 ; - -if (((uint32_t ) lcore_socket_id == socket_id) && - ((uint32_t ) lcore_core_id == core_id)) { +if ((uint32_t ) lcore_socket_id == socket_id) { uint32_t pos = cpu_core_map_pos(map, socket_id, core_id_contig,
examples/ip_pipeline/init.c +4 -0
@@ -59,7 +59,11 @@ static void app_init_core_map(struct app_params *app) {APP_LOG (app,HIGH ,"Initializing CPU core map ..." ); +#if defined(RTE_ARCH_PPC_64 ) + app->core_map =cpu_core_map_init (2 ,5 ,1 ,0 ); +#else app->core_map =cpu_core_map_init (4 ,32 ,4 ,0 ); +#endif if (app->core_map ==NULL )rte_panic ("Cannot create CPU core map\n" );
Signature · 1 line
1.9.1
PATCH v2 4/6 table: cache align rte_bucket_4_8
In reply to GowrishankarFrom: gowrishankar <[email protected]>
Align rte_bucket_4_8 for cache line.
--- lib/librte_table/rte_table_hash_key8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_table/rte_table_hash_key8.c +1 -1
@@ -68,7 +68,7 @@ struct rte_bucket_4_8 {uint64_t key[4 ];/* Cache line 1 */ -uint8_t data[0 ]; + uint8_t data[0] __rte_cache_aligned; };struct rte_table_hash {
Signature · 1 line
1.9.1
PATCH v2 5/6 sched: enable sched library for ppc64le
In reply to GowrishankarFrom: gowrishankar <[email protected]>
This patch enables librte_sched in ppc64le.
--- config/defconfig_ppc_64-power8-linuxapp-gcc | 2 -- 1 file changed, 2 deletions(-)
config/defconfig_ppc_64-power8-linuxapp-gcc +0 -2
@@ -56,5 +56,3 @@ CONFIG_RTE_LIBRTE_PMD_BOND=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n -# This following libraries are not available on Power. So they're turned off. -CONFIG_RTE_LIBRTE_SCHED=n
Signature · 1 line
1.9.1
PATCH v2 6/6 l3fwd: add altivec support for em_hash_key
In reply to GowrishankarFrom: gowrishankar <[email protected]>
This patch adds ppc64le port for em_mask_key function.
--- examples/l3fwd/l3fwd_em.c | 8 ++++++++ 1 file changed, 8 insertions(+)
examples/l3fwd/l3fwd_em.c +8 -0
@@ -259,6 +259,14 @@ em_mask_key(void *key, xmm_t mask)return vandq_s32 (data, mask); } +#elif defined(RTE_MACHINE_CPUFLAG_ALTIVEC ) +static inline xmm_t +em_mask_key (void *key,xmm_t mask) +{ +xmm_t data =vec_ld (0 , (xmm_t *)(key)); + +return vec_and (data, mask); +}#endif static inline uint8_t
Signature · 1 line
1.9.1
Gowrishankar,
Nice patches! Do you have some function test result? I need some time to verify the patches.
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To: [email protected]
Cc: Chao Zhu <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep <[email protected]>; gowrishankar <[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le
From: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (ip_pipeline and l3fwd).
Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.
v2 changes:
- enabling libs in config included as part of lib changes itself.
gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm on ppc_64
acl: add altivec intrinsics for dpdk acl on ppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache align rte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support for em_hash_key
app/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100644 lib/librte_acl/acl_run_altivec.c create mode 100644 lib/librte_acl/acl_run_altivec.h create mode 100644 lib/librte_eal/common/include/arch/ppc_64/rte_vect.h create mode 100644 lib/librte_lpm/rte_lpm_altivec.h
--
1.9.1
Hi Chao,
Quoted 4 lines · Chao Zhu
Gowrishankar,
Nice patches! Do you have some function test result? I need some time to verify the patches.
Please find below lpm and acl units tests (Test OK at the end of each tests).
# ./app/test < EAL/PMD logs> APP: HPET is not enabled, using TSC as default timer RTE>>lpm_autotest No. routes = 1076806 Route distribution per prefix width: DEPTH QUANTITY (PERCENT) --------------------------- 01 0 (0.00) 02 0 (0.00) 03 1 (0.00) 04 0 (0.00) 05 3 (0.00) 06 2 (0.00) 07 4 (0.00) 08 201 (0.02) 09 37 (0.00) 10 55 (0.01) 11 97 (0.01) 12 381 (0.04) 13 775 (0.07) 14 2104 (0.20) 15 3712 (0.34) 16 69319 (6.44) 17 12983 (1.21) 18 23667 (2.20) 19 69068 (6.41) 20 62354 (5.79) 21 48531 (4.51) 22 72355 (6.72) 23 85427 (7.93) 24 583900 (54.23) 25 2654 (0.25) 26 5650 (0.52) 27 6467 (0.60) 28 7127 (0.66) 29 12936 (1.20) 30 5999 (0.56) 31 13 (0.00) 32 984 (0.09)
Unique added entries = 1039948
Used table 24 entries = 11343198 (67.6107%) 64 byte Cache entries used = 360735 (23087040 bytes) Average LPM Add: 110820 cycles
Average LPM Lookup: 34.5 cycles (fails = 19.3%) BULK LPM Lookup: 31.5 cycles (fails = 19.3%) LPM LookupX4: 29.5 cycles (fails = 19.3%) Average LPM Delete: 63841.6 cycles
Test OK
RTE>>acl_autotest
ACL: allocation of 25166728 bytes on socket 33 for ACL_acl_ctx failed
ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid
ACL: rte_acl_ipv4vlan_add_rules: rule #1 is invalid
ACL: rte_acl_ipv4vlan_add_rules: rule #1 is invalid
ACL: rte_acl_ipv4vlan_add_rules: rule #1 is invalid
ACL: rte_acl_ipv4vlan_add_rules: rule #1 is invalid
ACL: rte_acl_add_rules(acl_ctx): rule #1 is invalid
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 0/0
quad nodes/vectors/bytes used: 0/0/0
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 1/128
total: 6432 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 2
memory consumed: 8388615
ACL: trie 0: number of rules: 16, indexes: 1
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 22/176
quad nodes/vectors/bytes used: 30/104/832
DFA nodes/group64/bytes used: 6/19/11784
match nodes/bytes used: 6/768
total: 15760 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 64
memory consumed: 8388615
ACL: trie 0: number of rules: 6000, indexes: 4
acl context <acl_ctx>@0x3efded3b3400
socket_id=-1
alg=5
max_rules=196608
rule_size=128
num_rules=0
num_categories=0
num_tries=0
acl context <acl_ctx>@0x3efded3b3400
socket_id=-1
alg=5
max_rules=196608
rule_size=128
num_rules=0
num_categories=0
num_tries=0
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 0
memory consumed: 8388615
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 0/0
quad nodes/vectors/bytes used: 0/0/0
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 1/128
total: 6432 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 2
memory consumed: 8388615
ACL: trie 0: number of rules: 1, indexes: 1
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 0
memory consumed: 8388615
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 3/24
quad nodes/vectors/bytes used: 3/10/80
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 2/256
total: 6672 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 9
memory consumed: 8388615
ACL: trie 0: number of rules: 2, indexes: 2
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 0
memory consumed: 8388615
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 3/24
quad nodes/vectors/bytes used: 3/11/88
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 3/384
total: 6800 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 10
memory consumed: 8388615
ACL: trie 0: number of rules: 3, indexes: 2
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 0
memory consumed: 8388615
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 3/24
quad nodes/vectors/bytes used: 3/11/88
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 3/384
total: 6800 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 10
memory consumed: 8388615
ACL: trie 0: number of rules: 4, indexes: 2
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 0
memory consumed: 8388615
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 3/24
quad nodes/vectors/bytes used: 3/11/88
DFA nodes/group64/bytes used: 1/4/4104
match nodes/bytes used: 3/384
total: 6800 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 10
memory consumed: 8388615
ACL: trie 0: number of rules: 5, indexes: 2
running test_convert_rules(acl_ipv4vlan_tuple)
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 9136/73088
quad nodes/vectors/bytes used: 13258/55366/442928
DFA nodes/group64/bytes used: 2242/4493/2302472
match nodes/bytes used: 25011/3201408
total: 6022096 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 16384
nodes created: 49647
memory consumed: 100663380
ACL: trie 0: number of rules: 22, indexes: 5
ACL: trie 1: number of rules: 5, indexes: 5
running test_convert_rules(acl_ipv4vlan_tuple, RTE_ACL_FIELD_TYPE_BITMASK type for IPv4)
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 974/7792
quad nodes/vectors/bytes used: 816/3211/25688
DFA nodes/group64/bytes used: 137/289/150024
match nodes/bytes used: 1181/151168
total: 336880 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 3108
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 9136/73088
quad nodes/vectors/bytes used: 13258/55366/442928
DFA nodes/group64/bytes used: 2242/4493/2302472
match nodes/bytes used: 25011/3201408
total: 6022096 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 16384
nodes created: 49647
memory consumed: 100663380
ACL: trie 0: number of rules: 22, indexes: 5
ACL: trie 1: number of rules: 5, indexes: 5
running test_convert_rules(acl_ipv4vlan_tuple, RTE_ACL_FIELD_TYPE_RANGE type for IPv4)
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 997/7976
quad nodes/vectors/bytes used: 1052/4198/33584
DFA nodes/group64/bytes used: 195/405/209416
match nodes/bytes used: 1917/245376
total: 498560 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 4161
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 12, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 9400/75200
quad nodes/vectors/bytes used: 13549/56210/449680
DFA nodes/group64/bytes used: 2603/5215/2672136
match nodes/bytes used: 26504/3392512
total: 6591728 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 16384
nodes created: 52056
memory consumed: 100663380
ACL: trie 0: number of rules: 22, indexes: 5
ACL: trie 1: number of rules: 5, indexes: 5
running test_convert_rules(acl_ipv4vlan_tuple: swap VLAN and PORTs order)
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 446/3568
quad nodes/vectors/bytes used: 600/1854/14832
DFA nodes/group64/bytes used: 530/924/475144
match nodes/bytes used: 544/69632
total: 565376 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 2120
memory consumed: 8388615
ACL: trie 0: number of rules: 15, indexes: 4
ACL: trie 1: number of rules: 8, indexes: 5
ACL: trie 2: number of rules: 4, indexes: 2
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 1071/8568
quad nodes/vectors/bytes used: 2328/7050/56400
DFA nodes/group64/bytes used: 3526/6266/3210248
match nodes/bytes used: 5235/670080
total: 3947504 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 16384
nodes created: 12160
memory consumed: 58720305
ACL: trie 0: number of rules: 23, indexes: 5
ACL: trie 1: number of rules: 4, indexes: 2
running test_convert_rules(acl_ipv4vlan_tuple: swap SRC and DST IPv4 order)
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 1040/8320
quad nodes/vectors/bytes used: 1319/5494/43952
DFA nodes/group64/bytes used: 162/331/171528
match nodes/bytes used: 2270/290560
total: 516560 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 2048
nodes created: 4791
memory consumed: 16777230
ACL: trie 0: number of rules: 17, indexes: 4
ACL: trie 1: number of rules: 10, indexes: 5
ACL: Gen phase for ACL "acl_ctx":
runtime memory footprint on socket -1:
single nodes/bytes used: 8822/70576
quad nodes/vectors/bytes used: 12788/53374/426992
DFA nodes/group64/bytes used: 2175/4359/2233864
match nodes/bytes used: 24100/3084800
total: 5818432 bytes
max limit: 18446744073709551615 bytes
ACL: Build phase for ACL "acl_ctx":
node limit for tree split: 16384
nodes created: 47885
memory consumed: 100663380
ACL: trie 0: number of rules: 22, indexes: 5
ACL: trie 1: number of rules: 5, indexes: 5
Test OK
RTE>>
Thanks,
Gowrishankar
Quoted 62 lines
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To: [email protected]
Cc: Chao Zhu <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep <[email protected]>; gowrishankar <[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64leFrom: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (
ip_pipelineand l3fwd).Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.v2 changes:
- enabling libs in config included as part of lib changes itself.gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm onppc_64
acl: add altivec intrinsics for dpdk acl onppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache alignrte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support forem_hash_keyapp/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100644
lib/librte_acl/acl_run_altivec.ccreate mode 100644lib/librte_acl/acl_run_altivec.hcreate mode 100644lib/librte_eal/common/include/arch/ppc_64/rte_vect.h
create mode 100644lib/librte_lpm/rte_lpm_altivec.h--
1.9.1
Gowrishankar,
When I tried the patches, I got some compilation error:
In file included from /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], ^/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],
Can you help to take a look?
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To: [email protected]
Cc: Chao Zhu <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep <[email protected]>; gowrishankar <[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le
From: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (ip_pipeline and l3fwd).
Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.
v2 changes:
- enabling libs in config included as part of lib changes itself.
gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm on ppc_64
acl: add altivec intrinsics for dpdk acl on ppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache align rte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support for em_hash_key
app/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100644 lib/librte_acl/acl_run_altivec.c create mode 100644 lib/librte_acl/acl_run_altivec.h create mode 100644 lib/librte_eal/common/include/arch/ppc_64/rte_vect.h create mode 100644 lib/librte_lpm/rte_lpm_altivec.h
--
1.9.1
Hi Chao,
I did not face this error. Even I verified today with tip of master 6596554... . However I had patch conflict for examples/l3fwd/l3fwd_em.c which is fixed now and v3 patch set sent recently. Could you please check.
Thanks,
Gowrishankar
Quoted 83 lines · Chao Zhu
Gowrishankar,
When I tried the patches, I got some compilation error:
In file included from
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1], ^/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1],Can you help to take a look?
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To: [email protected]
Cc: Chao Zhu <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep <[email protected]>; gowrishankar <[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64leFrom: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (
ip_pipelineand l3fwd).Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.v2 changes:
- enabling libs in config included as part of lib changes itself.gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm onppc_64
acl: add altivec intrinsics for dpdk acl onppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache alignrte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support forem_hash_keyapp/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode 100644
lib/librte_acl/acl_run_altivec.ccreate mode 100644lib/librte_acl/acl_run_altivec.hcreate mode 100644lib/librte_eal/common/include/arch/ppc_64/rte_vect.h
create mode 100644lib/librte_lpm/rte_lpm_altivec.h--
1.9.1
Gowrishankar,
I still get this error with the v3 patches. My OS is Ubuntu 16.04 LTS ppc64le. GCC version: Ubuntu/IBM 5.3.1-14ubuntu2
Can you help to check again?
In file included from /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], ^/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], ^
-----Original Message-----
From: gowrishankar [mailto:[email protected]]
Sent: 2016年7月16日 15:59
To: Chao Zhu <[email protected]>; [email protected]
Cc: 'Bruce Richardson' <[email protected]>; 'Konstantin Ananyev' <[email protected]>; 'Thomas Monjalon' <[email protected]>; 'Cristian Dumitrescu' <[email protected]>; 'Pradeep' <[email protected]>
Subject: Re: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le
Hi Chao,
I did not face this error. Even I verified today with tip of master 6596554... .
However I had patch conflict for examples/l3fwd/l3fwd_em.c which is fixed now and v3 patch set sent recently. Could you please check.
Thanks,
Gowrishankar
Quoted 84 lines · Chao Zhu
Gowrishankar,
When I tried the patches, I got some compilation error:
In file included from
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1], ^/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1],Can you help to take a look?
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To: [email protected]
Cc: Chao Zhu <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep <[email protected]>; gowrishankar <[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64leFrom: gowrishankar <[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (
ip_pipelineand l3fwd).Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.v2 changes:
- enabling libs in config included as part of lib changes itself.gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm onppc_64
acl: add altivec intrinsics for dpdk acl onppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache alignrte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support forem_hash_keyapp/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode100644
lib/librte_acl/acl_run_altivec.ccreate mode 100644lib/librte_acl/acl_run_altivec.hcreate mode 100644lib/librte_eal/common/include/arch/ppc_64/rte_vect.h
create mode 100644lib/librte_lpm/rte_lpm_altivec.h--
1.9.1
Hi Chao,
I just tried building dpdk master with these patches in ubuntu 16.04 le guest and I could able to.
test@ubuntu:~/DPDK$ make install T=ppc_64-power8-linuxapp-gcc -j16 .... ..... INSTALL-MAP test.map INSTALL-APP test Build complete [ppc_64-power8-linuxapp-gcc] Installation cannot run with T defined and DESTDIR undefined test@ubuntu:~/DPDK$ uname -a Linux ubuntu 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:30:22 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux
test@ubuntu:~/DPDK$ gcc --version gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609
May be you need to check gcc again.
Thanks,
Gowrishankar
Quoted 129 lines · Chao Zhu
Gowrishankar,
I still get this error with the v3 patches. My OS is Ubuntu 16.04 LTS ppc64le. GCC version: Ubuntu/IBM 5.3.1-14ubuntu2
Can you help to check again?In file included from
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1], ^/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
*indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t*)&v)[1], ^-----Original Message-----
From: gowrishankar [mailto:[email protected]]
Sent: 2016年7月16日 15:59
To: Chao Zhu<[email protected]>;[email protected]
Cc: 'Bruce Richardson'<[email protected]>; 'Konstantin Ananyev' <[email protected]>; 'Thomas Monjalon' <[email protected]>; 'Cristian Dumitrescu' <[email protected]>; 'Pradeep'<[email protected]>
Subject: Re: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64leHi Chao,
I did not face this error. Even I verified today with tip of master 6596554... .
However I had patch conflict forexamples/l3fwd/l3fwd_em.cwhich is fixed now and v3 patch set sent recently. Could you please check.Thanks,
GowrishankarQuoted 84 lines · Chao Zhu
Gowrishankar,
When I tried the patches, I got some compilation error:
In file included from
/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0:/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function 'transition4':/root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error:
dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]*indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], ^ /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] *indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1],Can you help to take a look?
-----Original Message-----
From: Gowrishankar [mailto:[email protected]]
Sent: 2016年7月10日 15:51
To:[email protected]
Cc: Chao Zhu<[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Thomas Monjalon <[email protected]>; Cristian Dumitrescu <[email protected]>; Pradeep<[email protected]>; gowrishankar<[email protected]>
Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64leFrom: gowrishankar<[email protected]>
This patchset enables LPM, ACL and other few missing libs in ppc64le and also address few patches in related examples (
ip_pipelineand l3fwd).Test report:
LPM and ACL unit tests verified as in patch set v1. Same results as before observed.v2 changes:
- enabling libs in config included as part of lib changes itself.gowrishankar (6):
lpm: add altivec intrinsics for dpdk lpm onppc_64
acl: add altivec intrinsics for dpdk acl onppc_64
ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
table: cache alignrte_bucket_4_8
sched: enable sched library for ppc64le
l3fwd: add altivec support forem_hash_keyapp/test-acl/main.c | 4 + app/test/test_xmmt_ops.h | 16 + config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - examples/ip_pipeline/cpu_core_map.c | 12 +- examples/ip_pipeline/init.c | 4 + examples/l3fwd/l3fwd_em.c | 8 + lib/librte_acl/Makefile | 2 + lib/librte_acl/acl.h | 4 + lib/librte_acl/acl_run.h | 2 + lib/librte_acl/acl_run_altivec.c | 47 +++ lib/librte_acl/acl_run_altivec.h | 328 +++++++++++++++++++++ lib/librte_acl/rte_acl.c | 13 + lib/librte_acl/rte_acl.h | 1 + .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ lib/librte_lpm/Makefile | 2 + lib/librte_lpm/rte_lpm.h | 2 + lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ lib/librte_table/rte_table_hash_key8.c | 2 +- 18 files changed, 649 insertions(+), 19 deletions(-) create mode100644
lib/librte_acl/acl_run_altivec.ccreate mode 100644lib/librte_acl/acl_run_altivec.hcreate mode 100644lib/librte_eal/common/include/arch/ppc_64/rte_vect.h
create mode 100644lib/librte_lpm/rte_lpm_altivec.h--
1.9.1