Skip to contentSkip to conversation

Patch "cfg80211: remove get/set antenna and tx power warnings" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jul 11, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cfg80211: remove get/set antenna and tx power warnings

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cfg80211-remove-get-set-antenna-and-tx-power-warnings.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6cbf6236d54c24b9a29e6892549c25b6902b44ce Mon Sep 17 00:00:00 2001

From: Johannes Berg <[email protected]>
Date: Thu, 9 Jun 2016 09:40:55 +0200
Subject: cfg80211: remove get/set antenna and tx power warnings

From: Johannes Berg <[email protected]>

commit 6cbf6236d54c24b9a29e6892549c25b6902b44ce upstream.

Since set_tx_power and set_antenna are frequently implemented without the matching get_tx_power/get_antenna, we shouldn't have added warnings for those. Remove them.

The remaining ones are correct and need to be implemented symmetrically for correct operation.

Fixes de3bb771f471 ("cfg80211: add more warnings for inconsistent ops")
---
 net/wireless/core.c |    2 --
 1 file changed, 2 deletions(-)
net/wireless/core.c +0 -2
@@ -360,8 +360,6 @@ struct wiphy *wiphy_new_nm(const struct
 	WARN_ON(ops->remain_on_channel && !ops->cancel_remain_on_channel);
 	WARN_ON(ops->tdls_channel_switch && !ops->tdls_cancel_channel_switch);
 	WARN_ON(ops->add_tx_ts && !ops->del_tx_ts);
-	WARN_ON(ops->set_tx_power && !ops->get_tx_power);
-	WARN_ON(ops->set_antenna && !ops->get_antenna);
 
 	alloc_size = sizeof(*rdev) + sizeof_priv;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/mac80211_hwsim-add-missing-check-for-hwsim_attr_signal.patch queue-4.6/cfg80211-remove-get-set-antenna-and-tx-power-warnings.patch queue-4.6/mac80211-fix-fast_tx-header-alignment.patch queue-4.6/mac80211-mesh-flush-mesh-paths-unconditionally.patch