Memory leak of NOP-IN tasks in iscsi_tcp
Hi,
We've found a memory leak in tgtd recently (leaking a struct iscsi_task each nop_interval seconds). The problem seems to have been there since the nop_interval was introduced.
My attempt at fixing it was submitted as a pull request, available at https://github.com/fujita/tgt/pull/21
The approach taken might be far from the best one possible, but the problem is severe enough to justify doing something to solve it, even if imperfect.
Please consider accepting the pull request, or propose an alternative approach that has some chance of being accepted.
Signature · 1 line
Best Regards, Anton Kovalenko
Quoted 6 lines · On Mon, 11 Jul 2016 23:23:35 +0000 Anton Kovalenko…
We've found a memory leak in tgtd recently (leaking a struct
iscsi_taskeachnop_intervalseconds). The problem seems to have been there since thenop_intervalwas introduced.My attempt at fixing it was submitted as a pull request, available at https://github.com/fujita/tgt/pull/21
The approach taken might be far from the best one possible, but the problem is severe enough to justify doing something to solve it, even if imperfect.
Looks good. Thanks a lot!