Skip to contentSkip to conversation

Patch "ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jul 12, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-dts-sun6i-primo81-drop-constraints-on-dc1sw-regulator.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cb84f6c0a25eb76b1f838eb63e212705c0c06b5f Mon Sep 17 00:00:00 2001

From: Chen-Yu Tsai <[email protected]>
Date: Wed, 11 May 2016 13:23:13 +0800
Subject: ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator

From: Chen-Yu Tsai <[email protected]>

commit cb84f6c0a25eb76b1f838eb63e212705c0c06b5f upstream.

This is the same issue fixed in commit dcf5341f0150 ("ARM: dts:
sun8i-q8-common: Do not set constraints on dc1sw regulator"). Commit message copied:

dc1sw is an on/off only regulator and as such it cannot have constraints.

This is a limitation of the kernel regulator implementation which resolves supplies on the first regulator_get(), which is done after applying constraints, and applying the constrains will fail because it calls _regulator_get_voltage() and _regulator_do_set_voltage() both of which will fail on a switch regulator when there is no supply (yet).

This causes registering of all axp22x regulators to fail with the following errors:

[    1.395249] vcc-lcd: failed to get the current voltage(-22)
[    1.405131] axp20x-regulator axp20x-regulator: Failed to register dc1sw
[    1.412436] axp20x-regulator: probe of axp20x-regulator failed with error -22

This commit removes the constrains on dc1sw / vcc-lcd fixing this problem. Note that dcdc1 itself is contrained to the exact same values, so this does not change anything.

---
 arch/arm/boot/dts/sun6i-a31s-primo81.dts |    2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/sun6i-a31s-primo81.dts +0 -2
@@ -176,8 +176,6 @@
 };
 
 &reg_dc1sw {
-	regulator-min-microvolt = <3000000>;
-	regulator-max-microvolt = <3000000>;
 	regulator-name = "vcc-lcd";
 };
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/arm-dts-sun6i-primo81-drop-constraints-on-dc1sw-regulator.patch queue-4.6/arm-dts-sun6i-yones-toptech-bs1078-v2-drop-constraints-on-dc1sw-regulator.patch