tests: add -a option cases

PATCH In review Tim Wang 2 participants 5 messages Jul 13, 2016 – Jul 18, 2016 4 messages not in the archive

lore

Share & tools

lore

Tim Wang

author

2016-07-13 11:35 UTC #0 lore raw

PATCH 1/1 tests: add -a option cases

Signed-off-by Tim Wang <timwang-XOWFcpiLszpWk0Htik3J/[email protected]>

---
 tests/run_tests.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

tests/run_tests.sh +4 -3

index 7eb9b3d..6aed6d6 100755
@@ -579,9 +579,10 @@ fdtput_tests () {
     dts=label01.dts
     dtb=$dts.fdtput.test.dtb
     text=lorem.txt
+    align=64
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"

@@ -600,7 +601,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod

@@ -628,7 +629,7 @@ fdtput_tests () {
     run_wrap_test $DTPUT $dtb -cp /chosen/son
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 /chosen/node3

Signature · 1 line

1.9.1

A message that is not in the archive (sent off-list or not yet received): 1468409701-3310-1-git-send-email-timwang-XOWFcpiLszpWk0Htik3J/[email protected]

David Gibson

2016-07-14 09:27 UTC #2 lore raw

Quoted 1 line · Tim Wang

Signed-off-by Tim Wang <timwang-XOWFcpiLszpWk0Htik3J/[email protected]>

This is a good start. However it needs some more.

First, you should have some tests which actually check that the generated blobs have the correct alignment.

Second, you should check more than just one alignment.

Quoted 38 lines

---
 tests/run_tests.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

tests/run_tests.sh +4 -3

index 7eb9b3d..6aed6d6 100755
@@ -579,9 +579,10 @@ fdtput_tests () {
     dts=label01.dts
     dtb=$dts.fdtput.test.dtb
     text=lorem.txt
+    align=64
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"

@@ -600,7 +601,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod

@@ -628,7 +629,7 @@ fdtput_tests () {
     run_wrap_test $DTPUT $dtb -cp /chosen/son
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 /chosen/node3

Signature · 4 lines

David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

Wang Tim（王艇艇）

author

2016-07-14 10:02 UTC #4 lore raw

Hi David,
Thanks for your review!

I'll add the "actually check" code about the new dtb file with alignment option. And add more case which combine with other options.

BTW, do I need combine the test patch and "-a option" into one patch?

Best Regards
Tim Wang(王艇艇)

-----Original Message-----
From: David Gibson [mailto:[email protected]]
Sent: Thursday, July 14, 2016 5:27 PM
To: Wang Tim（王艇艇）
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] tests: add -a option cases

Quoted 1 line · Tim Wang

Signed-off-by Tim Wang <[email protected]>

This is a good start. However it needs some more.

First, you should have some tests which actually check that the generated blobs have the correct alignment.

Second, you should check more than just one alignment.

Quoted 39 lines

---
 tests/run_tests.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

tests/run_tests.sh index renamed from tests/run_tests.sh +0 -0

7eb9b3d..6aed6d6 100755

tests/run_tests.sh +3 -2

@@ -579,9 +579,10 @@ fdtput_tests () {
     dts=label01.dts
     dtb=$dts.fdtput.test.dtb
     text=lorem.txt
+    align=64
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"

@@ -600,7 +601,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod @@ -628,7 +629,7

@@ fdtput_tests () {
run_wrap_test $DTPUT $dtb -cp /chosen/son

# Start again with a fresh dtb

tests/run_tests.sh +1 -1

-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2

/chosen/node3

Signature · 4 lines

David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): 0524d71d69d240c39c0337ea08a55d5e-w/[email protected]

David Gibson

2016-07-15 02:13 UTC #6 lore raw

Quoted 8 lines · Wang Tim（王艇艇）

Hi David,
Thanks for your review!
I'll add the "actually check" code about the new dtb file with alignment option. And add more case which combine with other options.
BTW, do I need combine the test patch and "-a option" into one patch?

Either way is ok. Since they're both fairly small, it's probably simpler to combine them.

Quoted 61 lines

Best Regards
Tim Wang(王艇艇)
-----Original Message-----
From: David Gibson [mailto:[email protected]]
Sent: Thursday, July 14, 2016 5:27 PM
To: Wang Tim（王艇艇）
Cc: [email protected]; wtt_usst-9Onoh4P/[email protected]
Subject: Re: [PATCH] tests: add -a option cases
Quoted 1 line · Tim Wang
Signed-off-by Tim Wang <timwang-XOWFcpiLszpWk0Htik3J/[email protected]>
This is a good start. However it needs some more.
First, you should have some tests which actually check that the generated blobs have the correct alignment.
Second, you should check more than just one alignment.
Quoted 39 lines
---
 tests/run_tests.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
tests/run_tests.sh index renamed from tests/run_tests.sh +0 -0
7eb9b3d..6aed6d6 100755
tests/run_tests.sh +3 -2
@@ -579,9 +579,10 @@ fdtput_tests () {
     dts=label01.dts
     dtb=$dts.fdtput.test.dtb
     text=lorem.txt
+    align=64
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"
@@ -600,7 +601,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod @@ -628,7 +629,7 
@@ fdtput_tests () {
run_wrap_test $DTPUT $dtb -cp /chosen/son
# Start again with a fresh dtb
tests/run_tests.sh +1 -1
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 
/chosen/node3

Signature · 4 lines

David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

Wang Tim（王艇艇）

author

2016-07-18 08:21 UTC #8 lore raw

Hi David,
I've sent V6 patch which combine the test cases and -a option related codes.
Please help to review, thanks!

Best Regards
Tim Wang(王艇艇)

-----Original Message-----
From: David Gibson [mailto:[email protected]]
Sent: Friday, July 15, 2016 10:13 AM
To: Wang Tim（王艇艇）
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] tests: add -a option cases

Quoted 7 lines · Wang Tim（王艇艇）

Hi David,
Thanks for your review!
I'll add the "actually check" code about the new dtb file with alignment option. And add more case which combine with other options.
BTW, do I need combine the test patch and "-a option" into one patch?

Either way is ok. Since they're both fairly small, it's probably simpler to combine them.

Quoted 64 lines

Best Regards
Tim Wang(王艇艇)
-----Original Message-----
From: David Gibson [mailto:[email protected]]
Sent: Thursday, July 14, 2016 5:27 PM
To: Wang Tim（王艇艇）
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] tests: add -a option cases
Quoted 1 line · Tim Wang
Signed-off-by Tim Wang <[email protected]>
This is a good start. However it needs some more.
First, you should have some tests which actually check that the generated blobs have the correct alignment.
Second, you should check more than just one alignment.
Quoted 42 lines
---
 tests/run_tests.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
tests/run_tests.sh index renamed from tests/run_tests.sh +0 -0
7eb9b3d..6aed6d6 100755
tests/run_tests.sh +8 -3
@@ -579,9 +579,10 @@ fdtput_tests () {
     dts=label01.dts
     dtb=$dts.fdtput.test.dtb
     text=lorem.txt
+    align=64
 
     # Allow just enough space for $text
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb 
+ $dts
 
     # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value>
     run_fdtput_test "a_model" $dtb / model -ts "a_model"
@@ -600,7 +601,7 @@ fdtput_tests () {
     run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)"
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb 
+ $dts
 
     # Node creation
     run_wrap_error_test $DTPUT $dtb -c /baldrick sod @@ -628,7 
+629,7 @@ fdtput_tests () {
     run_wrap_test $DTPUT $dtb -cp /chosen/son
 
     # Start again with a fresh dtb
-    run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts
+    run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb 
+ $dts
 
     # Node delete
     run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2
/chosen/node3

Signature · 4 lines

David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson