Patch "drm: add missing drm_mode_set_crtcinfo call" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled

drm: add missing drm_mode_set_crtcinfo call

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-add-missing-drm_mode_set_crtcinfo-call.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Tomi Valkeinen <[email protected]>
Date: Tue, 31 May 2016 15:03:15 +0300
Subject: drm: add missing drm_mode_set_crtcinfo call

From: Tomi Valkeinen <[email protected]>

commit b201e743f42d143f4bcdcb14587caf7cb1d99229 upstream.

When setting mode via MODE_ID property,
drm_atomic_set_mode_prop_for_crtc() does not call
drm_mode_set_crtcinfo() which possibly causes:

"[drm:drm_calc_timestamping_constants [drm]] *ERROR* crtc 32: Can't calculate constants, dotclock = 0!"

Whether the error is seen depends on the previous data in state->mode, as state->mode is not cleared when setting new mode.

This patch adds drm_mode_set_crtcinfo() call to drm_mode_convert_umode(), which is called in both legacy and atomic paths. This should be fine as there's no reason to call drm_mode_convert_umode() without also setting the crtc related fields.

drm_mode_set_crtcinfo() is removed from the legacy drm_mode_setcrtc() as that is no longer needed.

---
 drivers/gpu/drm/drm_crtc.c  |    2 --
 drivers/gpu/drm/drm_modes.c |    2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

@@ -2682,8 +2682,6 @@ int drm_mode_setcrtc(struct drm_device *
 			goto out;
 		}
 
-		drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
-
 		/*
 		 * Check whether the primary plane supports the fb pixel format.
 		 * Drivers not implementing the universal planes API use a

@@ -1487,6 +1487,8 @@ int drm_mode_convert_umode(struct drm_di
 	if (out->status != MODE_OK)
 		goto out;
 
+	drm_mode_set_crtcinfo(out, CRTC_INTERLACE_HALVE_V);
+
 	ret = 0;
 
 out:

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/drm-make-drm_atomic_set_mode_prop_for_crtc-more-reliable.patch queue-4.4/drm-add-missing-drm_mode_set_crtcinfo-call.patch