Patch "ARM: mvebu: fix HW I/O coherency related deadlocks" has been added to the 4.4-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
ARM: mvebu: fix HW I/O coherency related deadlocks
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm-mvebu-fix-hw-i-o-coherency-related-deadlocks.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
c5379ba8fccd99d5f99632c789f0393d84a57805Mon Sep 17 00:00:00 2001
From: Thomas Petazzoni <[email protected]>
Date: Thu, 16 Jun 2016 15:42:25 +0200
Subject: ARM: mvebu: fix HW I/O coherency related deadlocks
From: Thomas Petazzoni <[email protected]>
commit c5379ba8fccd99d5f99632c789f0393d84a57805 upstream.
Until now, our understanding for HW I/O coherency to work on the Cortex-A9 based Marvell SoC was that only the PCIe regions should be mapped strongly-ordered. However, we were still encountering some deadlocks, especially when testing the CESA crypto engine. After checking with the HW designers, it was concluded that all the MMIO registers should be mapped as strongly ordered for the HW I/O coherency mechanism to work properly.
This fixes some easy to reproduce deadlocks with the CESA crypto engine driver (dmcrypt on a sufficiently large disk partition).
--- arch/arm/mach-mvebu/coherency.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-)
arch/arm/mach-mvebu/coherency.c +8 -14
@@ -162,22 +162,16 @@ exit: }/* -* This ioremap hook is used on Armada 375/38x to ensure that PCIe -* memory areas are mapped as MT_UNCACHED instead of MT_DEVICE. This -* is needed as a workaround for a deadlock issue between the PCIe -* interface and the cache controller. +* This ioremap hook is used on Armada 375/38x to ensure that all MMIO +* areas are mapped as MT_UNCACHED instead of MT_DEVICE. This is +* needed for the HW I/O coherency mechanism to work properly without +* deadlock. */ static void __iomem * -armada_pcie_wa_ioremap_caller (phys_addr_t phys_addr,size_t size, -unsigned int mtype,void *caller) +armada_wa_ioremap_caller (phys_addr_t phys_addr,size_t size, +unsigned int mtype,void *caller) { -struct resource pcie_mem; - -mvebu_mbus_get_pcie_mem_aperture (&pcie_mem); - -if (pcie_mem.start <= phys_addr && (phys_addr + size) <= pcie_mem.end) - mtype =MT_UNCACHED ; - + mtype =MT_UNCACHED ;return __arm_ioremap_caller (phys_addr, size, mtype, caller); }
@@ -186,7 +180,7 @@ static void __init armada_375_380_coherestruct device_node *cache_dn; coherency_cpu_base =of_iomap (np,0 ); - arch_ioremap_caller = armada_pcie_wa_ioremap_caller; + arch_ioremap_caller = armada_wa_ioremap_caller;/* * We should switch the PL310 to I/O coherency mode only if
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/arm-dts-armada-38x-fix-mbus_id-for-crypto-sram-on-armada-385-linksys.patch queue-4.4/arm-mvebu-fix-hw-i-o-coherency-related-deadlocks.patch