Skip to contentSkip to conversation

Patch "ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 62db7152c924e4c060e42b34a69cd39658e8a0dc Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Wed, 29 Jun 2016 15:23:08 +0200
Subject: ALSA: au88x0: Fix calculation in vortex_wtdma_bufshift()

From: Takashi Iwai <[email protected]>

commit 62db7152c924e4c060e42b34a69cd39658e8a0dc upstream.

vortex_wtdma_bufshift() function does calculate the page index wrongly, first masking then shift, which always results in zero. The proper computation is to first shift, then mask.

---
 sound/pci/au88x0/au88x0_core.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
sound/pci/au88x0/au88x0_core.c +2 -3
@@ -1444,9 +1444,8 @@ static int vortex_wtdma_bufshift(vortex_
 	int page, p, pp, delta, i;
 
 	page =
-	    (hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2)) &
-	     WT_SUBBUF_MASK)
-	    >> WT_SUBBUF_SHIFT;
+	    (hwread(vortex->mmio, VORTEX_WTDMA_STAT + (wtdma << 2))
+	     >> WT_SUBBUF_SHIFT) & WT_SUBBUF_MASK;
 	if (dma->nr_periods >= 4)
 		delta = (page - dma->period_real) & 3;
 	else {

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/alsa-hda-fix-the-headset-mic-jack-detection-on-dell-machine.patch queue-4.6/alsa-ctl-stop-notification-after-disconnection.patch queue-4.6/alsa-dummy-fix-a-use-after-free-at-closing.patch queue-4.6/alsa-timer-fix-negative-queue-usage-by-racy-accesses.patch queue-4.6/alsa-hda-fix-use-after-free-after-module-unload.patch queue-4.6/alsa-hda-realtek-add-new-pin-definition-in-alc225-pin-quirk-table.patch queue-4.6/alsa-hdac_regmap-fix-the-register-access-for-runtime-pm.patch queue-4.6/alsa-hda-add-pci-id-for-kabylake-h.patch queue-4.6/alsa-usb-audio-fix-quirks-code-is-not-called.patch queue-4.6/alsa-pcm-free-chmap-at-pcm-free-callback-too.patch queue-4.6/alsa-au88x0-fix-calculation-in-vortex_wtdma_bufshift.patch queue-4.6/alsa-hda-realtek-add-lenovo-l460-to-docking-unit-fixup.patch queue-4.6/alsa-echoaudio-fix-memory-allocation.patch queue-4.6/alsa-hda-realtek-add-two-more-thinkpad-ids-5050-5053-for-tpt460-fixup.patch queue-4.6/alsa-hda-fix-read-before-array-start.patch queue-4.6/alsa-hda-add-amd-stoney-pci-id-with-proper-driver-caps.patch