Patch "ALSA: echoaudio: Fix memory allocation" has been added to the 4.6-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: echoaudio: Fix memory allocation
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-echoaudio-fix-memory-allocation.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
9c6795a9b3cbb56a9fbfaf43909c5c22999ba317Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <[email protected]>
Date: Mon, 27 Jun 2016 21:06:51 +0200
Subject: ALSA: echoaudio: Fix memory allocation
From: Christophe JAILLET <[email protected]>
commit 9c6795a9b3cbb56a9fbfaf43909c5c22999ba317 upstream.
'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes. We then copy 'sizeof(struct comm_page)' bytes in it.
On my system, smatch complains because one is 2960 and the other is 3072.
This would result in memory corruption or a oops.
--- sound/pci/echoaudio/echoaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/echoaudio/echoaudio.c +2 -2
@@ -2200,11 +2200,11 @@ static int snd_echo_resume(struct deviceu32 pipe_alloc_mask;int err; - commpage_bak =kmalloc (sizeof (struct echoaudio ),GFP_KERNEL ); + commpage_bak =kmalloc (sizeof (*commpage),GFP_KERNEL );if (commpage_bak ==NULL )return -ENOMEM ; commpage = chip->comm_page; -memcpy (commpage_bak, commpage,sizeof (struct comm_page )); +memcpy (commpage_bak, commpage,sizeof (*commpage)); err =init_hw (chip, chip->pci->device, chip->pci->subsystem_device);if (err <0 ) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.6/alsa-echoaudio-fix-memory-allocation.patch