Skip to contentSkip to conversation

Patch "iio:ad7266: Fix broken regulator error handling" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Jul 25, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio:ad7266: Fix broken regulator error handling

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-ad7266-fix-broken-regulator-error-handling.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6b7f4e25f3309f106a5c7ff42c8231494cf285d3 Mon Sep 17 00:00:00 2001

From: Mark Brown <[email protected]>
Date: Mon, 20 Jun 2016 13:53:32 +0100
Subject: iio:ad7266: Fix broken regulator error handling

From: Mark Brown <[email protected]>

commit 6b7f4e25f3309f106a5c7ff42c8231494cf285d3 upstream.

All regulator_get() variants return either a pointer to a regulator or an ERR_PTR() so testing for NULL makes no sense and may lead to bugs if we use NULL as a valid regulator. Fix this by using IS_ERR() as expected.

---
 drivers/iio/adc/ad7266.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ad7266.c +1 -1
@@ -397,7 +397,7 @@ static int ad7266_probe(struct spi_devic
 	st = iio_priv(indio_dev);
 
 	st->reg = devm_regulator_get(&spi->dev, "vref");
-	if (!IS_ERR_OR_NULL(st->reg)) {
+	if (!IS_ERR(st->reg)) {
 		ret = regulator_enable(st->reg);
 		if (ret)
 			return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/drm-fsl-dcu-use-flat-regmap-cache.patch queue-4.6/iio-ad7266-fix-probe-deferral-for-vref.patch queue-4.6/iio-ad7266-fix-broken-regulator-error-handling.patch queue-4.6/iio-ad7266-fix-support-for-optional-regulators.patch queue-4.6/regulator-qcom_smd-add-regulator-ops-for-pm8941-lnldo.patch queue-4.6/regulator-qcom_smd-add-list_voltage-callback.patch