package/openswan: not available on musl
PATCH 1/1 package/openswan: not available on musl
After fixing the usual sys/cdefs.h and _P stuff the build still fails because Openswan makes use of GLOB_ functions
/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: error: ?GLOB_BRACE? undeclared (first use in this function)
globresult = glob(try, GLOB_BRACE, NULL, &globbuf);
^
/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: note: each undeclared identifier is reported only once for each function it appears in
/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:207:41: error: ?GLOB_NOMAGIC? undeclared (first use in this function)
globresult = glob(try, GLOB_BRACE|GLOB_NOMAGIC, NULL, &globbuf);https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/parser.l#L200
https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/parser.l#L207
[...]
^
which musl does not support:
http://www.openwall.com/lists/musl/2013/09/16/1
Fixes
http://autobuild.buildroot.net/results/70d/70da34c1528b51e92e9e60788f83733d70b33353/
--- package/openswan/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/openswan/Config.in +4 -2
@@ -2,6 +2,7 @@ config BR2_PACKAGE_OPENSWAN bool "openswan" depends on BR2_USE_MMU # iproute2 depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # iproute2 + depends on !BR2_TOOLCHAIN_USES_MUSL # GLOB_BRACE select BR2_PACKAGE_GMP select BR2_PACKAGE_IPROUTE2 help
@@ -9,6 +10,7 @@ config BR2_PACKAGE_OPENSWAN http://www.openswan.org -comment "openswan needs a toolchain w/ headers >= 3.0" +comment "openswan needs a uClibc or glibc toolchain toolchain w/ headers >= 3.0" depends on BR2_USE_MMU - depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 || \ + BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
2.8.1
PATCH 1/1 package/openswan: not available on musl
Quoted 17 lines · Bernd Kuhls
After fixing the usual
sys/cdefs.hand _P stuff the build still fails because Openswan makes use ofGLOB_functions
/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: error: ?GLOB_BRACE? undeclared (first use in this function) ??????globresult =glob(try, GLOB_BRACE, NULL, &globbuf); ?????????????????????????????^/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: note: each undeclared identifier is reported only once for each function it appears in/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:207:41: error: ?GLOB_NOMAGIC? undeclared (first use in this function) ???????globresult =glob(try, GLOB_BRACE|GLOB_NOMAGIC, NULL, &globbuf);
Quoted 9 lines
https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/pa
rser.l#L200
https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/pa
rser.l#L207
[...]
?????????????????????????????????????????^
which musl does not support:
http://www.openwall.com/lists/musl/2013/09/16/1
Maybe we can add libglob [1] as a package and add it as a musl dependencies like we do it with netbsd-queue?
[1]?https://github.com/voidlinux/libglob
Best regards
J?rg Krause
PATCH 1/1 package/openswan: not available on musl
Hi J?rg,
Quoted 27 lines · J?rg Krause
Quoted 17 lines · Bernd Kuhls
After fixing the usual
sys/cdefs.hand _P stuff the build still fails because Openswan makes use ofGLOB_functions
/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: error: ?GLOB_BRACE? undeclared (first use in this function) ??????globresult =glob(try, GLOB_BRACE, NULL, &globbuf); ?????????????????????????????^/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:200:29: note: each undeclared identifier is reported only once for each function it appears in/home/bernd/buildroot/br4/output/build/openswan-2.6.48/lib/libipsecconf/parser.l:207:41: error: ?GLOB_NOMAGIC? undeclared (first use in this function) ???????globresult =glob(try, GLOB_BRACE|GLOB_NOMAGIC, NULL, &globbuf);Quoted 8 lines
https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/pa
rser.l#L200
https://github.com/xelerance/Openswan/blob/master/lib/libipsecconf/pa
rser.l#L207
[...]
?????????????????????????????????????????^
which musl does not support:
http://www.openwall.com/lists/musl/2013/09/16/1
Quoted 4 lines
Maybe we can add libglob [1] as a package and add it as a musl dependencies like we do it with netbsd-queue?
netbsd-queue is a header only package, so it adds nothing to packages that don't use it. libglob adds libglob.so that is only useful for few packages. We can do something similar to way we handle gettext by adding
select BR2_PACKAGE_LIBGLOB if BR2_TOOLCHAIN_USES_MUSL
for each such package.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 package/openswan: not available on musl
Hello,
Quoted 7 lines · Baruch Siach
netbsd-queue is a header only package, so it adds nothing to packages that don't use it. libglob adds libglob.so that is only useful for few packages. We can do something similar to way we handle gettext by adding
select
BR2_PACKAGE_LIBGLOBifBR2_TOOLCHAIN_USES_MUSLfor each such package.
Agreed.
BTW, the other day I was wondering if we shouldn't add another dummy package for musl that adds the <sys/cdefs.h> header. It's supposedly an internal glibc header but *lots* of packages use the __BEGIN_DECLS / __END_DECLS definitions, and it's really annoying to fix them all, for not a huge benefit.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 package/openswan: not available on musl
Quoted 11 lines · Thomas Petazzoni
Hello,
Quoted 7 lines · Baruch Siach
netbsd-queue is a header only package, so it adds nothing to packages that?
don't use it. libglob adds libglob.so that is only useful for few packages. We?
can do something similar to way we handle gettext by adding
Quoted 5 lines
Quoted 3 lines
? select
BR2_PACKAGE_LIBGLOBifBR2_TOOLCHAIN_USES_MUSLfor each such package.
Agreed.
Ok. I will submit a patch for adding libglob. In fellow-up patches we could add this dependency.
Quoted 7 lines
BTW, the other day I was wondering if we shouldn't add another dummy package for musl that adds the <
sys/cdefs.h> header. It's supposedly an
internal glibc header but *lots* of packages use the__BEGIN_DECLS/__END_DECLSdefinitions, and it's really annoying to fix them all, for
not a huge benefit.
Yes, this could be done too to ease building with musl.
J?rg
PATCH 1/1 package/openswan: not available on musl
Am Mon, 01 Aug 2016 20:24:18 +0200 schrieb J?rg Krause:
Quoted 1 line
Ok. I will submit a patch for adding libglob.
Hi,
as RFC already done ;) http://patchwork.ozlabs.org/patch/654378/
Regards, Bernd
PATCH 1/1 package/openswan: not available on musl
In reply to Thomas PetazzoniThomas, Bernd, Baruch, All,
On 2016-07-31 23:01 +0200, Thomas Petazzoni spake thusly:
Quoted 11 lines · Baruch Siach
Quoted 8 lines
netbsd-queue is a header only package, so it adds nothing to packages that don't use it. libglob adds libglob.so that is only useful for few packages. We can do something similar to way we handle gettext by adding
select
BR2_PACKAGE_LIBGLOBifBR2_TOOLCHAIN_USES_MUSLfor each such package.
Agreed.
In the meantime, the release is approaching, and libglob is not yet in the tree.
So I think we should just hide openswan for musl, at least until after the release.
Regards,
Yann E. MORIN.
Quoted 15 lines
BTW, the other day I was wondering if we shouldn't add another dummy package for musl that adds the <
sys/cdefs.h> header. It's supposedly an internal glibc header but *lots* of packages use the__BEGIN_DECLS/__END_DECLSdefinitions, and it's really annoying to fix them all, for not a huge benefit.Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/openswan: not available on musl
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Thomas, Bernd, Baruch, All,
On 2016-07-31 23:01 +0200, Thomas Petazzoni spake thusly:Quoted 11 lines · Baruch Siach
Quoted 8 lines
netbsd-queue is a header only package, so it adds nothing to packages that don't use it. libglob adds libglob.so that is only useful for few packages. We can do something similar to way we handle gettext by adding
select
BR2_PACKAGE_LIBGLOBifBR2_TOOLCHAIN_USES_MUSLfor each such package.
Agreed.
Quoted 7 lines
In the meantime, the release is approaching, and libglob is not yet in the tree.
So I think we should just hide openswan for musl, at least until after the release.
Acked-by "Yann E. MORIN" <[email protected]>
Agreed - Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard