Skip to contentSkip to conversation

drm/amdgpu: update golden setting of VI

PATCH In review Huang Rui 4 participants 11 messages Aug 2, 2016 – Aug 4, 2016 7 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

v2 cover drm/amdgpu: update golden setting of VI

Hi all,

This patch set are all changes of golden setting, mgcg_cgcg setting, tiling mode array and rev id of VI series of cards.

Changes from V1 -> V2:
- Polaris10 changes are in tonga and polaris11 patches. And fix it.

Thanks,
Rui

Huang Rui (3):
drm/amdgpu: update golden setting of tonga
drm/amdgpu: update golden setting of polaris11
drm/amdgpu: update golden setting of polaris10

 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1470115414-23733-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

author
#2 lore raw

PATCH v2 1/3 drm/amdgpu: update golden setting of tonga

---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +1 -0
index aff318a..fc4d998 100644
@@ -165,6 +165,7 @@ static const u32 golden_settings_tonga_a11[] =
 	mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,
 	mmPA_SC_FIFO_DEPTH_CNTL, 0x000003ff, 0x000000fc,
 	mmPA_SC_LINE_STIPPLE_STATE, 0x0000ff0f, 0x00000000,
+	mmRLC_CGCG_CGLS_CTRL, 0x00000003, 0x0000003c,
 	mmSQ_RANDOM_WAVE_PRI, 0x001fffff, 0x000006fd,
 	mmTA_CNTL_AUX, 0x000f000f, 0x000b0000,
 	mmTCC_CTRL, 0x00100000, 0xf31fff7f,
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1470115414-23733-2-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by Ken Wang
#4 lore raw

答复: [PATCH v2 1/3] drm/amdgpu: update golden setting of tonga

________________________________
发件人: Huang Rui <[email protected]>
发送时间: 2016年8月2日 13:23:32
收件人: [email protected]; Deucher, Alexander 抄送: Wang, Ken; Huan, Alvin; Huang, Ray
主题: [PATCH v2 1/3] drm/amdgpu: update golden setting of tonga

---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +1 -0
index aff318a..fc4d998 100644
@@ -165,6 +165,7 @@ static const u32 golden_settings_tonga_a11[] =
         mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,
         mmPA_SC_FIFO_DEPTH_CNTL, 0x000003ff, 0x000000fc,
         mmPA_SC_LINE_STIPPLE_STATE, 0x0000ff0f, 0x00000000,
+       mmRLC_CGCG_CGLS_CTRL, 0x00000003, 0x0000003c,
         mmSQ_RANDOM_WAVE_PRI, 0x001fffff, 0x000006fd,
         mmTA_CNTL_AUX, 0x000f000f, 0x000b0000,
         mmTCC_CTRL, 0x00100000, 0xf31fff7f,

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author
#5 lore raw

PATCH v2 2/3 drm/amdgpu: update golden setting of polaris11

In reply to a message not in the archive
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +3 -2
index fc4d998..ea025a5 100644
@@ -269,7 +269,8 @@ static const u32 tonga_mgcg_cgcg_init[] =
 
 static const u32 golden_settings_polaris11_a11[] =
 {
-	mmCB_HW_CONTROL, 0xfffdf3cf, 0x00006208,
+	mmCB_HW_CONTROL, 0x0000f3cf, 0x00007208,
+	mmCB_HW_CONTROL_2, 0x0f000000, 0x0f000000,
 	mmCB_HW_CONTROL_3, 0x000001ff, 0x00000040,
 	mmDB_DEBUG2, 0xf00fffff, 0x00000400,
 	mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,
@@ -278,7 +279,7 @@ static const u32 golden_settings_polaris11_a11[] =
 	mmPA_SC_RASTER_CONFIG_1, 0x0000003f, 0x00000000,
 	mmRLC_CGCG_CGLS_CTRL, 0x00000003, 0x0001003c,
 	mmRLC_CGCG_CGLS_CTRL_3D, 0xffffffff, 0x0001003c,
-	mmSQ_CONFIG, 0x07f80000, 0x07180000,
+	mmSQ_CONFIG, 0x07f80000, 0x01180000,
 	mmTA_CNTL_AUX, 0x000f000f, 0x000b0000,
 	mmTCC_CTRL, 0x00100000, 0xf31fff7f,
 	mmTCP_ADDR_CONFIG, 0x000003ff, 0x000000f3,
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1470115414-23733-3-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by Ken Wang
#7 lore raw

答复: [PATCH v2 2/3] drm/amdgpu: update golden setting of polaris11

________________________________
发件人: Huang Rui <[email protected]>
发送时间: 2016年8月2日 13:23:33
收件人: [email protected]; Deucher, Alexander 抄送: Wang, Ken; Huan, Alvin; Huang, Ray
主题: [PATCH v2 2/3] drm/amdgpu: update golden setting of polaris11

---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +3 -2
index fc4d998..ea025a5 100644
@@ -269,7 +269,8 @@ static const u32 tonga_mgcg_cgcg_init[] =
 
 static const u32 golden_settings_polaris11_a11[] =
 {
-       mmCB_HW_CONTROL, 0xfffdf3cf, 0x00006208,
+       mmCB_HW_CONTROL, 0x0000f3cf, 0x00007208,
+       mmCB_HW_CONTROL_2, 0x0f000000, 0x0f000000,
         mmCB_HW_CONTROL_3, 0x000001ff, 0x00000040,
         mmDB_DEBUG2, 0xf00fffff, 0x00000400,
         mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,
@@ -278,7 +279,7 @@ static const u32 golden_settings_polaris11_a11[] =
         mmPA_SC_RASTER_CONFIG_1, 0x0000003f, 0x00000000,
         mmRLC_CGCG_CGLS_CTRL, 0x00000003, 0x0001003c,
         mmRLC_CGCG_CGLS_CTRL_3D, 0xffffffff, 0x0001003c,
-       mmSQ_CONFIG, 0x07f80000, 0x07180000,
+       mmSQ_CONFIG, 0x07f80000, 0x01180000,
         mmTA_CNTL_AUX, 0x000f000f, 0x000b0000,
         mmTCC_CTRL, 0x00100000, 0xf31fff7f,
         mmTCP_ADDR_CONFIG, 0x000003ff, 0x000000f3,

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author
#8 lore raw

PATCH v2 3/3 drm/amdgpu: update golden setting of polaris10

In reply to a message not in the archive
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2 -2
index ea025a5..05c336b 100644
@@ -301,8 +301,8 @@ static const u32 polaris11_golden_common_all[] =
 static const u32 golden_settings_polaris10_a11[] =
 {
 	mmATC_MISC_CG, 0x000c0fc0, 0x000c0200,
-	mmCB_HW_CONTROL, 0xfffdf3cf, 0x00007208,
-	mmCB_HW_CONTROL_2, 0, 0x0f000000,
+	mmCB_HW_CONTROL, 0x0001f3cf, 0x00007208,
+	mmCB_HW_CONTROL_2, 0x0f000000, 0x0f000000,
 	mmCB_HW_CONTROL_3, 0x000001ff, 0x00000040,
 	mmDB_DEBUG2, 0xf00fffff, 0x00000400,
 	mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1470115414-23733-4-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by Ken Wang
#10 lore raw

答复: [PATCH v2 3/3] drm/amdgpu: update golden setting of polaris10

________________________________
发件人: Huang Rui <[email protected]>
发送时间: 2016年8月2日 13:23:34
收件人: [email protected]; Deucher, Alexander 抄送: Wang, Ken; Huan, Alvin; Huang, Ray
主题: [PATCH v2 3/3] drm/amdgpu: update golden setting of polaris10

---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +2 -2
index ea025a5..05c336b 100644
@@ -301,8 +301,8 @@ static const u32 polaris11_golden_common_all[] =
 static const u32 golden_settings_polaris10_a11[] =
 {
         mmATC_MISC_CG, 0x000c0fc0, 0x000c0200,
-       mmCB_HW_CONTROL, 0xfffdf3cf, 0x00007208,
-       mmCB_HW_CONTROL_2, 0, 0x0f000000,
+       mmCB_HW_CONTROL, 0x0001f3cf, 0x00007208,
+       mmCB_HW_CONTROL_2, 0x0f000000, 0x0f000000,
         mmCB_HW_CONTROL_3, 0x000001ff, 0x00000040,
         mmDB_DEBUG2, 0xf00fffff, 0x00000400,
         mmPA_SC_ENHANCE, 0xffffffff, 0x20000001,

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#11 lore raw
In reply to a message not in the archive

Hi,

I think it would be helpful for at least one liner explaining actually what is even getting "fixed" here? Obviously we assume, given that you work for AMD, these magics are correct however it does help in case of issue.

Just for a motivating example, suppose a magic is technically correct as per hw documentation but there is a bug in the ASIC itself that this changed caused a regression with then we would know where/how it occurs.

Kind Regards,
Edward.

Quoted 11 lines · Huang Rui

Hi all,

This patch set are all changes of golden setting, mgcg_cgcg setting, tiling mode array and rev id of VI series of cards.

Changes from V1 -> V2:
- Polaris10 changes are in tonga and polaris11 patches. And fix it.

Thanks,
Rui

Quoted 8 lines

Huang Rui (3):
drm/amdgpu: update golden setting of tonga
drm/amdgpu: update golden setting of polaris11
drm/amdgpu: update golden setting of polaris10

 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 57d13336-f5ae-99f5-5b2d-0c65b8acacd1-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org

#13 lore raw

I forgot to say, if this is clear to everyone else but me you can just ignore my noise here :p

Quoted 37 lines · Edward O'Callaghan

Hi,

I think it would be helpful for at least one liner explaining actually what is even getting "fixed" here? Obviously we assume, given that you work for AMD, these magics are correct however it does help in case of issue.

Just for a motivating example, suppose a magic is technically correct as per hw documentation but there is a bug in the ASIC itself that this changed caused a regression with then we would know where/how it occurs.

Kind Regards,
Edward.

Quoted 11 lines · Huang Rui

Hi all,

This patch set are all changes of golden setting, mgcg_cgcg setting, tiling mode array and rev id of VI series of cards.

Changes from V1 -> V2:
- Polaris10 changes are in tonga and polaris11 patches. And fix it.

Thanks,
Rui

Quoted 8 lines

Huang Rui (3):
drm/amdgpu: update golden setting of tonga
drm/amdgpu: update golden setting of polaris11
drm/amdgpu: update golden setting of polaris10

 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Quoted 5 lines

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): a47a4a95-147b-5e3b-aadd-57545102ce25-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org

#15 lore raw

Well, usually they are just the recommended settings from the hardware team which try to fix or improve things by changing the default values for the registers.

I work for AMD and sometimes it isn't clear to me either what those changes are good for. E.g. I would need to dig though a whole bunch of register documentation and hardware specs to figure that out.

Alternatively I can try to steal some free time from the hardware guy who initiated the change and try to figure out the background.

Both tasks are rather time consuming and most likely not necessary at all as long as you don't run into a regression.

Regards,
Christian.

Am 03.08.2016 um 14:09 schrieb Edward O'Callaghan:

Quoted 47 lines

I forgot to say, if this is clear to everyone else but me you can just ignore my noise here :p

Quoted 36 lines · Edward O'Callaghan

Hi,

I think it would be helpful for at least one liner explaining actually what is even getting "fixed" here? Obviously we assume, given that you work for AMD, these magics are correct however it does help in case of issue.

Just for a motivating example, suppose a magic is technically correct as per hw documentation but there is a bug in the ASIC itself that this changed caused a regression with then we would know where/how it occurs.

Kind Regards,
Edward.

Quoted 11 lines · Huang Rui

Hi all,

This patch set are all changes of golden setting, mgcg_cgcg setting, tiling mode array and rev id of VI series of cards.

Changes from V1 -> V2:
- Polaris10 changes are in tonga and polaris11 patches. And fix it.

Thanks,
Rui

Quoted 8 lines

Huang Rui (3):
drm/amdgpu: update golden setting of tonga
drm/amdgpu: update golden setting of polaris11
drm/amdgpu: update golden setting of polaris10

  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 ++++++----
  1 file changed, 6 insertions(+), 4 deletions(-)
Quoted 5 lines

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Quoted 4 lines

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 9647b795-489e-9a57-518f-7580f045bf09-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

author
#17 lore raw

Hi Edward,

Christian's words are right. These changes are recommended by hardware team. We would run a round of testing with this default value change. :-)

Thanks,
Rui

Quoted 70 lines · Christian König

Well, usually they are just the recommended settings from the hardware team which try to fix or improve things by changing the default values for the registers.

I work for AMD and sometimes it isn't clear to me either what those changes are good for. E.g. I would need to dig though a whole bunch of register documentation and hardware specs to figure that out.

Alternatively I can try to steal some free time from the hardware guy who initiated the change and try to figure out the background.

Both tasks are rather time consuming and most likely not necessary at all as long as you don't run into a regression.

Regards,
Christian.

Am 03.08.2016 um 14:09 schrieb Edward O'Callaghan:

I forgot to say, if this is clear to everyone else but me you can just ignore my noise here :p

On 08/03/2016 10:06 PM, Edward O'Callaghan wrote:

Hi,

I think it would be helpful for at least one liner explaining actually what is even getting "fixed" here? Obviously we assume, given that you work for AMD, these magics are correct however it does help in case of issue.

Just for a motivating example, suppose a magic is technically correct as per hw documentation but there is a bug in the ASIC itself that this changed caused a regression with then we would know where/how it occurs.

Kind Regards,
Edward.

On 08/02/2016 03:23 PM, Huang Rui wrote:

Hi all,

This patch set are all changes of golden setting, mgcg_cgcg setting, tiling mode array and rev id of VI series of cards.

Changes from V1 -> V2:
- Polaris10 changes are in tonga and polaris11 patches. And fix it.

Thanks,
Rui

Huang Rui (3):
drm/amdgpu: update golden setting of tonga drm/amdgpu: update golden setting of polaris11 drm/amdgpu: update golden setting of polaris10

drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Quoted 6 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx