Skip to contentSkip to conversation

Staging: comedi: cd_pcidas64.c: Compression of

PATCH In review Nadim almas 2 participants 2 messages Aug 2, 2016 – Aug 21, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: cd_pcidas64.c: Compression of

This patch compresses two lines in to a single line in file cb_pcidas64.c
if immediate return statement is found.

It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function:

@@
expression e, ret;
@@

-ret =
+return

     e;

-return ret

---

 drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +1 -3
index 1f9c08a..d30cf3d 100644
@@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
 	if (retval < 0)
 		return retval;
 
-	num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
-
-	return num_samples;
+	return retval * fifo->num_segments * fifo->sample_packing_ratio;
 }
 
 /* query length of fifo */
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 16 lines · Nadim almas

This patch compresses two lines in to a single line in file cb_pcidas64.c
if immediate return statement is found.

It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function:

@@
expression e, ret;
@@

(quoted diff) +1 -2
-ret =
+return
     e;
-return ret
Quoted 6 lines

---

 drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Subject is still quite odd :(