Skip to contentSkip to conversation

Patch "ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Aug 3, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-timer-fix-leak-in-sndrv_timer_ioctl_params.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cec8f96e49d9be372fdb0c3836dcf31ec71e457e Mon Sep 17 00:00:00 2001

From: Kangjie Lu <[email protected]>
Date: Tue, 3 May 2016 16:44:07 -0400
Subject: ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kangjie Lu <[email protected]>

commit cec8f96e49d9be372fdb0c3836dcf31ec71e457e upstream.

The stack object “tread” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized.

---
 sound/core/timer.c |    1 +
 1 file changed, 1 insertion(+)
sound/core/timer.c +1 -0
@@ -1739,6 +1739,7 @@ static int snd_timer_user_params(struct
 	if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
 		if (tu->tread) {
 			struct snd_timer_tread tread;
+			memset(&tread, 0, sizeof(tread));
 			tread.event = SNDRV_TIMER_EVENT_EARLY;
 			tread.tstamp.tv_sec = 0;
 			tread.tstamp.tv_nsec = 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/alsa-timer-fix-leak-in-events-via-snd_timer_user_ccallback.patch queue-4.6/alsa-timer-fix-leak-in-sndrv_timer_ioctl_params.patch queue-4.6/alsa-timer-fix-leak-in-events-via-snd_timer_user_tinterrupt.patch