Skip to contentSkip to conversation

igt_kms: Use proper panning coordinates for legacy primary plane updates

PATCH In review Matt Roper 2 participants 3 messages Aug 3, 2016 – Aug 4, 2016 Library code

lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 igt_kms: Use proper panning coordinates for legacy primary plane updates

A copy/paste error resulted in us using src_x for both the x and y panning coordinates; make sure we use src_y instead for the appropriate parameter.

Fixes 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
Cc Maarten Lankhorst <[email protected]>
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/igt_kms.c +2 -2
index 7d7a53c..ed91688 100644
@@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
 		    igt_output_name(output),
 		    kmstest_pipe_name(pipe->pipe),
 		    fb_id,
-		    primary->src_x, primary->src_x,
+		    primary->src_x, primary->src_y,
 		    mode->hdisplay, mode->vdisplay);
 
 		ret = drmModeSetCrtc(display->drm_fd,
 				     crtc_id,
 				     fb_id,
-				     primary->src_x, primary->src_x,
+				     primary->src_x, primary->src_y,
 				     &output->id,
 				     1,
 				     mode);
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Wed, 3 Aug 2016 09:15:41 -0700 Matt Roper <[email protected]> wrote:

A copy/paste error resulted in us using src_x for both the x and y panning coordinates; make sure we use src_y instead for the appropriate parameter.

Fixes 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
Cc Maarten Lankhorst <[email protected]>
Quoted 24 lines
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/igt_kms.c +2 -2
index 7d7a53c..ed91688 100644
@@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
 		    igt_output_name(output),
 		    kmstest_pipe_name(pipe->pipe),
 		    fb_id,
-		    primary->src_x, primary->src_x,
+		    primary->src_x, primary->src_y,
 		    mode->hdisplay, mode->vdisplay);
 
 		ret = drmModeSetCrtc(display->drm_fd,
 				     crtc_id,
 				     fb_id,
-				     primary->src_x, primary->src_x,
+				     primary->src_x, primary->src_y,
 				     &output->id,
 				     1,
 				     mode);
Signature · 11 lines
--
Bob Paauwe                  
[email protected]
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw
Quoted 7 lines · Bob Paauwe
Quoted 4 lines · On Wed, 3 Aug 2016 09:15:41 -0700 Matt Roper <[email protected]> wrote:

A copy/paste error resulted in us using src_x for both the x and y panning coordinates; make sure we use src_y instead for the appropriate parameter.

Quoted 5 lines
Quoted 3 lines
Fixes 0e29ce3265b ("igt_kms: Remove pan members from igt_plane, v2.")
Cc Maarten Lankhorst <[email protected]>

Merged; thanks for the review.

Matt

Quoted 36 lines
Quoted 25 lines
---
 lib/igt_kms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/igt_kms.c +2 -2
index 7d7a53c..ed91688 100644
@@ -1937,13 +1937,13 @@ static int igt_primary_plane_commit_legacy(igt_plane_t *primary,
 		    igt_output_name(output),
 		    kmstest_pipe_name(pipe->pipe),
 		    fb_id,
-		    primary->src_x, primary->src_x,
+		    primary->src_x, primary->src_y,
 		    mode->hdisplay, mode->vdisplay);
 
 		ret = drmModeSetCrtc(display->drm_fd,
 				     crtc_id,
 				     fb_id,
-				     primary->src_x, primary->src_x,
+				     primary->src_x, primary->src_y,
 				     &output->id,
 				     1,
 				     mode);
Signature · 6 lines
--
Bob Paauwe                  
[email protected]
IOTG / PED Software Organization
Intel Corp.  Folsom, CA
(916) 356-6193    
Signature · 9 lines
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx