Skip to contentSkip to conversation

drm/amdgpu: Add virtual display feature.

PATCH In review Emily Deng 5 participants 7 messages Aug 4, 2016 – Aug 5, 2016 4 messages not in the archive

lore
Share & tools
lore

Emily Deng

author
#0 lore raw

cover drm/amdgpu: Add virtual display feature.

The Virtual Display feature is to fake a display engine in amdgpu kernel driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU. The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU;
2)GPU with head (display engine) but Video BIOS disables display capability for some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable amdgpu_virtual_display.

 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855 +++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1470294292-1897-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Adding dri-devel.

This patch set basically adds a driver option to enable virtual display hw if the user needs it (e.g., virtualization environments, headless cards, pre-silicon environments, etc.). It looks like a regular KMS crtc/encoder/connector and works with existing userspace unchanged.

Alex

Quoted 46 lines · Emily Deng

The Virtual Display feature is to fake a display engine in amdgpu kernel driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU. The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU;
2)GPU with head (display engine) but Video BIOS disables display capability for some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable amdgpu_virtual_display.

 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855 +++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h
Quoted 7 lines

--
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
Quoted 7 lines · Alex Deucher

Adding dri-devel.

This patch set basically adds a driver option to enable virtual display hw if the user needs it (e.g., virtualization environments, headless cards, pre-silicon environments, etc.). It looks like a regular KMS crtc/encoder/connector and works with existing userspace unchanged.

We autodetect this already for virtualized envirnments and pre-silicon. Not so sure about headless cards, on those we don't bother to expose anything if there's nothing connected (i.e. no crtc/encoder/plane or connector objects at all). Why do you want fake outputs in that case?

Anyway, if this is just a modparam and disabled by default I don't see any issue really at all.
-Daniel

Quoted 61 lines

Alex

Quoted 46 lines · Emily Deng

The Virtual Display feature is to fake a display engine in amdgpu kernel driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU. The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU;
2)GPU with head (display engine) but Video BIOS disables display capability for some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable amdgpu_virtual_display.

 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855 +++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h
Quoted 7 lines

--
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): 20160804162450.GO6232-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org

#5 lore raw
Quoted 10 lines · Daniel Vetter
Quoted 7 lines · Alex Deucher

Adding dri-devel.

This patch set basically adds a driver option to enable virtual display hw if the user needs it (e.g., virtualization environments, headless cards, pre-silicon environments, etc.). It looks like a regular KMS crtc/encoder/connector and works with existing userspace unchanged.

We autodetect this already for virtualized envirnments and pre-silicon.

What do you mean? What do you do in those cases?

Quoted 3 lines

Not so sure about headless cards, on those we don't bother to expose anything if there's nothing connected (i.e. no crtc/encoder/plane or connector objects at all). Why do you want fake outputs in that case?

We have some customers that want to run X or other desktops on hardware without display connectors or even chips without display hw at all.

Quoted 3 lines

Anyway, if this is just a modparam and disabled by default I don't see any issue really at all.

Yes, this is controlled by a module option and is intended to only be enabled by the user for specific use cases.

Alex

Quoted 64 lines

-Daniel

Quoted 53 lines

Alex

Quoted 49 lines · Emily Deng

The Virtual Display feature is to fake a display engine in amdgpu kernel driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU. The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU;
2)GPU with head (display engine) but Video BIOS disables display capability for some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable amdgpu_virtual_display.

 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855 +++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h

--
1.9.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Quoted 4 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#6 lore raw
Quoted 10 lines · Alex Deucher
Quoted 9 lines · Daniel Vetter
Quoted 7 lines · Alex Deucher

Adding dri-devel.

This patch set basically adds a driver option to enable virtual display hw if the user needs it (e.g., virtualization environments, headless cards, pre-silicon environments, etc.). It looks like a regular KMS crtc/encoder/connector and works with existing userspace unchanged.

Quoted 3 lines
Quoted 1 line

We autodetect this already for virtualized envirnments and pre-silicon.

What do you mean? What do you do in those cases?

So virtualized (xengt) I think just fakes one display/connector, I didn't really check the details tbh. We had code floating around (but not merged) for the management console on servers, which injected a special config into iirc the VGA port. So a mix of kernel driver and hw/firmware tricks.

Pre-silicon just has a bunch of things to fake enough of a display since not all environments have the full display block simulated.

Anyway just wanted to say that we have piles of precendence for faking semi-virtual outputs.

Quoted 7 lines
Quoted 3 lines

Not so sure about headless cards, on those we don't bother to expose anything if there's nothing connected (i.e. no crtc/encoder/plane or connector objects at all). Why do you want fake outputs in that case?

We have some customers that want to run X or other desktops on hardware without display connectors or even chips without display hw at all.

Hm, for that I'd say virtual output/screen in X. Adding a fake output in the kernel where there really is nothing at all feels a bit wrong. All the examples above mean that the output is actually connected to something on the other side (screen on the management console, host OS for xengt or pre-silicon simulations).

Quoted 5 lines
Quoted 2 lines

Anyway, if this is just a modparam and disabled by default I don't see any issue really at all.

Yes, this is controlled by a module option and is intended to only be enabled by the user for specific use cases.

Another option for entirely fake outputs would be vkms.ko, similar to vgem.ko. With the simple display driver it should be fairly easy to a simple fake kms driver with just 1 crtc/encoder/connector/plane, all virtual, up&running. Needs a few lines to implement dumb mmap on top of shmem (but nothing else, since the driver never reads the buffer), plus prime import/export scaffolding. One module option (could even adjust at runtime) to configure how many drm_device instance there should be. Output configuration could be done by injecting a suitable EDID plus forcing the connector state (we have interfaces for that already, and iirc even patches to expose them all in sysfs).

I'd say if you really want entirely fake/virtual outputs that go exactly nowhere at all, vkms.ko would be the cleanest approach. And that would have lots of use-cases outputs of just what you need, for e.g. testing kms helpers/ioctls and other nice things.
-Daniel

Quoted 71 lines

Alex

Quoted 68 lines

-Daniel

Quoted 53 lines

Alex

Quoted 49 lines · Emily Deng

The Virtual Display feature is to fake a display engine in amdgpu kernel driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU. The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU;
2)GPU with head (display engine) but Video BIOS disables display capability for some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable amdgpu_virtual_display.

 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855 +++++++++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h

--
1.9.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

A message that is not in the archive (sent off-list or not yet received): 20160804172319.GV6232-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org

#8 lore raw
Quoted 65 lines

-----Original Message-----
From: dri-devel [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Thursday, August 04, 2016 1:23 PM
To: Alex Deucher
Cc: Deng, Emily; amd-gfx list; Maling list - DRI developers
Subject: Re: [PATCH 00/13] drm/amdgpu: Add virtual display feature.

Quoted 10 lines · Alex Deucher
Quoted 9 lines · Daniel Vetter
Quoted 7 lines · Alex Deucher

Adding dri-devel.

This patch set basically adds a driver option to enable virtual display hw if the user needs it (e.g., virtualization environments, headless cards, pre-silicon environments, etc.). It looks like a regular KMS crtc/encoder/connector and works with existing userspace unchanged.

Quoted 3 lines
Quoted 1 line

We autodetect this already for virtualized envirnments and pre-silicon.

What do you mean? What do you do in those cases?

So virtualized (xengt) I think just fakes one display/connector, I didn't really check the details tbh. We had code floating around (but not merged) for the management console on servers, which injected a special config into iirc the VGA port. So a mix of kernel driver and hw/firmware tricks.

Pre-silicon just has a bunch of things to fake enough of a display since not all environments have the full display block simulated.

Anyway just wanted to say that we have piles of precendence for faking semi- virtual outputs.

Quoted 7 lines
Quoted 3 lines

Not so sure about headless cards, on those we don't bother to expose anything if there's nothing connected (i.e. no crtc/encoder/plane or connector objects at all). Why do you want fake outputs in that case?

We have some customers that want to run X or other desktops on hardware without display connectors or even chips without display hw at all.

Hm, for that I'd say virtual output/screen in X. Adding a fake output in the kernel where there really is nothing at all feels a bit wrong. All the examples above mean that the output is actually connected to something on the other side (screen on the management console, host OS for xengt or pre-silicon simulations).

Quoted 5 lines
Quoted 2 lines

Anyway, if this is just a modparam and disabled by default I don't see any issue really at all.

Yes, this is controlled by a module option and is intended to only be enabled by the user for specific use cases.

Another option for entirely fake outputs would be vkms.ko, similar to vgem.ko. With the simple display driver it should be fairly easy to a simple fake kms driver with just 1 crtc/encoder/connector/plane, all virtual, up&running. Needs a few lines to implement dumb mmap on top of shmem (but nothing else, since the driver never reads the buffer), plus prime import/export scaffolding. One module option (could even adjust at runtime) to configure how many drm_device instance there should be. Output configuration could be done by injecting a suitable EDID plus forcing the connector state (we have interfaces for that already, and iirc even patches to expose them all in sysfs).

Quoted 4 lines

I'd say if you really want entirely fake/virtual outputs that go exactly nowhere at all, vkms.ko would be the cleanest approach. And that would have lots of use-cases outputs of just what you need, for e.g. testing kms helpers/ioctls and other nice things.

FWIW I don't think we ever plan to have virtual outputs that go nowhere - the display content just might go out via VNC or a compressed streaming interface rather than through a local display controller.

Quoted 84 lines

-Daniel

Quoted 9 lines

Alex

Quoted 6 lines

-Daniel

Quoted 4 lines

Alex

On Thu, Aug 4, 2016 at 3:04 AM, Emily Deng <[email protected]>

Quoted 1 line · wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line

The Virtual Display feature is to fake a display engine in amdgpu kernel

driver, which allows any other kernel modules or user mode components to work as expected even without real display HW. User can get the desktop/primary surface through remote desktop tools instead of displaying HW associated with the GPU.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

The virtual display feature is designed for following cases:
1)Headless GPU, which has no display engine, while for some reason the X server is required to initialize in this GPU; 2)GPU with head (display engine) but Video BIOS disables display capability for

some reason. For example, SR-IOV virtualization enabled Video BIOS often disables display connector. Some S-series Pro-Graphics designed for headless computer also disable display capability in Video BIOS; 3)For whatever reason, end user wants to enable a virtual display (don’t need HW display capability).

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines

Emily Deng (13):
drm/amdgpu: Add virtual connector and encoder macros. drm/amdgpu: Initialize dce_virtual_ip_funcs
drm/amdgpu: Initialize dce_virtual_display_funcs. drm/amdgpu: Initialize crtc, pageflip irq funcs drm/amdgpu: Initialize dce_virtual_crtc_helper_funcs drm/amdgpu: Initialize dce_virtual_crtc_funcs. drm/amdgpu: Disable VGA render and crtc when init GMC. drm/amdgpu: Use software timer to generate vsync interrupt. drm/amdgpu: Call pageflip irq funtion when receiced vsync interrupt. drm/amdgpu: Add DRM_MODE_CONNECTOR_VIRTUAL connector in
amdgpu_connector_add.
drm/amdgpu: Define vitual display ip blocks.
drm/amdgpu: Define one variable for virtual display. drm/amdgpu: Set ip_blocks according variable

amdgpu_virtual_display.

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
 drivers/gpu/drm/amd/amdgpu/Makefile            |   3 +-
 drivers/gpu/drm/amd/amdgpu/ObjectID.h          |   7 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h            |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c   |  27 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h   |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  95 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c     |   5 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c    |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c        |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h       |   9 +-
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
 drivers/gpu/drm/amd/amdgpu/cik.c               | 445 +++++++++++--
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c         |  75 +++
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c         |  83 +++
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.h         |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c          |  82 +++
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.h          |   2 +
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c       | 855

+++++++++++++++++++++++++

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
 drivers/gpu/drm/amd/amdgpu/dce_virtual.h       |  31 +
 drivers/gpu/drm/amd/amdgpu/vi.c                | 416 ++++++++++--
 20 files changed, 2062 insertions(+), 91 deletions(-)  create
mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/dce_virtual.h

--
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation http://blog.ffwll.ch

Quoted 8 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): DM3PR12MB09058389085B882AA873C61CE8070-4hRkV8tDpBhOegFl3cuaPAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#10 lore raw
Quoted 15 lines · John
Quoted 15 lines

-----Original Message-----
From: dri-devel [mailto:[email protected]] On Behalf Of Daniel Vetter

Another option for entirely fake outputs would be vkms.ko, similar to vgem.ko. With the simple display driver it should be fairly easy to a simple fake kms driver with just 1 crtc/encoder/connector/plane, all virtual, up&running. Needs a few lines to implement dumb mmap on top of shmem (but nothing else, since the driver never reads the buffer), plus prime import/export scaffolding. One module option (could even adjust at runtime) to configure how many drm_device instance there should be. Output configuration could be done by injecting a suitable EDID plus forcing the connector state (we have interfaces for that already, and iirc even patches to expose them all in sysfs).

Quoted 8 lines
Quoted 4 lines

I'd say if you really want entirely fake/virtual outputs that go exactly nowhere at all, vkms.ko would be the cleanest approach. And that would have lots of use-cases outputs of just what you need, for e.g. testing kms helpers/ioctls and other nice things.

FWIW I don't think we ever plan to have virtual outputs that go nowhere
- the display content just might go out via VNC or a compressed streaming interface rather than through a local display controller.

We might be getting into semantics territory here, but I'd say the virtual KMS output still goes "nowhere" in that case, since it's not involved in the remote display.

I'm afraid this kind of setup might not be useful for proprietary OpenGL driver bringup though, as long as that uses its own libGL and GLX infrastructure.

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx