gem_largeobject: Fix for clang compiler
PATCH v2 1/1 gem_largeobject: Fix for clang compiler
The clang compiler generates a build error for binaries with >128MB data segments because "The gap between stack and binary is only guarenteed to be 128MB on x86_64"
Simple solution is to allocate the required memory from the heap.
[v2: moved malloc to after skip_on_simulation]
--- tests/gem_largeobject.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
tests/gem_largeobject.c +6 -1
@@ -39,7 +39,7 @@/* Should take 64 pages to store the page pointers on 64 bit */ #define OBJ_SIZE (128 * 1024 * 1024) -unsigned char data[OBJ_SIZE ]; +unsigned char *data;static void test_large_object (int fd)
@@ -79,7 +79,12 @@ igt_simple_mainigt_skip_on_simulation (); + data =malloc (OBJ_SIZE ); +igt_assert (data); + fd =drm_open_driver (DRIVER_INTEL );test_large_object (fd); + +free (data); }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Bump,
Can this be merged? It is a simple fix for an issue with the clang compiler.
//Derek
-----Original Message-----
From: Morton, Derek J
Sent: Thursday, August 4, 2016 3:37 PM
To: [email protected]
Cc: Gore, Tim <[email protected]>; Morton, Derek J <[email protected]>
Subject: [PATCH i-g-t v2] gem_largeobject: Fix for clang compiler
The clang compiler generates a build error for binaries with >128MB data segments because "The gap between stack and binary is only guarenteed to be 128MB on x86_64"
Simple solution is to allocate the required memory from the heap.
[v2: moved malloc to after skip_on_simulation]
--- tests/gem_largeobject.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
tests/gem_largeobject.c +6 -1
@@ -39,7 +39,7 @@/* Should take 64 pages to store the page pointers on 64 bit */ #define OBJ_SIZE (128 * 1024 * 1024) -unsigned char data[OBJ_SIZE ]; +unsigned char *data;static void test_large_object (int fd)
@@ -79,7 +79,12 @@ igt_simple_mainigt_skip_on_simulation (); + data =malloc (OBJ_SIZE ); +igt_assert (data); + fd =drm_open_driver (DRIVER_INTEL );test_large_object (fd); + +free (data); }
--
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx