Skip to contentSkip to conversation

Patch "irqchip/mips-gic: Map to VPs using HW VPNum" has been added to the 4.6-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

irqchip/mips-gic: Map to VPs using HW VPNum

to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
irqchip-mips-gic-map-to-vps-using-hw-vpnum.patch
and it can be found in the queue-4.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 99ec8a3608330d202448085185cf28389b789b7b Mon Sep 17 00:00:00 2001

From: Paul Burton <[email protected]>
Date: Tue, 5 Jul 2016 14:25:59 +0100
Subject: irqchip/mips-gic: Map to VPs using HW VPNum

From: Paul Burton <[email protected]>

commit 99ec8a3608330d202448085185cf28389b789b7b upstream.

When mapping an interrupt to a VP(E) we must use the identifier for the VP that the hardware expects, and this does not always match up with the Linux CPU number. Commit d46812bb0bef ("irqchip: mips-gic: Use HW IDs for VPE_OTHER_ADDR") corrected this for the cases that existed at the time it was written, but commit 2af70a962070 ("irqchip/mips-gic: Add a IPI hierarchy domain") added another case before the former patch was merged. This leads to incorrectly using Linux CPU numbers when mapping interrupts to VPs, which breaks on certain systems such as those with multi-core I6400 CPUs. Fix by adding the appropriate call to mips_cm_vp_id() to retrieve the expected VP identifier.

Fixes d46812bb0bef ("irqchip: mips-gic: Use HW IDs for VPE_OTHER_ADDR")
Fixes 2af70a962070 ("irqchip/mips-gic: Add a IPI hierarchy domain")
Cc Jason Cooper <[email protected]>
Cc Qais Yousef <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Marc Zyngier <[email protected]>
---
 drivers/irqchip/irq-mips-gic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-mips-gic.c +1 -1
@@ -706,7 +706,7 @@ static int gic_shared_irq_domain_map(str
 
 	spin_lock_irqsave(&gic_lock, flags);
 	gic_map_to_pin(intr, gic_cpu_pin);
-	gic_map_to_vpe(intr, vpe);
+	gic_map_to_vpe(intr, mips_cm_vp_id(vpe));
 	for (i = 0; i < min(gic_vpes, NR_CPUS); i++)
 		clear_bit(intr, pcpu_masks[i].pcpu_mask);
 	set_bit(intr, pcpu_masks[vpe].pcpu_mask);

Patches currently in stable-queue which might be from [email protected] are

queue-4.6/irqchip-mips-gic-match-ipi-irq-domain-by-bus-token-only.patch queue-4.6/irqchip-mips-gic-map-to-vps-using-hw-vpnum.patch