persist_data: Fix py3 update stack overflow

PATCH New Richard Purdie 1 participant 1 message Aug 10, 2016

Share & tools

Richard Purdie

author

2016-08-10 15:00 UTC #0 lore raw

PATCH 1/1 persist_data: Fix py3 update stack overflow

Revision d0f904d407f57998419bd9c305ce53e5eaa36b24 accidentally broke items() and values() and made them cause stack overflows. Undo that breakage.

Signed-off-by Richard Purdie <[email protected]>

---
 lib/bb/persist_data.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

lib/bb/persist_data.py +2 -2

index 403f3a5..bb6deca 100644
@@ -131,14 +131,14 @@ class SQLTable(collections.MutableMapping):
         return [row[1] for row in data]
 
     def values(self):
-        return list(self.values())
+        return list(self.itervalues())
 
     def itervalues(self):
         data = self._execute("SELECT value FROM %s;" % self.table)
         return (row[0] for row in data)
 
     def items(self):
-        return list(self.items())
+        return list(self.iteritems())
 
     def iteritems(self):
         return self._execute("SELECT * FROM %s;" % self.table)