Skip to contentSkip to conversation

capture error context

PATCH In review Arun Siluvery 4 participants 6 messages Aug 11, 2016 – Aug 18, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover capture error context

and one other small change.

Arun Siluvery (1):
drm/i915/error: Use yesno() to report iommu enable status

Dave Gordon (1):
drm/i915/error: capture errored context based on request context-id

 drivers/gpu/drm/i915/i915_drv.h       |  2 ++
 drivers/gpu/drm/i915/i915_gpu_error.c | 48 +++++++++++++++++++++++++----------
 2 files changed, 36 insertions(+), 14 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 1/2 drm/i915/error: Use yesno() to report iommu enable status

---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gpu_error.c +1 -1
index eecb870..3209f6a 100644
@@ -363,7 +363,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
 	err_printf(m, "PCI Subsystem: %04x:%04x\n",
 		   dev->pdev->subsystem_vendor,
 		   dev->pdev->subsystem_device);
-	err_printf(m, "IOMMU enabled?: %d\n", error->iommu);
+	err_printf(m, "IOMMU enabled?: %s\n", yesno(error->iommu == 1));
 
 	if (HAS_CSR(dev)) {
 		struct intel_csr *csr = &dev_priv->csr;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH 2/2 drm/i915/error: capture errored context based on request context-id

In reply to Arun Siluvery

From: Dave Gordon <[email protected]>

Context capture hasn't worked for a while now, since the introduction of execlists because the function that records active context is using CCID register but this register contents are not valid in Execlist mode; this patch makes it work again by using a different way of identifying the context of interest in execlist mode.

For: VIZ-2021

---
 drivers/gpu/drm/i915/i915_drv.h       |  2 ++
 drivers/gpu/drm/i915/i915_gpu_error.c | 46 +++++++++++++++++++++++++----------
 2 files changed, 35 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -0
index 7971c76..94b9314 100644
@@ -546,6 +546,8 @@ struct drm_i915_error_state {
 		u32 rc_psmi; /* sleep state */
 		u32 semaphore_mboxes[I915_NUM_ENGINES - 1];
 
+		u64 ctx_desc;
+
 		struct drm_i915_error_object {
 			int page_count;
 			u64 gtt_offset;
drivers/gpu/drm/i915/i915_gpu_error.c +33 -13

95 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [PATCH 2/2] drm/i915/error: capture errored context based on request context-id

Quoted 7 lines · Arun Siluvery

From: Dave Gordon <[email protected]>

Context capture hasn't worked for a while now, since the introduction of execlists because the function that records active context is using CCID register but this register contents are not valid in Execlist mode; this patch makes it work again by using a different way of identifying the context of interest in execlist mode.

Bzzt. The contexts are stored in the request and the iteration here is still unsafe.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Re: [PATCH 2/2] drm/i915/error: capture errored context based on request context-id

Quoted 9 lines · Chris Wilson
Quoted 7 lines · Arun Siluvery

From: Dave Gordon <[email protected]>

Context capture hasn't worked for a while now, since the introduction of execlists because the function that records active context is using CCID register but this register contents are not valid in Execlist mode; this patch makes it work again by using a different way of identifying the context of interest in execlist mode.

Quoted 3 lines

Bzzt. The contexts are stored in the request and the iteration here is still unsafe.
-Chris

This patch didn't add any iteration, so any unsafe iteration was already there.

All this did was change the matching criterion for which context is the one interesting one, by matching on the relevant parts of the "active context descriptor" rather than only the (obsolete) CCID register.

.Dave.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✗ Ro.CI.BAT: failure for capture error context

In reply to Arun Siluvery
== Series Details ==

== Series Details ==

Series: capture error context
URL : https://patchwork.freedesktop.org/series/10968/
State : failure

== Summary ==

Series 10968v1 capture error context
http://patchwork.freedesktop.org/api/1.0/series/10968/revisions/1/mbox

Test drv_module_reload_basic:

                pass       -> SKIP       (ro-hsw-i3-4010u)
Test gem_exec_suspend:
        Subgroup basic-s3:
                incomplete -> DMESG-WARN (fi-skl-i7-6700k)
Test kms_cursor_legacy:
        Subgroup basic-cursor-vs-flip-legacy:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-cursor-vs-flip-varying-size:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-flip-vs-cursor-legacy:
                fail       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> FAIL       (ro-bdw-i5-5250u)
        Subgroup basic-flip-vs-cursor-varying-size:
                pass       -> SKIP       (ro-hsw-i7-4770r)
                pass       -> FAIL       (ro-byt-n2820)
                fail       -> PASS       (fi-hsw-i7-4770k)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-flip-vs-modeset:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-plain-flip:
                pass       -> SKIP       (ro-hsw-i7-4770r)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                pass       -> SKIP       (ro-hsw-i7-4770r)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup hang-read-crc-pipe-b:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup hang-read-crc-pipe-c:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-a:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-b:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-c:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup nonblocking-crc-pipe-c-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-a:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-a-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-b:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-b-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-c:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup read-crc-pipe-c-frame-sequence:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> SKIP       (ro-hsw-i7-4770r)
                dmesg-warn -> SKIP       (ro-bdw-i5-5250u)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> SKIP       (ro-hsw-i7-4770r)
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                skip       -> FAIL       (fi-hsw-i7-4770k)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                pass       -> SKIP       (ro-hsw-i7-4770r)
        Subgroup basic-rte:
                pass       -> SKIP       (ro-hsw-i7-4770r)
fi-hsw-i7-4770k  total:244  pass:222  dwarn:0   dfail:0   fail:1   skip:21 
fi-kbl-qkkr      total:244  pass:186  dwarn:30  dfail:0   fail:2   skip:26 
fi-skl-i5-6260u  total:244  pass:224  dwarn:4   dfail:0   fail:2   skip:14 
fi-skl-i7-6700k  total:244  pass:208  dwarn:4   dfail:2   fail:2   skip:28 
fi-snb-i7-2600   total:244  pass:202  dwarn:0   dfail:0   fail:0   skip:42 
ro-bdw-i5-5250u  total:240  pass:218  dwarn:3   dfail:0   fail:2   skip:17 
ro-bdw-i7-5600u  total:240  pass:207  dwarn:0   dfail:0   fail:1   skip:32 
ro-bsw-n3050     total:240  pass:194  dwarn:0   dfail:0   fail:4   skip:42 
ro-byt-n2820     total:240  pass:197  dwarn:0   dfail:0   fail:3   skip:40 
ro-hsw-i3-4010u  total:240  pass:213  dwarn:0   dfail:0   fail:0   skip:27 
ro-hsw-i7-4770r  total:240  pass:185  dwarn:0   dfail:0   fail:0   skip:55 
ro-ilk1-i5-650   total:235  pass:173  dwarn:0   dfail:0   fail:2   skip:60 
ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
ro-skl3-i5-6260u total:240  pass:222  dwarn:0   dfail:0   fail:4   skip:14 

ro-bdw-i7-5557U failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1840/

3c6050a drm-intel-nightly: 2016y-08m-11d-10h-34m-38s UTC integration manifest 5e163bc drm/i915/error: capture errored context based on request context-id 2fba1b0 drm/i915/error: Use yesno() to report iommu enable status

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx