patch "xhci: don't dereference a xhci member after removing xhci" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
xhci: don't dereference a xhci member after removing xhci
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
f1f6d9a8b540df22b87a5bf6bc104edaade81f47Mon Sep 17 00:00:00 2001
From: Mathias Nyman <[email protected]>
Date: Tue, 16 Aug 2016 10:18:06 +0300
Subject: xhci: don't dereference a xhci member after removing xhci
Remove the hcd after checking for the xhci last quirks, not before.
This caused a hang on a Alpine Ridge xhci based maching which remove the whole xhci controller when unplugging the last usb device
--- drivers/usb/host/xhci-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/xhci-pci.c +2 -1
@@ -314,11 +314,12 @@ static void xhci_pci_remove(struct pci_dev *dev)usb_remove_hcd (xhci->shared_hcd);usb_put_hcd (xhci->shared_hcd); } -usb_hcd_pci_remove (dev);/* Workaround for spurious wakeups at shutdown with HSW */ if (xhci->quirks &XHCI_SPURIOUS_WAKEUP )pci_set_power_state (dev, PCI_D3hot); + +usb_hcd_pci_remove (dev); }#ifdef CONFIG_PM
Signature · 1 line
2.9.3