Skip to contentSkip to conversation

drm/i915: fix some audio support 4K resolution issues

PATCH In review [email protected] 5 participants 16 messages Aug 18, 2016 – Sep 23, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155 +++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH v4 1/3 drm/i915: set proper N/M in modeset

From: Libin Yang <[email protected]>

When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. Otherwise the first several seconds may be silent in audio playback.

The relationship of Maud and Naud is expressed in the following equation:
Maud/Naud = 512 * fs / f_LS_Clk

Please refer VESA DisplayPort Standard spec for details.

---
 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 143 +++++++++++++++++++++++++++++++++----
 2 files changed, 136 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +7 -0
index d4adf28..239f0af 100644
@@ -7337,6 +7337,13 @@ enum {
 #define _HSW_AUD_MISC_CTRL_B		0x65110
 #define HSW_AUD_MISC_CTRL(pipe)		_MMIO_PIPE(pipe, _HSW_AUD_MISC_CTRL_A, _HSW_AUD_MISC_CTRL_B)
 
+#define _HSW_AUD_M_CTS_ENABLE_A		0x65028
+#define _HSW_AUD_M_CTS_ENABLE_B		0x65128
+#define HSW_AUD_M_CTS_ENABLE(pipe)		_MMIO_PIPE(pipe, _HSW_AUD_M_CTS_ENABLE_A, _HSW_AUD_M_CTS_ENABLE_B)
+#define   AUD_M_CTS_M_VALUE_INDEX	(1 << 21)
+#define   AUD_M_CTS_M_PROG_ENABLE	(1 << 20)
+#define   AUD_CONFIG_M_MASK		0xfffff
+
 #define _HSW_AUD_DIP_ELD_CTRL_ST_A	0x650b4
 #define _HSW_AUD_DIP_ELD_CTRL_ST_B	0x651b4
 #define HSW_AUD_DIP_ELD_CTRL(pipe)	_MMIO_PIPE(pipe, _HSW_AUD_DIP_ELD_CTRL_ST_A, _HSW_AUD_DIP_ELD_CTRL_ST_B)
drivers/gpu/drm/i915/intel_audio.c +129 -14

210 lines not on this page · raw message

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH v4 2/3 drm/i915: set proper N/MCTS on more platforms

In reply to [email protected]

From: Libin Yang <[email protected]>

This patch applies setting proper N/M, N/CTS on more platforms.

---
 drivers/gpu/drm/i915/intel_audio.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_audio.c +1 -5
index a8cec50..da8217c 100644
@@ -757,11 +757,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	int n;
 	int err = 0;
 
-	/* HSW, BDW, SKL, KBL need this fix */
-	if (!IS_SKYLAKE(dev_priv) &&
-	    !IS_KABYLAKE(dev_priv) &&
-	    !IS_BROADWELL(dev_priv) &&
-	    !IS_HASWELL(dev_priv))
+	if (!HAS_DDI(dev_priv))
 		return 0;
 
 	i915_audio_component_get_power(dev);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

PATCH v4 3/3 drm/i915: HDMI audio gets the TMDS clock by crtc_clock

In reply to [email protected]

From: Libin Yang <[email protected]>

HDMI audio should use crtc_clock to get the TMDS clock.

This patch renames mode to adjusted_mode to unify the name.

---
 drivers/gpu/drm/i915/intel_audio.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_audio.c +7 -7
index da8217c..577e23a 100644
@@ -162,7 +162,7 @@ static int audio_config_get_n(struct intel_crtc *crtc,
 	if (intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI)) {
 		for (i = 0; i < ARRAY_SIZE(aud_ncts); i++) {
 			if ((rate == aud_ncts[i].sample_rate) &&
-			    (adjusted_mode->clock == aud_ncts[i].clock)) {
+			    (adjusted_mode->crtc_clock == aud_ncts[i].clock)) {
 				return aud_ncts[i].n;
 			}
 		}
@@ -257,8 +257,8 @@ static void audio_m_cts_setup(struct drm_device *dev,
 static bool audio_rate_need_prog(struct intel_crtc *crtc,
 				 const struct drm_display_mode *adjusted_mode)
 {
-	if (((adjusted_mode->clock == TMDS_297M) ||
-		 (adjusted_mode->clock == TMDS_296M)) &&
+	if (((adjusted_mode->crtc_clock == TMDS_297M) ||
+	     (adjusted_mode->crtc_clock == TMDS_296M)) &&
 		intel_crtc_has_type(crtc->config, INTEL_OUTPUT_HDMI))
 		return true;
 	else if (((crtc->config->port_clock == LC_540M) ||
@@ -750,7 +750,7 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 	struct drm_i915_private *dev_priv = dev_to_i915(dev);
 	struct intel_encoder *intel_encoder;
 	struct intel_crtc *crtc;
-	struct drm_display_mode *mode;
+	struct drm_display_mode *adjusted_mode;
 	struct i915_audio_component *acomp = dev_priv->audio_component;
 	enum pipe pipe = INVALID_PIPE;
 	u32 tmp;
@@ -782,20 +782,20 @@ static int i915_audio_component_sync_audio_rate(struct device *dev,
 
 	DRM_DEBUG_KMS("pipe %c connects port %c\n",
 				  pipe_name(pipe), port_name(port));
-	mode = &crtc->config->base.adjusted_mode;
+	adjusted_mode = &crtc->config->base.adjusted_mode;
 
 	/* port must be valid now, otherwise the pipe will be invalid */
 	acomp->aud_sample_rate[port] = rate;
 
 	/* 2. check whether to set the N/CTS/M manually or not */
-	if (!audio_rate_need_prog(crtc, mode)) {
+	if (!audio_rate_need_prog(crtc, adjusted_mode)) {
 		tmp = I915_READ(HSW_AUD_CFG(pipe));
 		tmp &= ~AUD_CONFIG_N_PROG_ENABLE;
 		I915_WRITE(HSW_AUD_CFG(pipe), tmp);
 		goto unlock;
 	}
 
-	n = audio_config_get_n(crtc, mode, rate);
+	n = audio_config_get_n(crtc, adjusted_mode, rate);
 	if (n == 0) {
 		DRM_DEBUG_KMS("Using automatic mode for N value on port %c\n",
 					  port_name(port));
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

✗ Ro.CI.BAT: failure for drm/i915: fix some audio support 4K resolution issues

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: fix some audio support 4K resolution issues
URL : https://patchwork.freedesktop.org/series/11252/
State : failure

== Summary ==

Series 11252v1 drm/i915: fix some audio support 4K resolution issues
http://patchwork.freedesktop.org/api/1.0/series/11252/revisions/1/mbox

Test kms_cursor_legacy:

        Subgroup basic-flip-vs-cursor-legacy:
                pass       -> FAIL       (ro-skl3-i5-6260u)
        Subgroup basic-flip-vs-cursor-varying-size:
                fail       -> PASS       (ro-skl3-i5-6260u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> DMESG-WARN (ro-bdw-i7-5600u)
                dmesg-warn -> SKIP       (ro-bdw-i7-5557U)
                skip       -> DMESG-WARN (ro-bdw-i5-5250u)
fi-kbl-qkkr      total:244  pass:185  dwarn:29  dfail:0   fail:3   skip:27 
fi-skl-i7-6700k  total:244  pass:208  dwarn:4   dfail:2   fail:2   skip:28 
fi-snb-i7-2600   total:244  pass:202  dwarn:0   dfail:0   fail:0   skip:42 
ro-bdw-i5-5250u  total:240  pass:219  dwarn:2   dfail:0   fail:1   skip:18 
ro-bdw-i7-5557U  total:240  pass:220  dwarn:2   dfail:0   fail:0   skip:18 
ro-bdw-i7-5600u  total:240  pass:205  dwarn:2   dfail:0   fail:1   skip:32 
ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
ro-byt-n2820     total:240  pass:198  dwarn:0   dfail:0   fail:2   skip:40 
ro-hsw-i3-4010u  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-hsw-i7-4770r  total:240  pass:185  dwarn:0   dfail:0   fail:0   skip:55 
ro-ilk1-i5-650   total:235  pass:174  dwarn:0   dfail:0   fail:1   skip:60 
ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
ro-skl3-i5-6260u total:240  pass:223  dwarn:0   dfail:0   fail:3   skip:14 

Results at /archive/results/CI_IGT_test/RO_Patchwork_1916/

e45fdef drm-intel-nightly: 2016y-08m-17d-13h-26m-04s UTC integration manifest af9700f drm/i915: HDMI audio gets the TMDS clock by crtc_clock db20b11 drm/i915: set proper N/MCTS on more platforms
cc4544f drm/i915: set proper N/M in modeset

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to [email protected]

Any comments?

Regards,
Libin

Quoted 36 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, August 18, 2016 2:42 PM
To: [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Cc: Yang, Libin <[email protected]>; Libin Yang <[email protected]>
Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

Quoted 7 lines
 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155
+++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)

--
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Sorry for disturb. Is there any comments for the patches?

Regards,
Libin

Quoted 9 lines

-----Original Message-----
From: Yang, Libin
Sent: Monday, August 22, 2016 9:16 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 49 lines

Any comments?

Regards,
Libin

Quoted 43 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, August 18, 2016 2:42 PM
To: [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Cc: Yang, Libin <[email protected]>; Libin Yang <[email protected]>
Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155
+++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)

--
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 1 line · Libin

Sorry for disturb. Is there any comments for the patches?

Ville is on vacation, not sure whom else would be a good reviewer from our side ... Might need to escalate to managers to finding a random reviewer who first needs to ramp up on hdmi/audio issues.
-Daniel

Quoted 67 lines

Regards,
Libin

Quoted 9 lines

-----Original Message-----
From: Yang, Libin
Sent: Monday, August 22, 2016 9:16 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 49 lines

Any comments?

Regards,
Libin

Quoted 43 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, August 18, 2016 2:42 PM
To: [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Cc: Yang, Libin <[email protected]>; Libin Yang <[email protected]>
Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155
+++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)

--
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

Hi Daniel,

Thanks. Let's wait for Ville back from vacation. :)

Regards,
Libin

Quoted 91 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Wednesday, August 24, 2016 1:53 PM
To: Yang, Libin <[email protected]>
Cc: '[email protected]' <[email protected]>; 'intel- [email protected]' <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Sorry for disturb. Is there any comments for the patches?

Ville is on vacation, not sure whom else would be a good reviewer from our side ... Might need to escalate to managers to finding a random reviewer who first needs to ramp up on hdmi/audio issues.
-Daniel

Quoted 37 lines

Regards,
Libin

Quoted 33 lines

-----Original Message-----
From: Yang, Libin
Sent: Monday, August 22, 2016 9:16 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Any comments?

Regards,
Libin

Quoted 18 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, August 18, 2016 2:42 PM
To: [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Cc: Yang, Libin <[email protected]>; Libin Yang <[email protected]>
Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for

dp

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155
+++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

--
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 4 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw
In reply to Yang, Libin

Any comments?

Regards,
Libin

Quoted 11 lines

-----Original Message-----
From: Yang, Libin
Sent: Wednesday, August 24, 2016 1:36 PM
To: '[email protected]' <[email protected]>; 'intel- [email protected]' <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 63 lines

Sorry for disturb. Is there any comments for the patches?

Regards,
Libin

Quoted 58 lines

-----Original Message-----
From: Yang, Libin
Sent: Monday, August 22, 2016 9:16 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Any comments?

Regards,
Libin

Quoted 43 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]]
Sent: Thursday, August 18, 2016 2:42 PM
To: [email protected]; [email protected]; [email protected]; Vetter, Daniel <[email protected]>; [email protected]
Cc: Yang, Libin <[email protected]>; Libin Yang <[email protected]>
Subject: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

From: Libin Yang <[email protected]>

changelog:
v1: initial patches

v2: change to use crtc->config->port_clock instead of mode->clock for dp
change to use mode->crtc_clock instead of mode->clock
rename mode to adjusted_mode

v3: add support for 270MHz
add more platforms support
use u16 n; u16 m to save the space
add support for 192KHz, 96KHz, 88.2KHz split patch for more platform support separately

v4: change to use intel_crtc_has_dp_encoder() to support DP MST
add support for 176.4KHz
fix some tiny code style issues
reset cts to 0 for HDMI mode

Libin Yang (3):
drm/i915: set proper N/M in modeset
drm/i915: set proper N/MCTS on more platforms drm/i915: HDMI audio gets the TMDS clock by crtc_clock

 drivers/gpu/drm/i915/i915_reg.h    |   7 ++
 drivers/gpu/drm/i915/intel_audio.c | 155
+++++++++++++++++++++++++++++++------
 2 files changed, 140 insertions(+), 22 deletions(-)

--
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#10 lore raw
Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw

Hi Jani,

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Regards,
Libin

Quoted 19 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 2:40 AM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

Quoted 8 lines

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#12 lore raw
Quoted 4 lines · Libin

Hi Jani,

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Thanks. Review is also much appreciated! ;)

BR,
Jani.

Quoted 32 lines

Regards,
Libin

Quoted 27 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 2:40 AM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#13 lore raw
Quoted 7 lines · Jani Nikula
Quoted 4 lines · Libin

Hi Jani,

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Thanks. Review is also much appreciated! ;)

Also #2, please have a look at bug [1], especially the patches and discussion from comment #26 on.

Thanks,
Jani.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=97442

Quoted 36 lines

BR,
Jani.

Quoted 32 lines

Regards,
Libin

Quoted 27 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 2:40 AM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#14 lore raw
Quoted 16 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 3:45 PM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 3 lines · Jani Nikula
Quoted 2 lines · Libin

Hi Jani,

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Thanks. Review is also much appreciated! ;)

Also #2, please have a look at bug [1], especially the patches and discussion from comment #26 on.

OK, I will do it tomorrow. Today, I'm busy on DP MST patches.

Regards,
Libin

Quoted 41 lines

Thanks,
Jani.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=97442

Quoted 34 lines

BR,
Jani.

Quoted 30 lines

Regards,
Libin

Quoted 25 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 2:40 AM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

--
Jani Nikula, Intel Open Source Technology Center

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw
In reply to Jani Nikula

Patches are tested and passed. Thanks.

Regards,
Libin

Quoted 63 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 3:45 PM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 7 lines · Jani Nikula
Quoted 4 lines · Libin

Hi Jani,

Thanks a lot for your help on reviewing and refining these patches. I will test your patches and let you know the result.

Thanks. Review is also much appreciated! ;)

Also #2, please have a look at bug [1], especially the patches and discussion from comment #26 on.

Thanks,
Jani.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=97442

Quoted 34 lines

BR,
Jani.

Quoted 30 lines

Regards,
Libin

Quoted 25 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Thursday, September 22, 2016 2:40 AM
To: Yang, Libin <[email protected]>; '[email protected]' <[email protected]>; '[email protected]' <intel- [email protected]>; '[email protected]' <[email protected]>; Vetter, Daniel <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

Quoted 1 line · Libin

Any comments?

Apologies for the way too long delay. I felt it would have been unfair to ask you to do the changes I thought were necessary after such a delay, so I sent them as patches... The last one still needs review, but at least the mundane stuff is out of the way now.

https://patchwork.freedesktop.org/series/12754/

BR,
Jani.

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

--
Jani Nikula, Intel Open Source Technology Center

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx