Patch "s5p-mfc: Add release callback for memory region devs" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
s5p-mfc: Add release callback for memory region devs
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
s5p-mfc-add-release-callback-for-memory-region-devs.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6311f1261f59ce5e51fbe5cc3b5e7737197316acMon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <[email protected]>
Date: Tue, 3 May 2016 16:27:17 -0400
Subject: s5p-mfc: Add release callback for memory region devs
From: Javier Martinez Canillas <[email protected]>
commit 6311f1261f59ce5e51fbe5cc3b5e7737197316ac upstream.
When s5p_mfc_remove() calls put_device() for the reserved memory region devs, the driver core warns that the dev doesn't have a release callback:
WARNING: CPU: 0 PID: 591 at drivers/base/core.c:251 device_release+0x8c/0x90
Device 's5p-mfc-l' does not have a release() function, it is broken and must be fixed.
Also, the declared DMA memory using dma_declare_coherent_memory() isn't relased so add a dev .release that calls dma_release_declared_memory().
--- drivers/media/platform/s5p-mfc/s5p_mfc.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/media/platform/s5p-mfc/s5p_mfc.c +7 -0
@@ -1004,6 +1004,11 @@ static int match_child(struct device *dereturn !strcmp (dev_name (dev), (char *)data); } +static void s5p_mfc_memdev_release (struct device *dev) +{ +dma_release_declared_memory (dev); +} +static void *mfc_get_drv_data (struct platform_device *pdev);static int s5p_mfc_alloc_memdevs (struct s5p_mfc_dev *dev)
@@ -1018,6 +1023,7 @@ static int s5p_mfc_alloc_memdevs(struct }dev_set_name (dev->mem_dev_l,"%s" ,"s5p-mfc-l" ); + dev->mem_dev_l->release = s5p_mfc_memdev_release;device_initialize (dev->mem_dev_l);of_property_read_u32_array (dev->plat_dev->dev.of_node,"samsung,mfc-l" , mem_info,2 );
@@ -1037,6 +1043,7 @@ static int s5p_mfc_alloc_memdevs(struct }dev_set_name (dev->mem_dev_r,"%s" ,"s5p-mfc-r" ); + dev->mem_dev_r->release = s5p_mfc_memdev_release;device_initialize (dev->mem_dev_r);of_property_read_u32_array (dev->plat_dev->dev.of_node,"samsung,mfc-r" , mem_info,2 );
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/s5p-mfc-set-device-name-for-reserved-memory-region-devs.patch queue-3.14/s5p-mfc-add-release-callback-for-memory-region-devs.patch