Skip to contentSkip to conversation

drm/radeon: only apply the SS fractional workaround to RS[78]80

PATCH In review Christian König 3 participants 6 messages Aug 18, 2016 4 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon: only apply the SS fractional workaround to RS[78]80

From: Christian König <[email protected]>

Looks like some RV6xx have problems with that.

---
 drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
index a97abc8..1dcf390 100644
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
 			if (radeon_crtc->ss.refdiv) {
 				radeon_crtc->pll_flags |= RADEON_PLL_USE_REF_DIV;
 				radeon_crtc->pll_reference_div = radeon_crtc->ss.refdiv;
-				if (rdev->family >= CHIP_RV770)
+				if (ASIC_IS_AVIVO(rdev) &&
+				    rdev->family != CHIP_RS780 &&
+				    rdev->family != CHIP_RS880)
 					radeon_crtc->pll_flags |= RADEON_PLL_USE_FRAC_FB_DIV;
 			}
 		}
Signature · 6 lines
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1471513874-1685-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#2 lore raw

Am 18.08.2016 um 11:51 schrieb Christian König:

Quoted 5 lines

From: Christian König <[email protected]>

Looks like some RV6xx have problems with that.

Ups, here should be a CC:stable as well.

Christian.

Quoted 9 lines
---
  drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios_crtc.c +0 -0
index a97abc8..1dcf390 100644

drivers/gpu/drm/radeon/atombios_crtc.c static u32 atombios_adjust_pll(struct drm_crtc *crtc, · line 635

Quoted 10 lines
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
  			if (radeon_crtc->ss.refdiv) {
  				radeon_crtc->pll_flags |= RADEON_PLL_USE_REF_DIV;
  				radeon_crtc->pll_reference_div = radeon_crtc->ss.refdiv;
-				if (rdev->family >= CHIP_RV770)
+				if (ASIC_IS_AVIVO(rdev) &&
+				    rdev->family != CHIP_RS780 &&
+				    rdev->family != CHIP_RS880)
  					radeon_crtc->pll_flags |= RADEON_PLL_USE_FRAC_FB_DIV;
  			}
  		}

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by Alex Deucher
#3 lore raw
In reply to a message not in the archive
Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Christian König
Sent: Thursday, August 18, 2016 5:51 AM
To: [email protected]
Cc: Deucher, Alexander
Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80

Quoted 5 lines

From: Christian König <[email protected]>

Looks like some RV6xx have problems with that.

Please mention the bugzilla in the patch. With that included:

Quoted 26 lines
---
 drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
index a97abc8..1dcf390 100644
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
 			if (radeon_crtc->ss.refdiv) {
 				radeon_crtc->pll_flags |=
 RADEON_PLL_USE_REF_DIV;
 				radeon_crtc->pll_reference_div =
 radeon_crtc->ss.refdiv;
-				if (rdev->family >= CHIP_RV770)
+				if (ASIC_IS_AVIVO(rdev) &&
+				    rdev->family != CHIP_RS780 &&
+				    rdev->family != CHIP_RS880)
 					radeon_crtc->pll_flags |=

RADEON_PLL_USE_FRAC_FB_DIV;

drivers/gpu/drm/radeon/atombios_crtc.c +0 -1
 			}
 		}
--

2.5.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): MWHPR12MB1694E3519417D4AF776C5A52F7150-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#5 lore raw
Quoted 9 lines · Alexander
Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Christian König
Sent: Thursday, August 18, 2016 5:51 AM
To: [email protected]
Cc: Deucher, Alexander
Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80

Quoted 8 lines
Quoted 5 lines

From: Christian König <[email protected]>

Looks like some RV6xx have problems with that.

Please mention the bugzilla in the patch. With that included:

Fixed up and applied.

Alex

Quoted 27 lines
Quoted 27 lines
---
 drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
index a97abc8..1dcf390 100644
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
                      if (radeon_crtc->ss.refdiv) {
                              radeon_crtc->pll_flags |=
 RADEON_PLL_USE_REF_DIV;
                              radeon_crtc->pll_reference_div =
 radeon_crtc->ss.refdiv;
-                             if (rdev->family >= CHIP_RV770)
+                             if (ASIC_IS_AVIVO(rdev) &&
+                                 rdev->family != CHIP_RS780 &&
+                                 rdev->family != CHIP_RS880)
                                      radeon_crtc->pll_flags |=
RADEON_PLL_USE_FRAC_FB_DIV;
                      }
              }

--
2.5.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CADnq5_OT4QFmXo29XG=FXG27UmzgpkUbngb_522rba-Jej1cYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#7 lore raw

Am 18.08.2016 um 17:18 schrieb Alex Deucher:

Quoted 11 lines
Quoted 9 lines · Alexander
Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Christian König
Sent: Thursday, August 18, 2016 5:51 AM
To: [email protected]
Cc: Deucher, Alexander
Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines

From: Christian König <[email protected]>

Looks like some RV6xx have problems with that.

Please mention the bugzilla in the patch. With that included:

Fixed up and applied.

Have you seen my follow up mail? E.g. did you added CC:stable as well?

Christian.

Quoted 37 lines

Alex

Quoted 34 lines
Quoted 23 lines
---
  drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
index a97abc8..1dcf390 100644
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
                       if (radeon_crtc->ss.refdiv) {
                               radeon_crtc->pll_flags |=
 RADEON_PLL_USE_REF_DIV;
                               radeon_crtc->pll_reference_div =
 radeon_crtc->ss.refdiv;
-                             if (rdev->family >= CHIP_RV770)
+                             if (ASIC_IS_AVIVO(rdev) &&
+                                 rdev->family != CHIP_RS780 &&
+                                 rdev->family != CHIP_RS880)
                                       radeon_crtc->pll_flags |=
RADEON_PLL_USE_FRAC_FB_DIV;
                       }
               }
Quoted 7 lines

--
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): eef71136-6cd2-5878-4a63-5c92f75eb5b5-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#9 lore raw
Quoted 24 lines

-----Original Message-----
From: Christian König [mailto:[email protected]]
Sent: Thursday, August 18, 2016 11:19 AM
To: Alex Deucher; Deucher, Alexander
Cc: [email protected]
Subject: Re: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80

Am 18.08.2016 um 17:18 schrieb Alex Deucher:

Quoted 4 lines
Quoted 2 lines · Alexander
Quoted 2 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On

Behalf

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Of Christian König
Sent: Thursday, August 18, 2016 5:51 AM
To: [email protected]
Cc: Deucher, Alexander
Subject: [PATCH] drm/radeon: only apply the SS fractional workaround

to

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

RS[78]80

From: Christian König <[email protected]>

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Looks like some RV6xx have problems with that.

Please mention the bugzilla in the patch. With that included:

Fixed up and applied.

Have you seen my follow up mail? E.g. did you added CC:stable as well?

Yes.

Alex

Quoted 10 lines

Christian.

Quoted 7 lines

Alex

Quoted 4 lines
Quoted 4 lines
---
  drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 32 lines
Quoted 6 lines
Quoted 6 lines

drivers/gpu/drm/radeon/atombios_crtc.c static u32 atombios_adjust_pll(struct drm_crtc

Quoted 6 lines
drivers/gpu/drm/radeon/atombios_crtc.c +0 -0
index a97abc8..1dcf390 100644
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc

*crtc,

Quoted 24 lines
Quoted 24 lines
Quoted 13 lines
drivers/gpu/drm/radeon/atombios_crtc.c +3 -1
                       if (radeon_crtc->ss.refdiv) {
                               radeon_crtc->pll_flags |=
 RADEON_PLL_USE_REF_DIV;
                               radeon_crtc->pll_reference_div =
 radeon_crtc->ss.refdiv;
-                             if (rdev->family >= CHIP_RV770)
+                             if (ASIC_IS_AVIVO(rdev) &&
+                                 rdev->family != CHIP_RS780 &&
+                                 rdev->family != CHIP_RS880)
                                       radeon_crtc->pll_flags |=
RADEON_PLL_USE_FRAC_FB_DIV;
                       }
               }
Quoted 7 lines

--
2.5.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx