Skip to contentSkip to conversation

Patch "drm/radeon: fix firmware info version checks" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 18, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

drm/radeon: fix firmware info version checks

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
drm-radeon-fix-firmware-info-version-checks.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3edc38a0facef45ee22af8afdce3737f421f36ab Mon Sep 17 00:00:00 2001

From: Alex Deucher <[email protected]>
Date: Wed, 27 Jul 2016 15:28:56 -0400
Subject: drm/radeon: fix firmware info version checks

From: Alex Deucher <[email protected]>

commit 3edc38a0facef45ee22af8afdce3737f421f36ab upstream.

Some of the checks didn't handle frev 2 tables properly.

---
 drivers/gpu/drm/radeon/radeon_atombios.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_atombios.c +2 -2
@@ -1155,7 +1155,7 @@ bool radeon_atom_get_clock_info(struct d
 		    le16_to_cpu(firmware_info->info.usReferenceClock);
 		p1pll->reference_div = 0;
 
-		if (crev < 2)
+		if ((frev < 2) && (crev < 2))
 			p1pll->pll_out_min =
 				le16_to_cpu(firmware_info->info.usMinPixelClockPLL_Output);
 		else
@@ -1164,7 +1164,7 @@ bool radeon_atom_get_clock_info(struct d
 		p1pll->pll_out_max =
 		    le32_to_cpu(firmware_info->info.ulMaxPixelClockPLL_Output);
 
-		if (crev >= 4) {
+		if (((frev < 2) && (crev >= 4)) || (frev >= 2)) {
 			p1pll->lcd_pll_out_min =
 				le16_to_cpu(firmware_info->info_14.usLcdMinPixelClockPLL_Output) * 100;
 			if (p1pll->lcd_pll_out_min == 0)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/drm-amdgpu-support-backlight-control-for-uniphy3.patch queue-4.4/drm-amdgpu-fix-firmware-info-version-checks.patch queue-4.4/drm-radeon-add-a-delay-after-atpx-dgpu-power-off.patch queue-4.4/drm-amdgpu-add-a-delay-after-atpx-dgpu-power-off.patch queue-4.4/drm-amdgpu-poll-for-both-connect-disconnect-on-analog-connectors.patch queue-4.4/drm-radeon-support-backlight-control-for-uniphy3.patch queue-4.4/drm-radeon-poll-for-both-connect-disconnect-on-analog-connectors.patch queue-4.4/drm-radeon-fix-firmware-info-version-checks.patch queue-4.4/drm-amdgpu-gmc7-add-missing-mullins-case.patch queue-4.4/drm-amdgpu-disable-rpm-helpers-while-reprobing-connectors-on-resume.patch