remoteproc: qcom: wcnss: Fix return value check in wcnss_probe()
Subsystems (2)
PATCH 1/1 remoteproc: qcom: wcnss: Fix return value check in wcnss_probe()
From: Wei Yongjun <[email protected]>
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/remoteproc/qcom_wcnss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/remoteproc/qcom_wcnss.c +2 -2
@@ -528,8 +528,8 @@ static int wcnss_probe(struct platform_device *pdev) res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"pmu" ); mmio =devm_ioremap_resource (&pdev->dev, res); -if (!mmio) { - ret = -ENOMEM ; +if (IS_ERR (mmio)) { + ret =PTR_ERR (mmio); goto free_rproc; };
Quoted 7 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
devm_ioremap_resource()returnsERR_PTR()and never returns NULL. The NULL test in the return value check should be replaced withIS_ERR().Signed-off-by Wei Yongjun <[email protected]>
Thanks Wei, applied to rproc-next.
Regards,
Bjorn
Quoted 19 lines
--- drivers/remoteproc/qcom_wcnss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/remoteproc/qcom_wcnss.c +2
-2@@ -528,8 +528,8 @@ static int wcnss_probe(struct platform_device *pdev) res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"pmu" ); mmio =devm_ioremap_resource (&pdev->dev, res); -if (!mmio) { - ret = -ENOMEM ; +if (IS_ERR (mmio)) { + ret =PTR_ERR (mmio); goto free_rproc; };