drm/i915: free intel_fb
Subsystems (2)
PATCH 1/1 drm/i915: free intel_fb
We need to free the allocated intel_fb in the error path, not intel_fb->base. Otherwise we risk calling kfree with a non-kmalloc'd address, which is bound to give us grief at some point.
--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -9798,7 +9798,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,return ; error: -kfree (fb); +kfree (intel_fb); } static void ironlake_get_pfit_config(struct intel_crtc *crtc,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Matthew Auld
We need to free the allocated
intel_fbin the error path, notintel_fb->base. Otherwise we risk calling kfree with a non-kmalloc'd address, which is bound to give us grief at some point.Signed-off-by Matthew Auld <[email protected]>
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: free intel_fb
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915: free intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : failure
== Summary ==
Series 11477v1 drm/i915: free intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)
Test kms_cursor_legacy:
Subgroup basic-cursor-vs-flip-legacy:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-cursor-vs-flip-varying-size:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (fi-bdw-5557u)
Subgroup basic-flip-vs-cursor-varying-size:
fail -> PASS (fi-bsw-n3050)
Test prime_busy:
Subgroup basic-after-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-before-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-after-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-before-default:
pass -> FAIL (fi-bsw-n3050)
Test prime_vgem:
Subgroup basic-busy-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-gtt:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-sync-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-default:
pass -> FAIL (fi-bsw-n3050)fi-bdw-5557u total:249 pass:232 dwarn:0 dfail:0 fail:1 skip:16 fi-bsw-n3050 total:249 pass:194 dwarn:0 dfail:0 fail:11 skip:44 fi-byt-n2820 total:249 pass:204 dwarn:0 dfail:0 fail:4 skip:41 fi-hsw-4770k total:249 pass:220 dwarn:6 dfail:0 fail:1 skip:22 fi-hsw-4770r total:249 pass:222 dwarn:0 dfail:0 fail:1 skip:26 fi-ivb-3520m total:249 pass:217 dwarn:0 dfail:0 fail:1 skip:31 fi-skl-6260u total:249 pass:234 dwarn:0 dfail:0 fail:1 skip:14 fi-skl-6700k total:249 pass:214 dwarn:4 dfail:0 fail:3 skip:28 fi-snb-2520m total:249 pass:201 dwarn:4 dfail:0 fail:2 skip:42 fi-snb-2600 total:249 pass:202 dwarn:4 dfail:0 fail:1 skip:42
Results at /archive/results/CI_IGT_test/Patchwork_2411/
d05ed1828321404c7fdf369ca17fa958938913bc drm-intel-nightly: 2016y-08m-23d-16h-32m-14s UTC integration manifest b9253f5 drm/i915: free intel_fb
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for drm/i915: free intel_fb
Quoted 6 lines · Patchwork
== Series Details ==
Series: drm/i915: free
intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : failure
Quoted 8 lines
== Summary ==
Series 11477v1 drm/i915: free
intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/Test
gem_exec_suspend:Subgroup basic-s3: incomplete -> DMESG-WARN (fi-hsw-4770k)
Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97465
Quoted 9 lines
Test
kms_cursor_legacy:Subgroup basic-cursor-vs-flip-legacy: pass -> FAIL (fi-bsw-n3050) Subgroup basic-cursor-vs-flip-varying-size: pass -> FAIL (fi-bsw-n3050) Subgroup basic-flip-vs-cursor-legacy: fail -> PASS (fi-bdw-5557u) Subgroup basic-flip-vs-cursor-varying-size: fail -> PASS (fi-bsw-n3050)
https://bugs.freedesktop.org/show_bug.cgi?id=97188
Quoted 9 lines
Test
prime_busy:Subgroup basic-after-default: pass -> FAIL (fi-bsw-n3050) Subgroup basic-before-default: pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-after-default: pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-before-default: pass -> FAIL (fi-bsw-n3050)
Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97463
Quoted 9 lines
Test
prime_vgem:Subgroup basic-busy-default: pass -> FAIL (fi-bsw-n3050) Subgroup basic-gtt: pass -> FAIL (fi-bsw-n3050) Subgroup basic-sync-default: pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-default: pass -> FAIL (fi-bsw-n3050)
Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97464
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerRe: ✗ Fi.CI.BAT: failure for drm/i915: free intel_fb
Hi,
There also seems to be SUCCESS results for the series, strange.
Anyway, pushed it. Thanks for the patch and review!
Regards, Joonas
Quoted 53 lines · Matthew Auld
Quoted 7 lines · Patchwork
== Series Details ==
Series: drm/i915: free
intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : failureQuoted 8 lines
== Summary ==
Series 11477v1 drm/i915: free
intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/Test
gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97465
Quoted 10 lines
Test
kms_cursor_legacy:
Subgroup basic-cursor-vs-flip-legacy:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-cursor-vs-flip-varying-size:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (fi-bdw-5557u) Subgroup basic-flip-vs-cursor-varying-size:
fail -> PASS (fi-bsw-n3050)https://bugs.freedesktop.org/show_bug.cgi?id=97188
Quoted 10 lines
Test
prime_busy:
Subgroup basic-after-default:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-before-default:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-after-default:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-before-default:
pass -> FAIL (fi-bsw-n3050)Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97463
Quoted 10 lines
Test
prime_vgem:
Subgroup basic-busy-default:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-gtt:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-sync-default:
pass -> FAIL (fi-bsw-n3050) Subgroup basic-wait-default:
pass -> FAIL (fi-bsw-n3050)Created bug report https://bugs.freedesktop.org/show_bug.cgi?id=97464
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for drm/i915: free intel_fb
Quoted 3 lines · Joonas Lahtinen
Hi,
There also seems to be SUCCESS results for the series, strange.
fi-bsw-n3050 was repaired and the test rerun, that seems to have done the trick.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: free intel_fb
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915: free intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : success
== Summary ==
Series 11477v1 drm/i915: free intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)
Test kms_cursor_legacy:
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (fi-bdw-5557u)fi-bdw-5557u total:249 pass:232 dwarn:0 dfail:0 fail:1 skip:16 fi-byt-n2820 total:249 pass:204 dwarn:0 dfail:0 fail:4 skip:41 fi-hsw-4770k total:249 pass:220 dwarn:6 dfail:0 fail:1 skip:22 fi-hsw-4770r total:249 pass:222 dwarn:0 dfail:0 fail:1 skip:26 fi-ivb-3520m total:249 pass:217 dwarn:0 dfail:0 fail:1 skip:31 fi-skl-6260u total:249 pass:234 dwarn:0 dfail:0 fail:1 skip:14 fi-skl-6700k total:249 pass:214 dwarn:4 dfail:0 fail:3 skip:28 fi-snb-2520m total:249 pass:201 dwarn:4 dfail:0 fail:2 skip:42 fi-snb-2600 total:249 pass:202 dwarn:4 dfail:0 fail:1 skip:42
Results at /archive/results/CI_IGT_test/Patchwork_2411/
d05ed1828321404c7fdf369ca17fa958938913bc drm-intel-nightly: 2016y-08m-23d-16h-32m-14s UTC integration manifest b9253f5 drm/i915: free intel_fb
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx