Skip to contentSkip to conversation

nvme-cli/fabrics: Added hostnqn parameter to connect command

PATCH New Roy Shterman 2 participants 3 messages Aug 23, 2016 – Aug 24, 2016 NVMe

lore
Share & tools
lore

Roy Shterman

author
#0 lore raw

PATCH 1/1 nvme-cli/fabrics: Added hostnqn parameter to connect command

Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and still connect to target with nvme-cli tool.

usage examples:
nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q <USER-DEFINED_HOSTNQN>

Signed-off-by Roy Shterman <roysh at mellanox.com>
---
 fabrics.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fabrics.c +2 -0
index 26c4e22..942e987 100644
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char **argv)
 			"transport address" },
 		{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid, required_argument,
 			"transport service id (e.g. IP port)" },
+		{"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn, required_argument,
+			"user-defined hostnqn" },
 		{0},
 	};
Signature · 1 line
1.7.8.2
#1 lore raw

PATCH 1/1 nvme-cli/fabrics: Added hostnqn parameter to connect command

Quoted 8 lines · Roy Shterman

Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and still
connect to target with nvme-cli tool.

usage examples:
nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
<USER-DEFINED_HOSTNQN>

I believe the example needs to be changed from 'discover' to 'connect' ;-)

Jay

Quoted 22 lines
Signed-off-by Roy Shterman <roysh at mellanox.com>

---
?fabrics.c |????2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)

fabrics.c +2 -0
index 26c4e22..942e987 100644
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
 **argv)
 ?			"transport address" },
 ?		{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
 required_argument,
 ?			"transport service id (e.g. IP port)" },
+		{"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
 required_argument,
+			"user-defined hostnqn" },

? {0},
? };
?

author
#2 lore raw

PATCH 1/1 nvme-cli/fabrics: Added hostnqn parameter to connect command

Quoted 6 lines · J Freyensee
Quoted 5 lines · Roy Shterman

Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and still
connect to target with nvme-cli tool.

Quoted 7 lines
Quoted 3 lines

usage examples:
nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
<USER-DEFINED_HOSTNQN>

I believe the example needs to be changed from 'discover' to 'connect' ;-)

Jay

That's correct, I will sent a new patch :)

Quoted 21 lines
Quoted 21 lines
Signed-off-by Roy Shterman <roysh at mellanox.com>
---
  fabrics.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
fabrics.c +2 -0
index 26c4e22..942e987 100644
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
 **argv)
  			"transport address" },
  		{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
 required_argument,
  			"transport service id (e.g. IP port)" },
+		{"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
 required_argument,
+			"user-defined hostnqn" },

  		{0},
  	};