netfilter: nf_tables: Use nla_put_be32() to dump immediate parameters
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nf_tables: Use nla_put_be32() to dump immediate parameters
nft_dump_register() should only be used with registers, not with immediates.
Fixes cb1b69b0b15b ("netfilter: nf_tables: add hash expression")
Fixes 91dbc6be0a62("netfilter: nf_tables: add number generator expression")
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nft_hash.c | 6 +++--- net/netfilter/nft_numgen.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)
net/netfilter/nft_hash.c +3 -3
@@ -88,11 +88,11 @@ static int nft_hash_dump(struct sk_buff *skb, goto nla_put_failure;if (nft_dump_register (skb,NFTA_HASH_DREG , priv->dreg)) goto nla_put_failure; -if (nft_dump_register (skb,NFTA_HASH_LEN , priv->len)) +if (nla_put_be32 (skb,NFTA_HASH_LEN ,htonl (priv->len))) goto nla_put_failure; -if (nft_dump_register (skb,NFTA_HASH_MODULUS , priv->modulus)) +if (nla_put_be32 (skb,NFTA_HASH_MODULUS ,htonl (priv->modulus))) goto nla_put_failure; -if (nft_dump_register (skb,NFTA_HASH_SEED , priv->seed)) +if (nla_put_be32 (skb,NFTA_HASH_SEED ,htonl (priv->seed))) goto nla_put_failure;return 0 ;
net/netfilter/nft_numgen.c +2 -2
@@ -68,9 +68,9 @@ static int nft_ng_dump(struct sk_buff *skb, enum nft_registers dreg, {if (nft_dump_register (skb,NFTA_NG_DREG , dreg)) goto nla_put_failure; -if (nft_dump_register (skb,NFTA_NG_UNTIL , until)) +if (nla_put_be32 (skb,NFTA_NG_UNTIL ,htonl (until))) goto nla_put_failure; -if (nft_dump_register (skb,NFTA_NG_TYPE , type)) +if (nla_put_be32 (skb,NFTA_NG_TYPE ,htonl (type))) goto nla_put_failure;return 0 ;
Signature · 1 line
2.1.4