Skip to contentSkip to conversation

omap3logic: Fix PBIAS Bug

PATCH In review aford173 at gmail.com 2 participants 3 messages Aug 26, 2016 – Sep 7, 2016

lore
Share & tools
lore

aford173 at gmail.com

author
#0 lore raw

PATCH 1/1 omap3logic: Fix PBIAS Bug

From: Adam Ford <[email protected]>

The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.

Signed-off-by Adam Ford <[email protected]>
board/logicpd/omap3som/omap3logic.c +0 -12
index 51d2987..c2bb730 100644
@@ -144,20 +144,8 @@ static struct musb_hdrc_platform_data musb_plat = {
  */
 int misc_init_r(void)
 {
-	t2_t *t2_base = (t2_t *)T2_BASE;
-	u32 pbias_lite;
-	/* set up dual-voltage GPIOs to 1.8V */
-	pbias_lite = readl(&t2_base->pbias_lite);
-	pbias_lite &= ~PBIASLITEVMODE1;
-	pbias_lite |= PBIASLITEPWRDNZ1;
-	writel(pbias_lite, &t2_base->pbias_lite);
-	if (get_cpu_family() == CPU_OMAP36XX)
-		writel(readl(CONTROL_WKUP_CTRL) | GPIO_IO_PWRDNZ,
-				CONTROL_WKUP_CTRL);
 	twl4030_power_init();
-
 	omap_die_id_display();
-	putc('\n');
 
 #ifdef CONFIG_USB_MUSB_OMAP2PLUS
 	musb_register(&musb_plat, &musb_board_data, (void *)MUSB_BASE);
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 omap3logic: Fix PBIAS Bug

board/logicpd/omap3som/omap3logic.c

Quoted 11 lines · On Fri, Aug 26, 2016 at 07:53:53AM -0500, aford173 at gmail.com wrote:

From: Adam Ford <[email protected]>

The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.

Signed-off-by Adam Ford <[email protected]>
board/logicpd/omap3som/omap3logic.c +0 -0
index 51d2987..c2bb730 100644
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160826/e8d67a91/attachment.sig>
#2 lore raw
In reply to aford173 at gmail.com

board/logicpd/omap3som/omap3logic.c

Quoted 12 lines · Adam Ford

From: Adam Ford <[email protected]>

The PBIAS fixing is done in the MMC driver, and doing it in the the board file conflicts with the driver causing intermittent hangs on reboot. Remove this from the board file and let the driver do it.

Signed-off-by Adam Ford <[email protected]>
Reviewed-by Tom Rini <[email protected]>
board/logicpd/omap3som/omap3logic.c +0 -0
index 51d2987..c2bb730 100644

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160907/c4160e29/attachment.sig>