arm64: dts: ls1043a/ls2080a serial updates
Subsystems (2)
cover arm64: dts: ls1043a/ls2080a serial updates
This patch series serial aliases for ls2080a-rdb/qds and ls1043a-rdb, fixes the aliases in ls1043a-qds and sets stdout-path for all the boards.
Stuart Yoder (2):
arm64: dts: updates serial aliases for ls1043a rdb and qds boards
arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 14 ++++++++------ arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 8 ++++++++ arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 3 +++ arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts | 4 ++++ 4 files changed, 23 insertions(+), 6 deletions(-)
Signature · 1 line
1.9.0
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
-add missing serial aliases to ls1043a-r4db
-update lss1043a-qds boards serial aliases to use the standard duarts
instead of low power uarts
--- arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 10 ++++------ arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++++ 2 files changed, 8 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4 -6
@@ -56,12 +56,10 @@ gpio1 = &gpio2; gpio2 = &gpio3; gpio3 = &gpio4; - serial0 = &lpuart0; - serial1 = &lpuart1; - serial2 = &lpuart2; - serial3 = &lpuart3; - serial4 = &lpuart4; - serial5 = &lpuart5; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3; }; };
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +4 -0
@@ -52,6 +52,10 @@ aliases { crypto = &crypto; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3; }; };
Signature · 1 line
1.9.0
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts line 62
Quoted 10 lines · CEST Stuart Yoder
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4
-6- serial0 = &lpuart0; - serial1 = &lpuart1; - serial2 = &lpuart2; - serial3 = &lpuart3; - serial4 = &lpuart4; - serial5 = &lpuart5; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3;
It looks like your board has six uarts that are all driven with the lpuart driver, but after the change, you only list four. Should the serial4 and serial5 aliases keep pointing at lpuart devices so you can still drive all physical connectors?
Arnd
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
Quoted 20 lines
-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Monday, August 29, 2016 6:01 AM
To: Stuart Yoder <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boardsarch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts line 62
Quoted 10 lines · CEST Stuart Yoder
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4
-6- serial0 = &lpuart0; - serial1 = &lpuart1; - serial2 = &lpuart2; - serial3 = &lpuart3; - serial4 = &lpuart4; - serial5 = &lpuart5; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3;
Quoted 4 lines
It looks like your board has six uarts that are all driven with the lpuart driver, but after the change, you only list four. Should the serial4 and serial5 aliases keep pointing at lpuart devices so you can still drive all physical connectors?
The only existing reference I can find to the serial aliases is if the OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console. The standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console, which is why I'm proposing making the 4 DUARTs the default serial aliases in the device tree.
There is a separate defconfig in u-boot to enable/use LPUARTs instead of the normal DUARTs. For that scenario, my take is that firmware should update the DT aliases to reflect the actual use of the serial ports.
But, the default should be the DUARTs which is the normal case for this board, which is why this patch is changing them.
Thanks,
Stuart
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
Quoted 24 lines · Stuart Yoder
Quoted 19 lines
-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Monday, August 29, 2016 6:01 AM
To: Stuart Yoder <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boardsarch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts line 62
Quoted 10 lines · CEST Stuart Yoder
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4
-6- serial0 = &lpuart0; - serial1 = &lpuart1; - serial2 = &lpuart2; - serial3 = &lpuart3; - serial4 = &lpuart4; - serial5 = &lpuart5; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3;Quoted 4 lines
It looks like your board has six uarts that are all driven with the lpuart driver, but after the change, you only list four. Should the serial4 and serial5 aliases keep pointing at lpuart devices so you can still drive all physical connectors?
Quoted 5 lines
The only existing reference I can find to the serial aliases is if the
OF_STDOUT_VIA_ALIASis enabled in u-boot to specify the console. The standardls1043aqds_defconfigin u-boot specifies DUARTs for the console, which is why I'm proposing making the 4 DUARTs the default serial aliases in the device tree.
Ok, so they are mutually exclusive, and the last two ports are unavailable in the default configuration?
Quoted 3 lines
There is a separate defconfig in u-boot to enable/use LPUARTs instead of the normal DUARTs. For that scenario, my take is that firmware should update the DT aliases to reflect the actual use of the serial ports.
Yes, makes sense.
Quoted 2 lines
But, the default should be the DUARTs which is the normal case for this board, which is why this patch is changing them.
Ok
Arnd
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
Quoted 34 lines
-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Monday, August 29, 2016 3:38 PM
To: linux-arm-kernel at lists.infradead.org
Cc: Stuart Yoder <[email protected]>; devicetree at vger.kernel.org; shawnguo at kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boardsQuoted 24 lines · Stuart Yoder
Quoted 23 lines
-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Monday, August 29, 2016 6:01 AM
To: Stuart Yoder <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boardsarch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts line 62
Quoted 10 lines · CEST Stuart Yoder
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4
-6- serial0 = &lpuart0; - serial1 = &lpuart1; - serial2 = &lpuart2; - serial3 = &lpuart3; - serial4 = &lpuart4; - serial5 = &lpuart5; + serial0 = &duart0; + serial1 = &duart1; + serial2 = &duart2; + serial3 = &duart3;It looks like your board has six uarts that are all driven with the lpuart driver, but after the change, you only list four. Should the serial4 and serial5 aliases keep pointing at lpuart devices so you can still drive all physical connectors?
Quoted 8 lines
Quoted 5 lines
The only existing reference I can find to the serial aliases is if the
OF_STDOUT_VIA_ALIASis enabled in u-boot to specify the console. The standardls1043aqds_defconfigin u-boot specifies DUARTs for the console, which is why I'm proposing making the 4 DUARTs the default serial aliases in the device tree.Ok, so they are mutually exclusive, and the last two ports are unavailable in the default configuration?
Yes, that's the case with u-boot's defconfig. I'm still trying to find out whether that mutual exlusivity was a firmware decision or a hardware limitation.
Stuart
PATCH 1/2 arm64: dts: updates serial aliases for ls1043a rdb and qds boards
In reply to Stuart YoderQuoted 1 line · Stuart Yoder
-add missing serial aliases to ls1043a-r4db
s/ls1043a-r4db/ls1043a-rdb
Shawn
Quoted 4 lines
-update lss1043a-qds boards serial aliases to use the standard duarts
instead of low power uartsSigned-off-by Stuart Yoder <[email protected]>
PATCH 2/2 arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards
In reply to Stuart YoderAdd a default stdout-path to chosen node for ls2080a/ls1043a boards to allow booting kernels without specifying console info in bootargs.
--- arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 4 ++++ arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++++ arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 3 +++ arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts | 4 ++++ 4 files changed, 15 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +4 -0
@@ -61,6 +61,10 @@ serial2 = &duart2; serial3 = &duart3; }; + + chosen { + stdout-path = "serial0:115200n8"; + }; }; &duart0 {
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +4 -0
@@ -57,6 +57,10 @@ serial2 = &duart2; serial3 = &duart3; }; + + chosen { + stdout-path = "serial0:115200n8"; + }; }; &i2c0 {
arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts +3 -0
@@ -57,6 +57,9 @@ serial1 = &serial1; }; + chosen { + stdout-path = "serial0:115200n8"; + }; }; &esdhc {
arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts +4 -0
@@ -56,6 +56,10 @@ serial0 = &serial0; serial1 = &serial1; }; + + chosen { + stdout-path = "serial1:115200n8"; + }; }; &esdhc {
Signature · 1 line
1.9.0