Skip to contentSkip to conversation

firmware: qcom: scm: Use devm_reset_controller_register()

PATCH In review Wei Yongjun 2 participants 2 messages Aug 28, 2016 – Oct 24, 2016 Arm Qualcomm mailing list

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: qcom: scm: Use devm_reset_controller_register()

From: Wei Yongjun <[email protected]>

Use devm_reset_controller_register() for the reset controller registration and fixes the memory leak when unload the module.

---
 drivers/firmware/qcom_scm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/qcom_scm.c +3 -1
index d95c702..9bf66ae 100644
@@ -356,7 +356,9 @@ static int qcom_scm_probe(struct platform_device *pdev)
 	scm->reset.ops = &qcom_scm_pas_reset_ops;
 	scm->reset.nr_resets = 1;
 	scm->reset.of_node = pdev->dev.of_node;
-	reset_controller_register(&scm->reset);
+	ret = devm_reset_controller_register(&pdev->dev, &scm->reset);
+	if (ret)
+		return ret;
 
 	/* vote for max clk rate for highest performance */
 	ret = clk_set_rate(scm->core_clk, INT_MAX);