Skip to contentSkip to conversation

drm/i915: remove leftover for_each_intel_crtc_masked

PATCH In review Jani Nikula 3 participants 4 messages Aug 25, 2016 – Aug 29, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: remove leftover for_each_intel_crtc_masked

The last user of for_each_intel_crtc_masked macro was removed in

commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b

Author: Ander Conselvan de Oliveira <[email protected]>
Date:   Tue Apr 21 17:13:04 2015 +0300

drm/i915: Remove all *_pipes flags from modeset

Get rid of the unused macro.

Cc Ander Conselvan de Oliveira <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -8
index e4e6141b38c0..19ffd024ddec 100644
@@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int clock2)
 	return false;
 }
 
-#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
-	list_for_each_entry((intel_crtc), \
-			    &(dev)->mode_config.crtc_list, \
-			    base.head) \
-		for_each_if (mask & (1 <<(intel_crtc)->pipe))
-
 static bool
 intel_compare_m_n(unsigned int m, unsigned int n,
 		  unsigned int m2, unsigned int n2,
@@ -14585,8 +14579,6 @@ out:
 		drm_atomic_state_free(state);
 }
 
-#undef for_each_intel_crtc_masked
-
 /*
  * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
  *        drm_atomic_helper_legacy_gamma_set() directly.
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: remove leftover for_each_intel_crtc_masked

== Series Details ==

== Series Details ==

Series: drm/i915: remove leftover for_each_intel_crtc_masked
URL : https://patchwork.freedesktop.org/series/11563/
State : failure

== Summary ==

Series 11563v1 drm/i915: remove leftover for_each_intel_crtc_masked
http://patchwork.freedesktop.org/api/1.0/series/11563/revisions/1/mbox/

Test drv_hangman:

        Subgroup error-state-basic:
                pass       -> DMESG-WARN (fi-snb-2520m)
Test gem_basic:
        Subgroup bad-close:
                dmesg-warn -> PASS       (fi-snb-2520m)
Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> INCOMPLETE (fi-hsw-4770k)
Test gem_ringfill:
        Subgroup basic-default-forked:
                pass       -> DMESG-WARN (fi-snb-2520m)
        Subgroup basic-default-hang:
                dmesg-warn -> PASS       (fi-snb-2520m)
fi-bdw-5557u     total:252  pass:235  dwarn:0   dfail:0   fail:2   skip:15 
fi-bsw-n3050     total:252  pass:205  dwarn:0   dfail:0   fail:1   skip:46 
fi-byt-n2820     total:252  pass:207  dwarn:0   dfail:0   fail:3   skip:42 
fi-hsw-4770k     total:107  pass:91   dwarn:0   dfail:0   fail:0   skip:15 
fi-hsw-4770r     total:252  pass:224  dwarn:0   dfail:0   fail:2   skip:26 
fi-ivb-3520m     total:252  pass:220  dwarn:0   dfail:0   fail:1   skip:31 
fi-skl-6260u     total:252  pass:236  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-6700k     total:252  pass:222  dwarn:0   dfail:0   fail:2   skip:28 
fi-snb-2520m     total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 
fi-snb-2600      total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 

Results at /archive/results/CI_IGT_test/Patchwork_2430/

30de872fd5cf71a51994375fb4f76856c05b1c4c drm-intel-nightly: 2016y-08m-25d-11h-15m-39s UTC integration manifest a57b606 drm/i915: remove leftover for_each_intel_crtc_masked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jani Nikula
Quoted 6 lines · Jani Nikula

The last user of for_each_intel_crtc_masked macro was removed in

commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
Author: Ander Conselvan de Oliveira <[email protected]> Date:   Tue Apr 21 17:13:04 2015 +0300

Quoted 6 lines

    drm/i915: Remove all *_pipes flags from modeset

Get rid of the unused macro.

Cc Ander Conselvan de Oliveira <[email protected]>
Quoted 29 lines

---
 drivers/gpu/drm/i915/intel_display.c | 8 --------

 1 file changed, 8 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index e4e6141b38c0..19ffd024ddec 100644
@@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
 clock2)
  	return false;
  }

drivers/gpu/drm/i915/intel_display.c +0 -6
-#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
-	list_for_each_entry((intel_crtc), \
-			    &(dev)->mode_config.crtc_list, \
-			    base.head) \
-		for_each_if (mask & (1 <<(intel_crtc)->pipe))
-

 static bool
 intel_compare_m_n(unsigned int m, unsigned int n, unsigned int m2, unsigned int n2,

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -14585,8 +14579,6 @@ out:
  		drm_atomic_state_free(state);
  }

drivers/gpu/drm/i915/intel_display.c +0 -2
-#undef for_each_intel_crtc_masked
-
Quoted 3 lines

 /*
  * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling *        drm_atomic_helper_legacy_gamma_set() directly.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 7 lines · Ander Conselvan De Oliveira
Quoted 6 lines · Jani Nikula

The last user of for_each_intel_crtc_masked macro was removed in

commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
Author: Ander Conselvan de Oliveira <[email protected]> Date:   Tue Apr 21 17:13:04 2015 +0300

Quoted 8 lines
Quoted 6 lines

    drm/i915: Remove all *_pipes flags from modeset

Get rid of the unused macro.

Cc Ander Conselvan de Oliveira <[email protected]>

Pushed, thanks.

BR,
Jani.

Quoted 33 lines
Quoted 33 lines

---
 drivers/gpu/drm/i915/intel_display.c | 8 --------

 1 file changed, 8 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index e4e6141b38c0..19ffd024ddec 100644
@@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
 clock2)
  	return false;
  }

drivers/gpu/drm/i915/intel_display.c +0 -6
-#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
-	list_for_each_entry((intel_crtc), \
-			    &(dev)->mode_config.crtc_list, \
-			    base.head) \
-		for_each_if (mask & (1 <<(intel_crtc)->pipe))
-

 static bool
 intel_compare_m_n(unsigned int m, unsigned int n, unsigned int m2, unsigned int n2,

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -14585,8 +14579,6 @@ out:
  		drm_atomic_state_free(state);
  }

drivers/gpu/drm/i915/intel_display.c +0 -2
-#undef for_each_intel_crtc_masked
-

 /*
  * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling *        drm_atomic_helper_legacy_gamma_set() directly.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx