geany-plugins: include GPLv3 in the main LICENSE
PATCH 1/1 geany-plugins: include GPLv3 in the main LICENSE
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE as possible improvement you can set LICENSE to GPLv2 to all plugins
which are GPLv2-only, because now they will "inherit" both GPLv2 &
GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/msg81645.html
--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1 -1
@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default -LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3" DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-native libassuan gpgme"
Signature · 1 line
2.9.2
Quoted 12 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-
plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/openembedded-core@lists.
openembedded.org/msg81645.html
Quoted 2 lines
Signed-off-by Martin Jansa <[email protected]>
Would be nice if we had a general way to change the inherited LICENSE as used by the binary packages. Adding a single indirection to package.bbclass to default to LICENSE_DEFAULT rather than LICENSE and defaulting LICENSE_DEFAULT to LICENSE would do (or similar), then this recipe could set LICENSE_DEFAULT to GPLv2.
In the meantime..
We have a bbappend in meta-mentor for this on a branch which handles it for this recipe reasonably, I think:
https://github.com/MentorEmbedded/meta-mentor/pull/843/commits/d852857
Signature · 5 lines
Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
Are you willing to submit such change to meta-oe?
I don't use geany, so my whole motivation was just to get rid of new warnings in world builds.
Quoted 41 lines · Christopher Larson
Quoted 12 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-
plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/openembedded-core@lists.
openembedded.org/msg81645.htmlQuoted 2 lines
Signed-off-by Martin Jansa <[email protected]>Would be nice if we had a general way to change the inherited LICENSE as used by the binary packages. Adding a single indirection to package.bbclass to default to
LICENSE_DEFAULTrather than LICENSE and defaultingLICENSE_DEFAULTto LICENSE would do (or similar), then this recipe could setLICENSE_DEFAULTto GPLv2.In the meantime..
We have a bbappend in meta-mentor for this on a branch which handles it for this recipe reasonably, I think:
https://github.com/MentorEmbedded/meta-mentor/pull/843/commits/d852857
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Andreas Müller
NAKQuoted 27 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE as possible improvement you can set LICENSE to GPLv2 to all plugins
which are GPLv2-only, because now they will "inherit" both GPLv2 &
GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/msg81645.htmlSigned-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-2@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default -LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3" DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-native libassuan gpgme" --
Quoted 2 lines
2.9.2
NAK: The warning is wrong see recipe below contains
LICENSE_${PN}-commander = "GPLv3"
Andreas
The warning is right in what it says.
The LICENSE variable now needs to contain all LICENSEs used in the recipe (all packages), see discussion on oe-core ML.
Quoted 48 lines · Andreas Müller
Quoted 1 line · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all
licenses used
Quoted 2 lines
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
Quoted 4 lines
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg81645.html
Review
Quoted 7 lines
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb line 6
Quoted 11 lines
index 9a39150..5e1e721 100644
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default -LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3" DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-nativelibassuan gpgme"
Quoted 4 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-1--2.9.2
NAK: The warning is wrong see recipe below contains
LICENSE_${PN}-commander = "GPLv3"
Andreas
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 49 lines · Martin Jansa
The warning is right in what it says.
The LICENSE variable now needs to contain all LICENSEs used in the recipe (all packages), see discussion on oe-core ML.
Quoted 41 lines · Andreas Müller
Quoted 1 line · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all
licenses used
Quoted 2 lines
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
Quoted 4 lines
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg81645.html
Review
Quoted 7 lines
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb line 6
Quoted 11 lines
index 9a39150..5e1e721 100644
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default -LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3" DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-nativelibassuan gpgme"
Quoted 4 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-1--2.9.2
NAK: The warning is wrong see recipe below contains
LICENSE_${PN}-commander = "GPLv3"
Ahh another 'design' decision I have problems with..
Andreas
Quoted 23 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany- plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/ms
g81645.htmlSigned-off-by Martin Jansa <[email protected]>---
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)meta- renamed from meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0oe/recipes-devtools/geany/geany-plugins_1.27.bb
index 9a39150..5e1e721 100644meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0@@ -1,7 +1,7 @@
Quoted 3 lines
DESCRIPTION = "A fast and lightweight IDE"
HOMEPAGE = "http://plugins.geany.org/"
# majority's default
^^^^^^^^^^
To avoid confusion, it'd be good to remove this comment as well as it's not only the majority of licenses anymore
Cheers,
Andre'
Quoted 9 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1-LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3"
DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-native libassuan gpgme"
--
2.9.2
Quoted 39 lines · André Draszik
Quoted 23 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-
plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/ms
g81645.htmlSigned-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta- renamed from meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0oe/recipes-devtools/geany/geany-plugins_1.27.bb
index 9a39150..5e1e721 100644meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb line 3
Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default^^^^^^^^^^To avoid confusion, it'd be good to remove this comment as well as it's not only the majority of licenses anymore
Cheers,
Andre'Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1-LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3"
Quoted 6 lines
Quoted 6 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-nativelibassuan gpgme"
--
2.9.2
And probably a note that 90% of license information is wrong...
Andreas
Quoted 40 lines · Andreas Müller
Quoted 39 lines · André Draszik
Quoted 23 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-
plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/ms
g81645.htmlSigned-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta- renamed from meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0oe/recipes-devtools/geany/geany-plugins_1.27.bb
index 9a39150..5e1e721 100644meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb line 3
Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default^^^^^^^^^^To avoid confusion, it'd be good to remove this comment as well as it's not only the majority of licenses anymore
Cheers,
Andre'Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1-LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3"
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-nativelibassuan gpgme"
--
2.9.2And probably a note that 90% of license information is wrong...
There are more issues in geany-plugins:
geany-plugins-1.27: geany-plugins: Files/directories were installed but not shipped in any package:
/usr/lib/geany/git-changebar.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
geany-plugins: 1 installed and not shipped files. [installed-vs-shipped]
geany-plugins-1.27: geany-plugins-scope rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps] geany-plugins-1.27: geany-plugins-debugger rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps] geany-plugins-1.27: geany-plugins-multiterm rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps]
It would be nice if someone actually using it send some fixes.
If nobody does in next week, I'll add PNBLACKLIST.
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 59 lines · Martin Jansa
Quoted 40 lines · Andreas Müller
Quoted 39 lines · André Draszik
Quoted 23 lines · Martin Jansa
* since last changes in oe-core LICENSE variable needs to list all licenses used
by individual packages otherwise bitbake warning like this is shown:
WARNING: meta-openembedded/meta-oe/recipes-devtools/geany/geany-
plugins_1.27.bb: LICENSE_geany-plugins-commander includes licenses (GPLv3) that are not listed in LICENSE
as possible improvement you can set LICENSE to GPLv2 to all plugins which are GPLv2-only, because now they will "inherit" both GPLv2 & GPLv3 which sucks as described here:
https://www.mail-archive.com/[email protected]/ms
g81645.htmlSigned-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta- renamed from meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0oe/recipes-devtools/geany/geany-plugins_1.27.bb
index 9a39150..5e1e721 100644meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb line 3
Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0@@ -1,7 +1,7 @@ DESCRIPTION = "A fast and lightweight IDE" HOMEPAGE = "http://plugins.geany.org/" # majority's default^^^^^^^^^^To avoid confusion, it'd be good to remove this comment as well as it's not only the majority of licenses anymore
Cheers,
Andre'Quoted 3 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +1
-1-LICENSE = "GPLv2" +LICENSE = "GPLv2 & GPLv3"Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
meta-oe/recipes-devtools/geany/geany-plugins_1.27.bb +0
-0DEPENDS = "geany lua libxml2 libsoup-2.4 vte enchant intltool-nativelibassuan gpgme"
--
2.9.2And probably a note that 90% of license information is wrong...
There are more issues in geany-plugins:
geany-plugins-1.27: geany-plugins: Files/directories were installed but not shipped in any package:
/usr/lib/geany/git-changebar.so
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them withindo_install.
geany-plugins: 1 installed and not shipped files. [installed-vs-shipped]
geany-plugins-1.27: geany-plugins-scope rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps] geany-plugins-1.27: geany-plugins-debugger rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps] geany-plugins-1.27: geany-plugins-multiterm rdepends on libvte9, but it isn't a build dependency, missing vte9 in DEPENDS or PACKAGECONFIG? [build-deps]
Quoted 4 lines
It would be nice if someone actually using it send some fixes.
If nobody does in next week, I'll add PNBLACKLIST.
Heard :) I will fix it. Don't ask when - my master images are broken as never seen before thanks to gcc-6 and cmake modifications.
Andreas