Skip to contentSkip to conversation

Patch "usb: misc: usbtest: usbtest_do_ioctl may return positive integer" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 2, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: misc: usbtest: usbtest_do_ioctl may return positive integer

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-misc-usbtest-usbtest_do_ioctl-may-return-positive-integer.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 528d28138f91009f230903bd89ccd44719667831 Mon Sep 17 00:00:00 2001

From: Peter Chen <[email protected]>
Date: Tue, 26 Jul 2016 16:01:30 +0800
Subject: usb: misc: usbtest: usbtest_do_ioctl may return positive integer

From: Peter Chen <[email protected]>

commit 528d28138f91009f230903bd89ccd44719667831 upstream.

For case 14 and case 21, their correct return value is the number of bytes transferred, so it is a positive integer. But in usbtest_ioctl, it takes non-zero as false return value for usbtest_do_ioctl, so it will treat the correct test as wrong test, then the time on tests will be the minus value.

Fixes 18fc4ebdc705 ("usb: misc: usbtest: Remove timeval usage")
---
 drivers/usb/misc/usbtest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/misc/usbtest.c +1 -1
@@ -2603,7 +2603,7 @@ usbtest_ioctl(struct usb_interface *intf
 	ktime_get_ts64(&start);
 
 	retval = usbtest_do_ioctl(intf, param_32);
-	if (retval)
+	if (retval < 0)
 		goto free_mutex;
 
 	ktime_get_ts64(&end);

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/usb-misc-usbtest-usbtest_do_ioctl-may-return-positive-integer.patch queue-4.7/usb-gadget-fsl_qe_udc-off-by-one-in-setup_received_handle.patch