Skip to contentSkip to conversation

Patch "i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
i2c-cros-ec-tunnel-fix-usage-of-cros_ec_cmd_xfer.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4d01d88019261d05ec3bff5f1a6013393faa3b9e Mon Sep 17 00:00:00 2001

From: Brian Norris <[email protected]>
Date: Wed, 10 Aug 2016 13:37:18 -0700
Subject: i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

From: Brian Norris <[email protected]>

commit 4d01d88019261d05ec3bff5f1a6013393faa3b9e upstream.

cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these problems. Let's use it.

[Regarding the 'Fixes' tag; there is significant refactoring since the driver's introduction, but the underlying logical error exists throughout I believe]

---
 drivers/i2c/busses/i2c-cros-ec-tunnel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-cros-ec-tunnel.c +1 -1
@@ -215,7 +215,7 @@ static int ec_i2c_xfer(struct i2c_adapte
 	msg->outsize = request_len;
 	msg->insize = response_len;
 
-	result = cros_ec_cmd_xfer(bus->ec, msg);
+	result = cros_ec_cmd_xfer_status(bus->ec, msg);
 	if (result < 0) {
 		dev_err(dev, "Error transferring EC i2c message %d\n", result);
 		goto exit;

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/i2c-cros-ec-tunnel-fix-usage-of-cros_ec_cmd_xfer.patch queue-4.7/iio-fix-sched-warning-do-not-call-blocking-ops-when-task_running.patch queue-4.7/mfd-cros_ec-add-cros_ec_cmd_xfer_status-helper.patch