Skip to contentSkip to conversation

Patch "pinctrl: meson: Drop pinctrl_unregister for devm_ registered device" has been added to the 4.7-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pinctrl: meson: Drop pinctrl_unregister for devm_ registered device

to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pinctrl-meson-drop-pinctrl_unregister-for-devm_-registered-device.patch
and it can be found in the queue-4.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5b236d0fde21d88351420ef0b9a6cb7aeeea0c54 Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Tue, 26 Jul 2016 14:51:58 +0000
Subject: pinctrl: meson: Drop pinctrl_unregister for devm_ registered device

From: Wei Yongjun <[email protected]>

commit 5b236d0fde21d88351420ef0b9a6cb7aeeea0c54 upstream.

It's not necessary to unregister pin controller device registered with devm_pinctrl_register() and using pinctrl_unregister() leads to a double free.

This is detected by Coccinelle semantic patch.

Fixes e649f7ec8c5f ("pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration")
---
 drivers/pinctrl/meson/pinctrl-meson.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/pinctrl/meson/pinctrl-meson.c +1 -7
@@ -727,13 +727,7 @@ static int meson_pinctrl_probe(struct pl
 		return PTR_ERR(pc->pcdev);
 	}
 
-	ret = meson_gpiolib_register(pc);
-	if (ret) {
-		pinctrl_unregister(pc->pcdev);
-		return ret;
-	}
-
-	return 0;
+	return meson_gpiolib_register(pc);
 }
 
 static struct platform_driver meson_pinctrl_driver = {

Patches currently in stable-queue which might be from [email protected] are

queue-4.7/pinctrl-meson-drop-pinctrl_unregister-for-devm_-registered-device.patch queue-4.7/virtio-fix-memory-leak-in-virtqueue_add.patch queue-4.7/usb-renesas_usbhs-gadget-fix-return-value-check-in-usbhs_mod_gadget_probe.patch