Skip to contentSkip to conversation

Patch "ALSA: line6: Remove double line6_pcm_release() after failed acquire." has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 5, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: line6: Remove double line6_pcm_release() after failed acquire.

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-line6-remove-double-line6_pcm_release-after-failed-acquire.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7e4379eae0e31994ea645db1d13006ea8e5ce539 Mon Sep 17 00:00:00 2001

From: Andrej Krutak <[email protected]>
Date: Thu, 18 Aug 2016 23:52:10 +0200
Subject: ALSA: line6: Remove double line6_pcm_release() after failed acquire.

From: Andrej Krutak <[email protected]>

commit 7e4379eae0e31994ea645db1d13006ea8e5ce539 upstream.

If there's an error, pcm is released in line6_pcm_acquire already.

Fixes 247d95ee6dd2 ('ALSA: line6: Handle error from line6_pcm_acquire()')
---
 sound/usb/line6/pcm.c |    1 -
 1 file changed, 1 deletion(-)
sound/usb/line6/pcm.c +0 -1
@@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(
 		err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE);
 		if (err < 0) {
 			line6pcm->impulse_volume = 0;
-			line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE);
 			return err;
 		}
 	} else {

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-line6-give-up-on-the-lock-while-urbs-are-released.patch queue-4.4/alsa-line6-remove-double-line6_pcm_release-after-failed-acquire.patch queue-4.4/alsa-line6-fix-pod-sysfs-attributes-segfault.patch