ARM: dts: imx23: Remove skeleton.dtsi inclusion

PATCH New Fabio Estevam 5 participants 11 messages Sep 5, 2016 – Nov 5, 2016

Subsystems (3)

Device tree bindings Arm i.MX and Layerscape Arm STM32

lore

Share & tools

lore

Fabio Estevam

author reviewer

2016-09-05 19:27 UTC #0 lore raw

PATCH v2 1/4 ARM: dts: imx23: Remove skeleton.dtsi inclusion

From: Fabio Estevam <[email protected]>

Remove skeleton.dtsi to avoid the following build warning with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Remove skeleton.dtsi dependency (Rob)

 arch/arm/boot/dts/imx23.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

arch/arm/boot/dts/imx23.dtsi +3 -1

index 440ee9a..9d0e9e1 100644
@@ -9,10 +9,12 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include "skeleton.dtsi"
 #include "imx23-pinfunc.h"
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
 	interrupt-parent = <&icoll>;
 
 	aliases {

Signature · 1 line

1.9.1

Fabio Estevam

author reviewer

2016-09-05 19:27 UTC #1 lore raw

PATCH v2 2/4 ARM: dts: imx28: Remove skeleton.dtsi inclusion

From: Fabio Estevam <[email protected]>

Remove skeleton.dtsi to avoid the following build warning with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Remove skeleton.dtsi dependency (Rob)

 arch/arm/boot/dts/imx28.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

arch/arm/boot/dts/imx28.dtsi +3 -1

index 0ad893b..3aabf65 100644
@@ -10,10 +10,12 @@
  */
 
 #include <dt-bindings/gpio/gpio.h>
-#include "skeleton.dtsi"
 #include "imx28-pinfunc.h"
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
 	interrupt-parent = <&icoll>;
 
 	aliases {

Signature · 1 line

1.9.1

Fabio Estevam

author reviewer

2016-09-05 19:27 UTC #2 lore raw

PATCH v2 3/4 ARM: dts: imx23: Fix build warnings with W=1

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following build warnings with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

While at it, also pass the 'device_type' property as recommended by the ePAPR specification.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None

 arch/arm/boot/dts/imx23-evk.dts           | 3 ++-
 arch/arm/boot/dts/imx23-olinuxino.dts     | 3 ++-
 arch/arm/boot/dts/imx23-sansa.dts         | 3 ++-
 arch/arm/boot/dts/imx23-stmp378x_devb.dts | 3 ++-
 arch/arm/boot/dts/imx23-xfi3.dts          | 3 ++-
 5 files changed, 10 insertions(+), 5 deletions(-)

arch/arm/boot/dts/imx23-evk.dts +2 -1

index 57e2997..bd06402 100644
@@ -16,7 +16,8 @@
 	model = "Freescale i.MX23 Evaluation Kit";
 	compatible = "fsl,imx23-evk", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx23-olinuxino.dts +2 -1

index a8b1c53..109f516 100644
@@ -19,7 +19,8 @@
 	model = "i.MX23 Olinuxino Low Cost Board";
 	compatible = "olimex,imx23-olinuxino", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};

arch/arm/boot/dts/imx23-sansa.dts +2 -1

index 4ec32f4..9cf40d3 100644
@@ -48,7 +48,8 @@
 	model = "SanDisk Sansa Fuze+";
 	compatible = "sandisk,sansa_fuze_plus", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};

arch/arm/boot/dts/imx23-stmp378x_devb.dts +2 -1

index 455169e..aab0293 100644
@@ -16,7 +16,8 @@
 	model = "Freescale STMP378x Development Board";
 	compatible = "fsl,stmp378x-devb", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};

arch/arm/boot/dts/imx23-xfi3.dts +2 -1

index 025cf94..2b5df8d 100644
@@ -48,7 +48,8 @@
 	model = "Creative ZEN X-Fi3";
 	compatible = "creative,x-fi3", "fsl,imx23";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};

Signature · 1 line

1.9.1

Stefan Wahren

2016-09-12 20:09 UTC #3 lore raw

PATCH v2 3/4 ARM: dts: imx23: Fix build warnings with W=1

Quoted 9 lines

Fabio Estevam <[email protected]> hat am 5. September 2016 um 21:27 geschrieben:
From: Fabio Estevam <[email protected]>
Fix the following build warnings with W=1:

Quoted 7 lines

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
While at it, also pass the 'device_type' property as recommended by the ePAPR specification.
Signed-off-by Fabio Estevam <[email protected]>

Patch 1 and 3 works for my Olinuxino board.

Tested-by Stefan Wahren <[email protected]>

Fabio Estevam

author reviewer

2016-09-05 19:27 UTC #4 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following build warnings with W=1:

Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name

While at it, also pass the 'device_type' property as recommended by the ePAPR specification.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- None

 arch/arm/boot/dts/imx28-apf28.dts            | 3 ++-
 arch/arm/boot/dts/imx28-apx4devkit.dts       | 3 ++-
 arch/arm/boot/dts/imx28-cfa10036.dts         | 3 ++-
 arch/arm/boot/dts/imx28-duckbill.dts         | 3 ++-
 arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts | 3 ++-
 arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts | 3 ++-
 arch/arm/boot/dts/imx28-evk.dts              | 3 ++-
 arch/arm/boot/dts/imx28-m28.dtsi             | 3 ++-
 arch/arm/boot/dts/imx28-m28cu3.dts           | 3 ++-
 arch/arm/boot/dts/imx28-sps1.dts             | 3 ++-
 arch/arm/boot/dts/imx28-tx28.dts             | 3 ++-
 11 files changed, 22 insertions(+), 11 deletions(-)

arch/arm/boot/dts/imx28-apf28.dts +2 -1

index 070e59c..b6976fb 100644
@@ -16,7 +16,8 @@
 	model = "Armadeus Systems APF28 module";
 	compatible = "armadeus,imx28-apf28", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-apx4devkit.dts +2 -1

index 1092b76..ce6115e 100644
@@ -5,7 +5,8 @@
 	model = "Bluegiga APX4 Development Kit";
 	compatible = "bluegiga,apx4devkit", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};

arch/arm/boot/dts/imx28-cfa10036.dts +2 -1

index 570aa33..d016a3b 100644
@@ -16,7 +16,8 @@
 	model = "Crystalfontz CFA-10036 Board";
 	compatible = "crystalfontz,cfa10036", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-duckbill.dts +2 -1

index ce1a7ef..b5bc3f5 100644
@@ -16,7 +16,8 @@
 	model = "I2SE Duckbill";
 	compatible = "i2se,duckbill", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts +2 -1

index 7c1572c..28dab6d 100644
@@ -23,7 +23,8 @@
 	model = "Eukrea Electromatique MBMX283LC";
 	compatible = "eukrea,mbmx283lc", "eukrea,mbmx28lc", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x04000000>;
 	};
 };

arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts +2 -1

index e773144..08125e5 100644
@@ -22,7 +22,8 @@
 	model = "Eukrea Electromatique MBMX287LC";
 	compatible = "eukrea,mbmx287lc", "eukrea,mbmx283lc", "eukrea,mbmx28lc", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};
 };

arch/arm/boot/dts/imx28-evk.dts +2 -1

index a5ba669..4cd8216 100644
@@ -16,7 +16,8 @@
 	model = "Freescale i.MX28 Evaluation Kit";
 	compatible = "fsl,imx28-evk", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-m28.dtsi +2 -1

index 214bb15..1bcba90 100644
@@ -15,7 +15,8 @@
 	model = "DENX M28";
 	compatible = "denx,m28", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-m28cu3.dts +2 -1

index 2df63be..c4c4cc7 100644
@@ -16,7 +16,8 @@
 	model = "MSR M28CU3";
 	compatible = "msr,m28cu3", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-sps1.dts +2 -1

index 0ce3cb8..5ddfb16 100644
@@ -16,7 +16,8 @@
 	model = "SchulerControl GmbH, SC SPS 1";
 	compatible = "schulercontrol,imx28-sps1", "fsl,imx28";
 
-	memory {
+	memory at 40000000 {
+		device_type = "memory";
 		reg = <0x40000000 0x08000000>;
 	};

arch/arm/boot/dts/imx28-tx28.dts +2 -1

index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
+	memory at 0 {
+		device_type = "memory";
 		reg = <0 0>; /* will be filled in by U-Boot */
 	};

Signature · 1 line

1.9.1

Shawn Guo

2016-09-08 14:03 UTC #5 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

arch/arm/boot/dts/imx28-tx28.dts line 40

Quoted 12 lines · Fabio Estevam

arch/arm/boot/dts/imx28-tx28.dts +2 -1

index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
 		usbotg = &usb0;
 	};
 
-	memory {
+	memory at 0 {
+		device_type = "memory";
 		reg = <0 0>; /* will be filled in by U-Boot */

I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

Shawn

Quoted 10 lines

arch/arm/boot/dts/imx28-tx28.dts +0 -0

};

Signature · 7 lines

1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Lothar Waßmann

2016-09-09 07:14 UTC #6 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

Hi,

Quoted 9 lines · On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:

Quoted 8 lines · Fabio Estevam
arch/arm/boot/dts/imx28-tx28.dts +0 -0
index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
 		usbotg = &usb0;
 	};
 

Quoted 8 lines

arch/arm/boot/dts/imx28-tx28.dts line 40
Quoted 4 lines
arch/arm/boot/dts/imx28-tx28.dts +2 -1
-	memory {
+	memory at 0 {
+		device_type = "memory";
 		reg = <0 0>; /* will be filled in by U-Boot */
I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

No. U-Boot does not change the unit name, when updating in the reg property. But that does not do any harm (for now), thus the change is OK.

Lothar Wa?mann

Shawn Guo

2016-09-12 12:09 UTC #7 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

Quoted 20 lines · Lothar Wa?mann

Hi,
Quoted 9 lines · On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
Quoted 8 lines · Fabio Estevam
arch/arm/boot/dts/imx28-tx28.dts +0 -0
index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
 		usbotg = &usb0;
 	};
 
Quoted 8 lines
arch/arm/boot/dts/imx28-tx28.dts line 40
Quoted 4 lines
arch/arm/boot/dts/imx28-tx28.dts +2 -1
-	memory {
+	memory at 0 {
+		device_type = "memory";
 		reg = <0 0>; /* will be filled in by U-Boot */
I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

Quoted 3 lines

No. U-Boot does not change the unit name, when updating in the reg property. But that does not do any harm (for now), thus the change is OK.

This is confusing when people is looking at nodes in /proc/device-tree. Why cannot we give it a reasonable default configuration instead of <0 0>?

Shawn

Javier Martinez Canillas

2016-09-12 12:24 UTC #8 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

Hello Shawn,

Quoted 21 lines · Shawn Guo

Quoted 20 lines · Lothar Wa?mann
Hi,
Quoted 17 lines · On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
arch/arm/boot/dts/imx28-tx28.dts line 40
Quoted 12 lines · Fabio Estevam
arch/arm/boot/dts/imx28-tx28.dts +2 -1
index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
          usbotg = &usb0;
  };
 
- memory {
+ memory at 0 {
+         device_type = "memory";
          reg = <0 0>; /* will be filled in by U-Boot */
I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

Quoted 8 lines

Quoted 3 lines
No. U-Boot does not change the unit name, when updating in the reg property. But that does not do any harm (for now), thus the change is OK.
This is confusing when people is looking at nodes in /proc/device-tree. Why cannot we give it a reasonable default configuration instead of <0 0>?

Another option is to not have a memory node if the start address is not known at build time, since U-boot creates a memory node if is not found in the FDT.

Quoted 2 lines

Shawn

Best regards,
Javier

Fabio Estevam

author reviewer

2016-11-04 20:51 UTC #9 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

In reply to Shawn Guo

Hi Shawn,

Quoted 9 lines · Shawn Guo

Quoted 8 lines · Fabio Estevam
arch/arm/boot/dts/imx28-tx28.dts +0 -0
index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
              usbotg = &usb0;
      };
 

Quoted 7 lines

arch/arm/boot/dts/imx28-tx28.dts line 40
Quoted 4 lines
arch/arm/boot/dts/imx28-tx28.dts +2 -1
-     memory {
+     memory at 0 {
+             device_type = "memory";
              reg = <0 0>; /* will be filled in by U-Boot */
I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

Should I resend this series and keep imx28-tx28.dts unmodified?

Shawn Guo

2016-11-05 07:05 UTC #10 lore raw

PATCH v2 4/4 ARM: dts: imx28: Fix build warnings with W=1

Quoted 20 lines · Fabio Estevam

Hi Shawn,
Quoted 9 lines · Shawn Guo
Quoted 8 lines · Fabio Estevam
arch/arm/boot/dts/imx28-tx28.dts +0 -0
index 0ebbc83..b4d4dbb 100644
@@ -35,7 +35,8 @@
              usbotg = &usb0;
      };
 
Quoted 7 lines
arch/arm/boot/dts/imx28-tx28.dts line 40
Quoted 4 lines
arch/arm/boot/dts/imx28-tx28.dts +2 -1
-     memory {
+     memory at 0 {
+             device_type = "memory";
              reg = <0 0>; /* will be filled in by U-Boot */
I'm curious to know if the unit-address will be fixed up or not when 'reg' property gets updated by U-Boot.

Quoted 1 line

Should I resend this series and keep imx28-tx28.dts unmodified?

Yeah, probably the best thing we can do.

Shawn