Skip to contentSkip to conversation

GVT-g guest patch for 4.8

PATCH In review Zhenyu Wang 5 participants 11 messages Sep 6, 2016

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Zhenyu Wang

author
#0 lore raw

cover GVT-g guest patch for 4.8

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH 1/2 drm/i915: enable vGPU detection for all

From: Ping Gao <[email protected]>

vGPU capability is handled by GVT-g host driver, not needed to put extra HW check for vGPU detection. And we'll actually support vGPU from BDW.

Signed-off-by Ping Gao <[email protected]>
Signed-off-by Zhenyu Wang <[email protected]>
---
 drivers/gpu/drm/i915/i915_vgpu.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/i915_vgpu.c +0 -3
index ca2e912..dae340c 100644
@@ -65,9 +65,6 @@ void i915_check_vgpu(struct drm_i915_private *dev_priv)
 
 	BUILD_BUG_ON(sizeof(struct vgt_if) != VGT_PVINFO_SIZE);
 
-	if (!IS_HASWELL(dev_priv))
-		return;
-
 	magic = __raw_i915_read64(dev_priv, vgtif_reg(magic));
 	if (magic != VGT_MAGIC)
 		return;
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] drm/i915: enable vGPU detection for all

Quoted 8 lines · Zhenyu Wang

From: Ping Gao <[email protected]>

vGPU capability is handled by GVT-g host driver, not needed to put extra HW check for vGPU detection. And we'll actually support vGPU from BDW.

Signed-off-by Ping Gao <[email protected]>
Signed-off-by Zhenyu Wang <[email protected]>
Reviewed-by Joonas Lahtinen <[email protected]>
Quoted 18 lines

---
 drivers/gpu/drm/i915/i915_vgpu.c | 3 ---

 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/i915_vgpu.c +0 -0
index ca2e912..dae340c 100644
@@ -65,9 +65,6 @@ void i915_check_vgpu(struct drm_i915_private *dev_priv)


  BUILD_BUG_ON(sizeof(struct vgt_if) != VGT_PVINFO_SIZE);

drivers/gpu/drm/i915/i915_vgpu.c +0 -3
-	if (!IS_HASWELL(dev_priv))
-		return;
-

  magic = __raw_i915_read64(dev_priv, vgtif_reg(magic)); if (magic != VGT_MAGIC)
  return;

Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#3 lore raw

PATCH 2/2 drm/i915: disable 48bit full PPGTT when vGPU is active

In reply to Zhenyu Wang

From: Zhi Wang <[email protected]>

Disable 48bit full PPGTT on vGPU too for now.

Signed-off-by Zhi Wang <[email protected]>
Signed-off-by Zhenyu Wang <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +6 -3
index 570e731..e16c380 100644
@@ -124,8 +124,11 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
 	has_full_48bit_ppgtt =
 	       	IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9;
 
-	if (intel_vgpu_active(dev_priv))
-		has_full_ppgtt = false; /* emulation is too hard */
+	if (intel_vgpu_active(dev_priv)) {
+		/* emulation is too hard */
+		has_full_ppgtt = false;
+		has_full_48bit_ppgtt = false;
+	}
 
 	if (!has_aliasing_ppgtt)
 		return 0;

@@ -160,7 +163,7 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
 		return 0;
 	}
 
-	if (INTEL_GEN(dev_priv) >= 8 && i915.enable_execlists)
+	if (INTEL_GEN(dev_priv) >= 8 && i915.enable_execlists && has_full_ppgtt)
 		return has_full_48bit_ppgtt ? 3 : 2;
 	else
 		return has_aliasing_ppgtt ? 1 : 0;
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] drm/i915: disable 48bit full PPGTT when vGPU is active

Quoted 6 lines · Zhenyu Wang

From: Zhi Wang <[email protected]>

Disable 48bit full PPGTT on vGPU too for now.

Signed-off-by Zhi Wang <[email protected]>
Signed-off-by Zhenyu Wang <[email protected]>
Reviewed-by Joonas Lahtinen <[email protected]>

Regards, Joonas

Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI
#5 lore raw

✗ Fi.CI.BAT: warning for GVT-g guest patch for 4.8

In reply to Zhenyu Wang
== Series Details ==

== Series Details ==

Series: GVT-g guest patch for 4.8
URL : https://patchwork.freedesktop.org/series/12026/
State : warning

== Summary ==

Series 12026v1 GVT-g guest patch for 4.8
http://patchwork.freedesktop.org/api/1.0/series/12026/revisions/1/mbox/

Test drv_module_reload_basic:

                pass       -> SKIP       (fi-skl-6260u)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b:
                skip       -> PASS       (fi-hsw-4770r)
        Subgroup read-crc-pipe-b:
                skip       -> PASS       (fi-skl-6260u)
        Subgroup read-crc-pipe-c:
                skip       -> PASS       (fi-hsw-4770r)
fi-bdw-5557u     total:252  pass:233  dwarn:2   dfail:1   fail:1   skip:15 
fi-bsw-n3050     total:252  pass:203  dwarn:1   dfail:1   fail:1   skip:46 
fi-byt-n2820     total:252  pass:206  dwarn:2   dfail:1   fail:2   skip:41 
fi-hsw-4770k     total:252  pass:226  dwarn:2   dfail:1   fail:1   skip:22 
fi-hsw-4770r     total:252  pass:222  dwarn:2   dfail:1   fail:1   skip:26 
fi-ivb-3520m     total:252  pass:217  dwarn:2   dfail:1   fail:1   skip:31 
fi-skl-6260u     total:252  pass:233  dwarn:2   dfail:1   fail:1   skip:15 
fi-skl-6700k     total:252  pass:219  dwarn:3   dfail:1   fail:1   skip:28 
fi-snb-2520m     total:252  pass:204  dwarn:2   dfail:1   fail:2   skip:43 
fi-snb-2600      total:252  pass:205  dwarn:2   dfail:1   fail:1   skip:43

Results at /archive/results/CI_IGT_test/Patchwork_2470/

9baa666b3e48f71b46c5f63541f57d2a95a1b1c0 drm-intel-nightly: 2016y-09m-03d-12h-12m-15s UTC integration manifest 82e85de drm/i915: disable 48bit full PPGTT when vGPU is active
5d4cfb7 drm/i915: enable vGPU detection for all

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Acked-by on the v1 series
#6 lore raw
In reply to Zhenyu Wang
Quoted 10 lines · Zhenyu Wang

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Quoted 6 lines

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Acked-by Chris Wilson <[email protected]>

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#7 lore raw
Quoted 14 lines · Chris Wilson
Quoted 13 lines · Zhenyu Wang

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

Quoted 6 lines
Quoted 3 lines
 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Acked-by Chris Wilson <[email protected]>

-Chris

So these are needed for 4.8?

Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#8 lore raw
Quoted 15 lines · Jani Nikula
Quoted 14 lines · Chris Wilson
Quoted 13 lines · Zhenyu Wang

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Acked-by Chris Wilson <[email protected]>

-Chris

So these are needed for 4.8?

Yeah, we'd like to support any distribution that will base on 4.8 kernel for guest VM. So would require these changes.

thanks

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#9 lore raw
Quoted 21 lines · Zhenyu Wang

[ Unknown signature status ]

Quoted 19 lines · Jani Nikula
Quoted 18 lines · Chris Wilson
Quoted 16 lines · Zhenyu Wang

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Acked-by Chris Wilson <[email protected]>

-Chris

So these are needed for 4.8?

Yeah, we'd like to support any distribution that will base on 4.8 kernel for guest VM. So would require these changes.

Both pushed to dinq with Cc: drm-intel-fixes, thanks for the patches and review.

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#10 lore raw
Quoted 25 lines · Jani Nikula
Quoted 24 lines · Zhenyu Wang

[ Unknown signature status ]

Quoted 22 lines · Jani Nikula
Quoted 20 lines · Chris Wilson
Quoted 10 lines · Zhenyu Wang

Hi,

Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM.

thanks.

Ping Gao (1):
drm/i915: enable vGPU detection for all

Quoted 6 lines

Zhi Wang (1):
drm/i915: disable 48bit full PPGTT when vGPU is active

 drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++++++---
 drivers/gpu/drm/i915/i915_vgpu.c    | 3 ---
 2 files changed, 6 insertions(+), 6 deletions(-)
Acked-by Chris Wilson <[email protected]>

-Chris

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

So these are needed for 4.8?

Yeah, we'd like to support any distribution that will base on 4.8 kernel for guest VM. So would require these changes.

Both pushed to dinq with Cc: drm-intel-fixes, thanks for the patches and review.

And picked up to fixes to be queued for 4.8.

Quoted 3 lines

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx