net: xfrm: Change u32 sysctl entries to use proc_douintvec

PATCH In review Subash Abhinov Kasiviswanathan 3 participants 4 messages Sep 7, 2016 – Sep 8, 2016

Subsystems (3)

Networking Network drivers Networking IPsec

lore

Share & tools

lore

Subash Abhinov Kasiviswanathan

author

2016-09-07 00:10 UTC #0 lore raw

PATCH 1/1 net: xfrm: Change u32 sysctl entries to use proc_douintvec

proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX.

Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>

---
 net/xfrm/xfrm_sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

net/xfrm/xfrm_sysctl.c +2 -2

index 05a6e3d..35a7e79 100644
@@ -17,13 +17,13 @@ static struct ctl_table xfrm_table[] = {
 		.procname	= "xfrm_aevent_etime",
 		.maxlen		= sizeof(u32),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_douintvec
 	},
 	{
 		.procname	= "xfrm_aevent_rseqth",
 		.maxlen		= sizeof(u32),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_douintvec
 	},
 	{
 		.procname	= "xfrm_larval_drop",

Signature · 1 line

1.9.1

David Miller

maintainer

2016-09-08 00:25 UTC #1 lore raw

From: Subash Abhinov Kasiviswanathan <[email protected]>
Date: Tue, 6 Sep 2016 18:09:31 -0600

Quoted 4 lines

proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX.
Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>

I am assuming Steffen will pick this up.

Steffen Klassert

maintainer Acked-by

2016-09-08 06:51 UTC #2 lore raw

Quoted 9 lines · David Miller

From: Subash Abhinov Kasiviswanathan <[email protected]>
Date: Tue, 6 Sep 2016 18:09:31 -0600
Quoted 4 lines
proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX.
Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>
I am assuming Steffen will pick this up.

proc_douintvec is not in the ipsec-next tree. The ipsec-next tree is currently based on net-next from Aug 9. The patch that introduces proc_douintvec came in on Aug 25.

I can take it after the pull request for ipsec-next, that I plan to do today. Alternatively, you can take it directly into net-next. It does not interfere anything that I have in ipsec-next. In case you want to take it directly:

Acked-by Steffen Klassert <[email protected]>

David Miller

maintainer

2016-09-08 06:27 UTC #3 lore raw

From: Steffen Klassert <[email protected]>
Date: Thu, 8 Sep 2016 07:51:17 +0200

Quoted 15 lines · David Miller

Quoted 9 lines
From: Subash Abhinov Kasiviswanathan <[email protected]>
Date: Tue, 6 Sep 2016 18:09:31 -0600
Quoted 4 lines
proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX.
Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>
I am assuming Steffen will pick this up.
proc_douintvec is not in the ipsec-next tree. The ipsec-next tree is currently based on net-next from Aug 9. The patch that introduces proc_douintvec came in on Aug 25.

Quoted 6 lines

I can take it after the pull request for ipsec-next, that I plan to do today. Alternatively, you can take it directly into net-next. It does not interfere anything that I have in ipsec-next. In case you want to take it directly:
Acked-by Steffen Klassert <[email protected]>

Ok, I've applied it to net-next then, thanks!