Skip to contentSkip to conversation

PCI: artpec6: drop __init from artpec6_add_pcie_port

PATCH Applied Niklas Cassel 2 participants 2 messages Sep 9, 2016 – Sep 14, 2016 PCI

lore
Share & tools
lore

Niklas Cassel

author
#0 lore raw

PATCH 1/1 PCI: artpec6: drop __init from artpec6_add_pcie_port

From: Niklas Cassel <[email protected]>

artpec6_add_pcie_port is called from artpec6_pcie_probe. artpec6_pcie_probe does not have the __init section marker. It is wrong to have the marker on artpec6_add_pcie_port when the marker is not on artpec6_pcie_probe.

Signed-off-by Niklas Cassel <[email protected]>
---
 drivers/pci/host/pcie-artpec6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/host/pcie-artpec6.c +2 -2
index 16ba70b7..39bf1a6 100644
@@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
 	return dw_handle_msi_irq(pp);
 }
 
-static int __init artpec6_add_pcie_port(struct pcie_port *pp,
-					struct platform_device *pdev)
+static int artpec6_add_pcie_port(struct pcie_port *pp,
+				 struct platform_device *pdev)
 {
 	int ret;
Signature · 1 line
2.1.4
Applied
#1 lore raw
Quoted 8 lines · Niklas Cassel

From: Niklas Cassel <[email protected]>

artpec6_add_pcie_port is called from artpec6_pcie_probe. artpec6_pcie_probe does not have the __init section marker. It is wrong to have the marker on artpec6_add_pcie_port when the marker is not on artpec6_pcie_probe.

Signed-off-by Niklas Cassel <[email protected]>

Applied to pci/host-artpec for v4.9, thanks!

Quoted 26 lines
---
 drivers/pci/host/pcie-artpec6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pci/host/pcie-artpec6.c +2 -2
index 16ba70b7..39bf1a6 100644
@@ -191,8 +191,8 @@ static irqreturn_t artpec6_pcie_msi_handler(int irq, void *arg)
 	return dw_handle_msi_irq(pp);
 }
 
-static int __init artpec6_add_pcie_port(struct pcie_port *pp,
-					struct platform_device *pdev)
+static int artpec6_add_pcie_port(struct pcie_port *pp,
+				 struct platform_device *pdev)
 {
 	int ret;
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html