Patch "[PATCH 131/135] drm/i915: Check VBT for port presence in addition to" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
[PATCH 131/135] drm/i915: Check VBT for port presence in addition to
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
0131-drm-i915-Check-VBT-for-port-presence-in-addition-to-.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
d8cee6a0e346789b7f813fd84f6a8c2a084d15c4Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <[email protected]>
Date: Thu, 7 Jul 2016 16:24:29 +0800
Subject: [PATCH 131/135] drm/i915: Check VBT for port presence in addition to
the strap on VLV/CHV
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
[ Upstream commit 22f35042593c2b369861f0b9740efb8065a42db0 ]
Apparently some CHV boards failed to hook up the port presence straps for HDMI ports as well (earlier we assumed this problem only affected eDP ports). So let's check the VBT in addition to the strap, and if either one claims that the port is present go ahead and register the relevant connector.
While at it, change port D to register DP before HDMI as we do for ports B and C since
commit 457c52d87e5d ("drm/i915: Only ignore eDP ports that are connected")
Also print a debug message when we register a HDMI connector to aid in diagnosing missing/incorrect ports. We already had such a print for DP/eDP.
v2: Improve the comment in the code a bit, note the port D change in
the commit message
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96321
--- drivers/gpu/drm/i915/i915_drv.h | 3 ++ drivers/gpu/drm/i915/intel_bios.c | 39 +++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_display.c | 30 ++++++++++++++++++-------- drivers/gpu/drm/i915/intel_hdmi.c | 3 ++ 4 files changed, 66 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +3 -0
@@ -3313,6 +3313,9 @@ static inline bool intel_gmbus_is_forced }extern void intel_i2c_reset (struct drm_device *dev); +/* intel_bios.c */ +bool intel_bios_is_port_present (struct drm_i915_private *dev_priv,enum port port); +/* intel_opregion.c */ #ifdef CONFIG_ACPI extern int intel_opregion_setup (struct drm_device *dev);
drivers/gpu/drm/i915/intel_bios.c +39 -0
@@ -1351,3 +1351,42 @@ intel_parse_bios(struct drm_device *dev)return 0 ; } + +/** +* intel_bios_is_port_present - is the specified digital port present +* @dev_priv: i915 device instance +* @port: port to check +* +* Return true if the device in %port is present. +*/ +bool intel_bios_is_port_present (struct drm_i915_private *dev_priv,enum port port) +{ +static const struct { +u16 dp, hdmi; + } port_mapping[] = { + [PORT_B ] = {DVO_PORT_DPB ,DVO_PORT_HDMIB , }, + [PORT_C ] = {DVO_PORT_DPC ,DVO_PORT_HDMIC , }, + [PORT_D ] = {DVO_PORT_DPD ,DVO_PORT_HDMID , }, + [PORT_E ] = {DVO_PORT_DPE ,DVO_PORT_HDMIE , }, + }; +int i; + +/* FIXME maybe deal with port A as well? */ +if (WARN_ON (port ==PORT_A ) || port >=ARRAY_SIZE (port_mapping)) +return false; + +if (!dev_priv->vbt.child_dev_num) +return false; + +for (i =0 ; i < dev_priv->vbt.child_dev_num; i++) { +const union child_device_config *p_child = + &dev_priv->vbt.child_dev[i]; +if ((p_child->common.dvo_port == port_mapping[port].dp || + p_child->common.dvo_port == port_mapping[port].hdmi) && + (p_child->common.device_type & (DEVICE_TYPE_TMDS_DVI_SIGNALING | +DEVICE_TYPE_DISPLAYPORT_OUTPUT ))) +return true; + } + +return false; +}
drivers/gpu/drm/i915/intel_display.c +21 -9
@@ -14160,7 +14160,7 @@ static void intel_setup_outputs(struct dif (I915_READ (PCH_DP_D ) &DP_DETECTED )intel_dp_init (dev,PCH_DP_D ,PORT_D ); }else if (IS_VALLEYVIEW (dev)) { -bool has_edp; +bool has_edp, has_port;/* * The DP_DETECTED bit is the latched state of the DDC
@@ -14170,25 +14170,37 @@ static void intel_setup_outputs(struct d* Thus we can't rely on the DP_DETECTED bit alone to detect * eDP ports. Consult the VBT as well as DP_DETECTED to * detect eDP ports. +* +* Sadly the straps seem to be missing sometimes even for HDMI +* ports (eg. on Voyo V3 - CHT x7-Z8700), so check both strap +* and VBT for the presence of the port. Additionally we can't +* trust the port type the VBT declares as we've seen at least +* HDMI ports that the VBT claim are DP or eDP. */ has_edp =intel_dp_is_edp (dev,PORT_B ); -if (I915_READ (VLV_DP_B ) &DP_DETECTED || has_edp) + has_port =intel_bios_is_port_present (dev_priv,PORT_B ); +if (I915_READ (VLV_DP_B ) &DP_DETECTED || has_port) has_edp &=intel_dp_init (dev,VLV_DP_B ,PORT_B ); -if (I915_READ (VLV_HDMIB ) &SDVO_DETECTED && !has_edp) +if ((I915_READ (VLV_HDMIB ) &SDVO_DETECTED || has_port) && !has_edp)intel_hdmi_init (dev,VLV_HDMIB ,PORT_B ); has_edp =intel_dp_is_edp (dev,PORT_C ); -if (I915_READ (VLV_DP_C ) &DP_DETECTED || has_edp) + has_port =intel_bios_is_port_present (dev_priv,PORT_C ); +if (I915_READ (VLV_DP_C ) &DP_DETECTED || has_port) has_edp &=intel_dp_init (dev,VLV_DP_C ,PORT_C ); -if (I915_READ (VLV_HDMIC ) &SDVO_DETECTED && !has_edp) +if ((I915_READ (VLV_HDMIC ) &SDVO_DETECTED || has_port) && !has_edp)intel_hdmi_init (dev,VLV_HDMIC ,PORT_C );if (IS_CHERRYVIEW (dev)) { -/* eDP not supported on port D, so don't check VBT */ -if (I915_READ (CHV_HDMID ) &SDVO_DETECTED ) -intel_hdmi_init (dev,CHV_HDMID ,PORT_D ); -if (I915_READ (CHV_DP_D ) &DP_DETECTED ) +/* +* eDP not supported on port D, +* so no need to worry about it +*/ + has_port =intel_bios_is_port_present (dev_priv,PORT_D ); +if (I915_READ (CHV_DP_D ) &DP_DETECTED || has_port)intel_dp_init (dev,CHV_DP_D ,PORT_D ); +if (I915_READ (CHV_HDMID ) &SDVO_DETECTED || has_port) +intel_hdmi_init (dev,CHV_HDMID ,PORT_D ); }intel_dsi_init (dev);
drivers/gpu/drm/i915/intel_hdmi.c +3 -0
@@ -2030,6 +2030,9 @@ void intel_hdmi_init_connector(struct inenum port port = intel_dig_port->port;uint8_t alternate_ddc_pin; +DRM_DEBUG_KMS ("Adding HDMI connector on port %c\n" , +port_name (port)); +drm_connector_init (dev, connector, &intel_hdmi_connector_funcs,DRM_MODE_CONNECTOR_HDMIA );drm_connector_helper_add (connector, &intel_hdmi_connector_helper_funcs);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0131-drm-i915-Check-VBT-for-port-presence-in-addition-to-.patch queue-4.4/0130-drm-i915-Only-ignore-eDP-ports-that-are-connected.patch queue-4.4/0111-drm-Balance-error-path-for-GEM-handle-allocation.patch queue-4.4/0087-drm-i915-Fix-hpd-live-status-bits-for-g4x.patch