Skip to contentSkip to conversation

Patch "[PATCH 133/135] netfilter: x_tables: check for size overflow" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 9, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[PATCH 133/135] netfilter: x_tables: check for size overflow

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
0133-netfilter-x_tables-check-for-size-overflow.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 857d46ff805805aeb539429216be3db548b03350 Mon Sep 17 00:00:00 2001

From: Florian Westphal <[email protected]>
Date: Wed, 13 Jul 2016 11:44:54 +0100
Subject: [PATCH 133/135] netfilter: x_tables: check for size overflow

[ Upstream commit d157bd761585605b7882935ffb86286919f62ea1 ]

Ben Hawkes says:
integer overflow in xt_alloc_table_info, which on 32-bit systems can lead to small structure allocation and a copy_from_user based heap corruption.

---
 net/netfilter/x_tables.c |    3 +++
 1 file changed, 3 insertions(+)
net/netfilter/x_tables.c +3 -0
@@ -897,6 +897,9 @@ struct xt_table_info *xt_alloc_table_inf
 	struct xt_table_info *info = NULL;
 	size_t sz = sizeof(*info) + size;
 
+	if (sz < sizeof(*info))
+		return NULL;
+
 	/* Pedantry: prevent them from hitting BUG() in vmalloc.c --RR */
 	if ((SMP_ALIGN(size) >> PAGE_SHIFT) + 2 > totalram_pages)
 		return NULL;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/0133-netfilter-x_tables-check-for-size-overflow.patch